Hi Inaki
Your excellent work with the LDAP clones plugin has helped me a lot of the last year or so. I was wondering if you'd had a chance to create a new plugin for Moodle 3.2.2? I've tried the ldap-clones-patch-script_3.2_v1.zip and get the errors in the attached file.
Thanks
Darren
Hi Darren,
here's an updated version for Moodle 3.2.2+ (Build: 20170316). It also applies cleanly to 3.2.2 (Build: 20170313).
Saludos. Iñaki.
Hi Inaki
That's is fantastic, thank you very much for your help. You are a life saver.
Thanks
Darren
Hi Iñaki,
I've sent you a PM about this as well, but is there a possibility of a 3.3 patch?
It looks like everything has changed with the LDAP plugin in this release. Has anyone else encountered issues?
Kind regards,
Anthony
Hi Anthony,
I'm trying to apply this patch por Moodle 3.3 using he latest I found: ldap-clones-patch-script_3.2.2_v2, and I'm having the next message:
patching file auth/ldap/auth.php
Hunk #42 FAILED at 1827.
Hunk #43 FAILED at 1989.
Hunk #44 succeeded at 1828 (offset -180 lines).
Hunk #45 succeeded at 1837 (offset -180 lines).
Hunk #46 succeeded at 1884 (offset -180 lines).
Hunk #47 succeeded at 1993 (offset -180 lines).
Hunk #48 FAILED at 2223.
Hunk #49 succeeded at 2065 (offset -198 lines).
3 out of 49 hunks FAILED -- saving rejects to file auth/ldap/auth.php.rej
patching file auth/ldap/classes/task/sync_task.php
patching file auth/ldap/cli/sync_users.php
can't find file to patch at input line 608
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/auth/ldap/config.html b/auth/ldap/config.html
|index 883eb9d0b52..084dd592d9a 100644
|--- a/auth/ldap/config.html
|+++ b/auth/ldap/config.html
--------------------------
File to patch:
Regards,
Monica
Hi Monica,
I wanted to reply as you directed your message at me.
It's not something I would be able to help you with, but hopefully Iñaki or another can.
It looks like the settings.php file in 3.3 has superseded the config.html file in lesser versions, which is why the patching is failing. There is no config.html file anymore.
Anthony
Hi,
I've been unable to get some spare time to work on this, but I finally managed to have some
Here are a couple of versions, one for 3.3, a second one for 3.3.1 (this one applies to 3.3 with just a warning about a single hunk, but i decided to create a separate one for 3.3).
Hope this helps.
Saludos. Iñaki.
Hi Iñaki,
Thank very much for your time and the new version patch, it's going to be very useful for our site.
I've seen a small mistake I think: in version 3.3.1, at ldapname.diff you are using ldap2 instead of '/auth/'.$this->authtype.'...', so you get an error if you use a different name of ldap2 for the new ldap.
Thanks again, un saludo
Mónica
Hi Mónica,
you are absolutely right! There are so many places where you have to tweak things, that I skipped over a few of them
Here are updated versions, with all those mistakes fixed.
Saludos. Iñaki.
