MOODLE_16_STABLE was broken this weekend when someone (I hope accidentally!) reset the whole branch so that it matched HEAD. It took quite a lot of hours to fix and the MOODLE_16_STABLE history will never be quite the same as it was. (See MDL-9032).
Does anyone remember doing anything that could possibly have caused this? The person who did it would have had to manually override the natural CVS mechanism which prevents the moving of such tags (-B flag).
It would be nice to know what happened but to be on the safe side we'll be blocking branching commands to make sure this doesn't happen again.
MOODLE_16_STABLE was broken this weekend, got any information?
by Martin Dougiamas -
Number of replies: 4
In reply to Martin Dougiamas
Re: MOODLE_16_STABLE was broken this weekend, got any information?
by Howard Miller -
I've wondered about this before..are cvs tag commands not logged anywhere? It is a shame they don't get stored in the history somewhere.
PS. Not me... honest!
PS. Not me... honest!
In reply to Howard Miller
Re: MOODLE_16_STABLE was broken this weekend, got any information?
by Martin Dougiamas -
No, I don't think branch moves were being logged.
In reply to Martin Dougiamas
Re: MOODLE_16_STABLE was broken this weekend, got any information?
by Martín Langhoff -
How! What a mess!
Just trying to see if cvs's history has any hints as to wtf happened there. The only big big commit is from 'moodler' on the 25th (SF.net time) which must be when you fixed it up.
There are a couple of large-ish commits by skodak and stronk7 but nowhere near what it would take to get this problem to happen. And tag operations, which are logged, don't turn up anything - at least since the 21st.
What I am running to get a full history is
cvs history -D 2007-03-22 -a -l -x 'TOEFWUCGMAR' | tee cvshistory
and then I filter our checkouts and updates like this:
grep -v '^\(U\|C\|G\|O\|W\)' cvshistory | grep 'moodle/' | sort -k 2 | less
This shows all the tags applied/moved since the 15th, again, nothing out of the ordinary.
cvs history -D 2007-03-15 -a -l -x 'T'
All of this is very weird... does anyone have a snapshot of the repo before the problem was reverted?
Just trying to see if cvs's history has any hints as to wtf happened there. The only big big commit is from 'moodler' on the 25th (SF.net time) which must be when you fixed it up.
There are a couple of large-ish commits by skodak and stronk7 but nowhere near what it would take to get this problem to happen. And tag operations, which are logged, don't turn up anything - at least since the 21st.
What I am running to get a full history is
cvs history -D 2007-03-22 -a -l -x 'TOEFWUCGMAR' | tee cvshistory
and then I filter our checkouts and updates like this:
grep -v '^\(U\|C\|G\|O\|W\)' cvshistory | grep 'moodle/' | sort -k 2 | less
This shows all the tags applied/moved since the 15th, again, nothing out of the ordinary.
cvs history -D 2007-03-15 -a -l -x 'T'
All of this is very weird... does anyone have a snapshot of the repo before the problem was reverted?
In reply to Martín Langhoff
Re: MOODLE_16_STABLE was broken this weekend, got any information?
by Martin Dougiamas -
I tried this but I couldn't see any branch tags being moved.
I do have a rsync copy of the repository, updated weekly but I don't think it will help much.
All the old history for MOODLE_16_STABLE is still in the SF repository somewhere, it's just not numbered properly. I suppose someone could conceivably still rebuild it perfectly but I think it would take a huge amount of work to re-tag so many versions and files.
For example, see http://moodle.cvs.sourceforge.net/moodle/moodle/index.php
you can see the MOODLE_16_MERGED flag is still sitting in the old location at 1.161.2.5, but the current latest revision of MOODLE_16_STABLE is now 1.161.2.5.2.2 (when they used to be the same). The only reason they are so close is because we went back to MOODLE_16_BETA and added the MOODLE_16_STABLE branch again there.
All the other branches seem to be fine.
I do have a rsync copy of the repository, updated weekly but I don't think it will help much.
All the old history for MOODLE_16_STABLE is still in the SF repository somewhere, it's just not numbered properly. I suppose someone could conceivably still rebuild it perfectly but I think it would take a huge amount of work to re-tag so many versions and files.
For example, see http://moodle.cvs.sourceforge.net/moodle/moodle/index.php
you can see the MOODLE_16_MERGED flag is still sitting in the old location at 1.161.2.5, but the current latest revision of MOODLE_16_STABLE is now 1.161.2.5.2.2 (when they used to be the same). The only reason they are so close is because we went back to MOODLE_16_BETA and added the MOODLE_16_STABLE branch again there.
All the other branches seem to be fine.