Indenting lost from comments in the Moodle Tracker

Indenting lost from comments in the Moodle Tracker

Tim Hunt發表於
Number of replies: 5
Core developers的相片 Documentation writers的相片 Particularly helpful Moodlers的相片 Peer reviewers的相片 Plugin developers的相片
So I don't forget, the bug I was trying to file was:


Summary: Code gets mangled when pasted into a bug report

Description: For example: MDL-6752. All the new code that I am being asked to consider has lost its indent, which is a pain in the neck. Is there any way round this?

(It's not that difficult to copy and paste the code into an editor, and reindent it, but it would be nice if I did not have to.)
評比平均分數: -
In reply to Tim Hunt

Re: Catch-22 at tracker

Thomas Robb發表於
People who submit code should be asked to upload it as a text file if it involves indentation (as it should).  This is what I did for my yet unresolved submission MDL-6249.
In reply to Thomas Robb

Re: Catch-22 at tracker

Martín Langhoff發表於
And yet, it's invaluable to be able to post code, and post back comments on the code. Code as attachments means it's harder to review the actual code.

+1 for making it usable to post diffs straight there, without attachments.
In reply to Martín Langhoff

Indenting lost from comments in the Moodle Tracker

Martin Dougiamas發表於
Core developers的相片 Documentation writers的相片 Moodle HQ的相片 Particularly helpful Moodlers的相片 Plugin developers的相片 Testers的相片
It sort of works ... it seems to only collapse non-leading whitespace

See MDL-6732 (feel free to test in there)
In reply to Martin Dougiamas

Re: Indenting lost from comments in the Moodle Tracker

Martín Langhoff發表於
I can see it. It messes up diffs! 傷心

Looking at the html source, it's replacing spaces with   but only leading/trailing spaces, not within the line -- maybe it could respect PRE tags in the comments to support pasting code?

{comment also in bug}