Indenting lost from comments in the Moodle Tracker

Indenting lost from comments in the Moodle Tracker

by Tim Hunt -
Number of replies: 5
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
So I don't forget, the bug I was trying to file was:


Summary: Code gets mangled when pasted into a bug report

Description: For example: MDL-6752. All the new code that I am being asked to consider has lost its indent, which is a pain in the neck. Is there any way round this?

(It's not that difficult to copy and paste the code into an editor, and reindent it, but it would be nice if I did not have to.)
Average of ratings: -
In reply to Tim Hunt

Re: Catch-22 at tracker

by Thomas Robb -
People who submit code should be asked to upload it as a text file if it involves indentation (as it should).  This is what I did for my yet unresolved submission MDL-6249.
In reply to Thomas Robb

Re: Catch-22 at tracker

by Martín Langhoff -
And yet, it's invaluable to be able to post code, and post back comments on the code. Code as attachments means it's harder to review the actual code.

+1 for making it usable to post diffs straight there, without attachments.
In reply to Martín Langhoff

Indenting lost from comments in the Moodle Tracker

by Martin Dougiamas -
Picture of Core developers Picture of Documentation writers Picture of Moodle HQ Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers
It sort of works ... it seems to only collapse non-leading whitespace

See MDL-6732 (feel free to test in there)
In reply to Martin Dougiamas

Re: Indenting lost from comments in the Moodle Tracker

by Martín Langhoff -
I can see it. It messes up diffs! sad

Looking at the html source, it's replacing spaces with   but only leading/trailing spaces, not within the line -- maybe it could respect PRE tags in the comments to support pasting code?

{comment also in bug}