LTI 1.3 Content selection - 'Add to gradebook' shown when grade sync is turned off

LTI 1.3 Content selection - 'Add to gradebook' shown when grade sync is turned off

by Greg Myles -
Number of replies: 2

Hi,

When we turn grade sync off on an activity (e.g. a quiz) in the tool, the option to 'add to gradebook' is still offered in the platform's content selection window. This is confusing for users who would reasonably expect to be able to add it to their gradebook if offered.

It looks like the option to 'add to gradebook' is based on the activity type alone - I'm wondering whether there's a good reason for this, or whether it's one for the tracker?


grade sync on


Add to gradebook

Average of ratings: -
In reply to Greg Myles

Re: LTI 1.3 Content selection - 'Add to gradebook' shown when grade sync is turned off

by Jake Dallimore -
Picture of Core developers Picture of Moodle HQ Picture of Peer reviewers Picture of Plugin developers Picture of Testers
Hi Greg,

Yep, it's just based on supports grading at the moment. You can find that code here: https://github.com/moodle/moodle/blob/aea624fcb0229d40568850c9de808de2155d4beb/enrol/lti/classes/output/renderer.php#L88

There is definitely a lot of room for improvement on this view and there are other issues dealing with that in a more general sense, but I think this one warrants its own tracker issue given how self contained it will likely be. I'd say that we'd want to check both $resource->supportsgrades AND $resource->gradesync there to address the issue you've reported. However, we may also wish to include in the scope, the ability to also check the ags claim in the deep linking launch; a missing claim may also be a good reason to omit the 'add to gradebook' column here. We can check that claim using $launch->getLaunchData().

If you create the issue, I'll happily triage it. If you could link it here, that would be awesome!

Cheers,
Jake
Average of ratings: -