What does lib/typo3 do??

What does lib/typo3 do??

by Howard Miller -
Number of replies: 13
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Very recently, quiz import has started throwing

Notice: Undefined index: utf-8 in /srv/www/htdocs/moodle/head/lib/typo3/class.t3lib_cs.php on line 1008

Notice: Uninitialized string offset: 4 in /srv/www/htdocs/moodle/head/lib/typo3/class.t3lib_cs.php on line 1843

...I have been trying to track it down, but this is not called directly by the quiz code. It would be helpful if somebody could give me a clue as to what this code is for and what might be calling it (and even why it is throwing notices).
Average of ratings: -
In reply to Howard Miller

Re: What does lib/typo3 do??

by Petr Skoda -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Update from cvs and try again, I have fixed a bug recently in lib/textlib.class.php. You can find more info there wink
In reply to Petr Skoda

Re: What does lib/typo3 do??

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
nope... no different. I'll try and find out were these routines might be getting called.
In reply to Howard Miller

Re: What does lib/typo3 do??

by Ger Tielemans -
Is this for unilogin With Typo3? Has someone a manual for this topic?
In reply to Ger Tielemans

Re: What does lib/typo3 do??

by Martín Langhoff -
No SSO with Typo3 -- not from this library. It is unicode-correct string handling. PHP's native string functions are useless when you are using utf-8.

The Typo3 project tackled the unicode transition a while ago, and wrote a lot of handy code for that. Eloy picked it as the best-of-breed code to use in Moodle. And after a lot of haggling, we got all of it for free! wink
In reply to Martín Langhoff

Re: What does lib/typo3 do??

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Ok, so how/where is it used? Do we need to worry about it?
In reply to Howard Miller

Re: What does lib/typo3 do??

by Martin Dougiamas -
Picture of Core developers Picture of Documentation writers Picture of Moodle HQ Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers
It's used whenever we need to convert non-Unicode text into Unicode, as happens in the Moodle 1.6 migration process (and possibly during quiz import).
In reply to Martin Dougiamas

Re: What does lib/typo3 do??

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers

Tracked it down a bit...

It's calling optional_param(...) with $type=PARAM_CLEANFILE.

The code looks like...

  $format = optional_param('format','', PARAM_CLEANFILE );

is this still ok, or has something changed? I did a grep and noted that the quiz import/export seems to be the only place that this clean type is used, so I'm guessing I've been using the wrong one all along sad

In reply to Howard Miller

Re: What does lib/typo3 do??

by Petr Skoda -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
clean_filename() uses typo3's unicode conversion.

There might be something wrong with your PHP - what version is it? do you have iconv or mbstring extensions installed?

There might be better parameter types than PARAM_CLEANFILE for this paticular case, but it is secure and should work here. I might replace it later when I get to it.

I can fix the problem quickly only if I can replicate it on my server or when I have ssh/ftp access to your server.

skodak
In reply to Petr Skoda

Re: What does lib/typo3 do??

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Mmm... I have PHP 4.4.0 on my development server. I have both the iconv and mbstring extensions installed. FWIW, it's a straight SuSE 10.0 install.

I can probably just change the type and/or you can have access to my server if you want to have a closer look. Let me know smile

EDIT:
Ok, have changed and submitted to CVS a change from PARAM_CLEANFILE to PARAM_FILE. It clears the problem, but I'm unsure why it didn't work in the first place. I don't know if you want to investigate further.
In reply to Howard Miller

Re: What does lib/typo3 do??

by Petr Skoda -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
Changing type is not a solution, because the notice will popup whenever you do anything related to uploading of files.

Thanks for the info, I will try it under suse wink
In reply to Petr Skoda

Re: What does lib/typo3 do??

by Howard Miller -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
The code is full of PARAM_FILE but (almost) no PARAM_CLEANFILE. Is the intention to change over to the 'new' version?
In reply to Howard Miller

Re: What does lib/typo3 do??

by Petr Skoda -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
They are different, my intention is to fix all parameters. But I am not sure I will be able to do it in my free time before 1.6 branching sad
In reply to Petr Skoda

Re: What does lib/typo3 do??

by Petr Skoda -
Picture of Core developers Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Peer reviewers Picture of Plugin developers
I have fixed those notices in typo3 library, it looks a bit hackish but it should work just fine.