quick grading and Humboldt Upload & Review assignment type

quick grading and Humboldt Upload & Review assignment type

by Barron Koralesky -
Number of replies: 7

It seems that when I install the Humboldt Upload & Review assignment type (which is a must-have, by the way!) the assignment grading page changes. Two lines that used to say:
Submissions shown per page
Allow quick grading

Now look like this:
pagesize:pagesize"><a href=pagesize" />
quickgrade:quickgrade"><a href=quickgrade" />

Is there a fix in the works for this?

Thank you all!


Average of ratings: -
In reply to Barron Koralesky

Re: quick grading and Humboldt Upload & Review assignment type

by A. T. Wyatt -
When you see double square brackets, it has to do with the language files. Did you copy the language file that came with the block into the appropriate language directory?  We accidentally overwrote something the first time we installed this and had to go find and fix it. . .   I am still looking for the right place to fix the double square brackets that appear in the assignment drop down box.  Mine still says typeuploadreview! smile  But it works!

atw
Average of ratings: -
In reply to A. T. Wyatt

Re: quick grading and Humboldt Upload & Review assignment type

by Barron Koralesky -

Yes, I did copy the language files as well as the module folder.

I suspect that this has something to do with the fact that the quick grading funcion has been added since the Upload & Review assignment type was released.  Perhaps it needs to be tweaked for the new grading functions?


Average of ratings: -
In reply to Barron Koralesky

Re: quick grading and Humboldt Upload & Review assignment type

by A. T. Wyatt -
I believe I have located the strings:
These are in assignment.php, located in the appropriate language folder:

$string['quickgrade'] = 'Allow quick grading';
$string['pagesize'] = 'Submissions shown per page';

I believe you could copy and paste them in, and you would be set. I am sorry I cannot tell you what line number they should be on. I can tell you that ours are immediately after "prevent late submissions".

But I still can't file the string for [typeuploadreview]. I'll keep looking.smile
---------------------------------
edited:
After more searching, the following strings are in /web/html/moodle/lang/en/assignment.php

$string['typeoffline'] = 'Offline activity';
$string['typeonline'] = 'Online text';
$string['typeuploadsingle'] = 'Upload a single file';

I believe that I should also add:

$string['typeuploadreview']='Upload and Review';

and that might do the trick.  But I am guessing.  I am not a programmer!
---------------------------------
Hope that helps--
atw
Average of ratings: -
In reply to Barron Koralesky

Re: quick grading and Humboldt Upload & Review assignment type

by Barry Bandstra -
Barron -- Have you been able to get Assignment Upload & Review (the Humboldt add-on) to work well at Macalaster? I've just installed it in our 1.5.3+ (2005060230) version at Hope. I've implemented the various LANG fixes. And it "kinda" works. I am able to upload a commented copy of a doc. But I get this error message when I save changes:

-- opener.document.getElementById("com2574").innerHTML=""; opener.document.getElementById("g2574").innerHTML="9 / 10";
Fatal error: Call to undefined function: print_student_answer() in /data/samba/courses/mod/assignment/lib.php on line 614

I presume it has to do with the fact the Humboldt add-on dates to the summer of 2005, and something in the latest Moodle version has changed.

Ideas?
Average of ratings: -
In reply to Barry Bandstra

Re: quick grading and Humboldt Upload & Review assignment type

by Barron Koralesky -


Barry-

Your're right, thank you for posting this.  A student can upload their file to the assignment.  A teacher can uploade their feedback.  However, when I add a grade and/or feedback, I get a different error, but an error nonetheless.

This appears to be another aspect of the add-on assignment type that needs to be tweaked for 1.5.3.  Does anyone know if Michael Penny & Company are working on it?


Average of ratings: -
In reply to Barron Koralesky

Re: quick grading and Humboldt Upload & Review assignment type

by Geoffrey Rowland -
Picture of Plugin developers
Hi folks

We have had similar problems with the Upload Review Assignment and Moodle 1.5.3. I posted about this a while back, but suspect it 'got lost' in the middle of a long thread

http://moodle.org/mod/forum/discuss.php?d=33604#162699

Copying the function_print_student_answer() function (code below) from assignment.class.php in the /uploadsingle folder to assignment.class.php in the /uploadreview folder appears to cure the symptoms of the error message - but be warned surprise that I have not (yet) tested extensively, and am not an experienced PHP programmer.

    function print_student_answer($userid, $return=false){
           global $CFG, $USER;
 
        $filearea = $this->file_area_name($userid);

        $output = '';
 
        if ($basedir = $this->file_area($userid)) {
            if ($files = get_directory_list($basedir)) {
 
                foreach ($files as $key => $file) {
                    require_once($CFG->libdir.'/filelib.php');
 
                    $icon = mimeinfo('icon', $file);
 
                    if ($CFG->slasharguments) {
                        $ffurl = "$CFG->wwwroot/file.php/$filearea/$file";
                    } else {
                        $ffurl = "$CFG->wwwroot/file.php?file=/$filearea/$file";
                    }
                    //died right here
                    //require_once($ffurl);               
                    $output = '<img align="middle" src="'.$CFG->pixpath.'/f/'.$icon.'" height="16" width="16" alt="'.$icon.'" />'.
                            '<a href="'.$ffurl.'" >'.$file.'</a><br />';
                }
            }
        }

        $output = '<div class="files">'.$output.'</div>';
        return $output;   
    }

On our 'production' server, we are currently using the workaround of using the 1.5.2 version of the Assignment module (+ Upload Review) in an otherwise Moodle 1.5.3 installation - but of course miss out on the updated assignment interface.

Like you, I would very much appreciate a fix for this invaluable assignment type.
Average of ratings: -
In reply to Geoffrey Rowland

Re: quick grading and Humboldt Upload & Review assignment type

by Deon Metelski -
Hello all!

I am working on cleaning up code on my fresh install of the most up to date Moodle, and though I am not a programmer, I have changed the assignment.class.php to allow for the new quick grading feature. I also included the additional function above that fixes the error when viewing the popup window. I basically commented out the submission code that was in the Humboldt assignment class. I assume their code over rode the default quickgrading code. Anyway it works.

The only bug I have and maybe someone can help out that is more experienced is when I use the quickgrading and choose a grade, it saves fine and shows in the gradebook.

When I click "update" next to the submission and go to the popup window it shows the grade in the popup. Now here's the bug, when I save the comments in the popup window it erases the grade in the quickgrade window to No grade, but the comments are untouched. Then if I "Save all my feedback", it shows no grade in the gradebook and submisison. Help! big grin

Thanks,
Deon
Average of ratings: -