General developer forum

Hi -

In working on something related to enrolments, Antoni Mas suggested a modification to gdlib.php which allows one of the functions to take a URL argument, not just a file-path argument.

I'd like to ask if this change could feasibly be committed to the main code tree. I haven't done any other work with gdlib so there may be issues I'm unaware of. However, I'd like the IMS enrolment module to be available for use in "vanilla" installations in future, without users having to modify any Moodle system files.

The modified gdlib can be downloaded from here:
http://moodle.org/mod/forum/discuss.php?d=34351&parent=166292

Here is the diff against the current HEAD code:

85c85
< function save_profile_image($id, $uploadmanager, $dir='users') {
---
> function save_profile_image($id, $uploadmanager, $dir='users', $url=false) {
112,115d111
<    $destination = $CFG->dataroot .'/'. $dir .'/'. $id;
<    if (!$uploadmanager->save_files($destination)) {
<        return false;
<    }
117c113,122
<    $originalfile = $uploadmanager->get_new_filepath();
---
>    if (!$url) {
>      $destination = $CFG->dataroot .'/'. $dir .'/'. $id;
>      if (!$uploadmanager->save_files($destination)) {
>          return false;
>      }
>
>      $originalfile = $uploadmanager->get_new_filepath();
>    }else{
>      $originalfile = $uploadmanager;
>    }
163c168,170
<    unlink($originalfile);
---
>    if (!$url) {
>      unlink($originalfile);
>    }