Trying to install fordson 1.4.5 :
I chose "Install this update" and get following error:
Am I doing something wrong ?
In reply to Herbert Keijers
Re: Fordson - Problem installing from plugin database
by Richard Oelmann -
I don't think you are doing anything wrong - but I think this is something that needs to be addressed by core as part of that validation process, and probably needs to have a tracker issue, if there isn't one already.
It appears to be looking in theme folders for a /style folder, but in Boost child themes that is not needed as the style comes from the scss files in the /scss folder
@Chris, you could put an empty /style folder in there, just for the sake of this automated validation and as a temporary measure until this gets resolved by HQ. I seem to remember (but can't find the email) someone asking me about this with respect to Waxed before I added the fonts for the presets to a separate ordinary css file in a /style folder because of the existing issue around the scss preprocessor not liking @import url of the google fonts in the bootswatch presets.
@Herbert, you could download the theme and install manually, which would get around that validation issue.
Richard
In reply to Richard Oelmann
Re: Fordson - Problem installing from plugin database
by Chris Kenniburg -
I just downloaded the Moodle 3.3 version of Fordson and it appears there is a blank style folder in the theme package.
Since Moodle 3.3 is BETA at this point depending on when you setup your 3.3 site that might be part of the issue. I don't think this happens on the 3.2 version.
The validator does not insist on that folder being present in theme plugins. This error comes from a place in the code, where the ZIP package is extracted and then it checks that all files declared in the ZIP header really exist. I suspect there will be a problem related to empty directories inside the ZIP.
Can I put a blank file in there? I think this was reported for a version which has files in the directory.
David,
What would you suggest I do? I can upload another copy but I am not sure what the issue would be. Both versions have a style folder. The 3.2 version has files in it and the moodle 3.3 version is blank.
It has been reported that there is an issue with the 3.2 version as well.
https://moodle.org/mod/forum/discuss.php?d=349782#p1421256
Any suggestions?
Chris
I am able to reproduce the validation error.
What I suggest you to do should do is
- Hide (and eventually let me remove) the version https://moodle.org/plugins/pluginversion.php?id=13861
- Prepare a new version package without the empty /style folder
- Release that new one in the plugins directory
I can confirm that if the ZIP package does not have the empty /style folder, it passes the validation (and I tend to think of it as a feature, not a bug).
By the way, where is your Git repository with the latest code 33 v1.4.5 ? I can't see it in https://github.com/dbnschools/moodle-theme_fordson
In reply to Herbert Keijers
Re: Fordson - Problem installing from plugin database
by Chris Kenniburg -
Ricardo just posted in another thread that he was having the same issue. I wonder what is going on here? I don't think I did anything differently when uploading new versions.
In reply to Chris Kenniburg
Re: Fordson - Problem installing from plugin database
by Ricardo Caiado -
After turning on debugging I got more info:
______________
Debugging output enabled
Downloading theme_fordson ...
<- https://moodle.org/plugins/download.php/13861/theme_fordson_moodle33_2017051000.zip
-> /tmp/core_plugin/code_manager/distfiles/652c3de3c82ea075ca13243b2f2c1a7c.zip ... OK
Validating theme_fordson ... Error
[Error] Extracted file not found [{"file":"fordson\/style\/"}]
Installation aborted due to validation failure
______________
"...theme_fordson_moodle33_2017051000.zip..."
Moodle33 ??
______________
Debugging output enabled
Downloading theme_fordson ...
<- https://moodle.org/plugins/download.php/13861/theme_fordson_moodle33_2017051000.zip
-> /tmp/core_plugin/code_manager/distfiles/652c3de3c82ea075ca13243b2f2c1a7c.zip ... OK
Validating theme_fordson ... Error
[Error] Extracted file not found [{"file":"fordson\/style\/"}]
Installation aborted due to validation failure
______________
"...theme_fordson_moodle33_2017051000.zip..."
Moodle33 ??
In reply to Ricardo Caiado
Re: Fordson - Problem installing from plugin database
by Chris Kenniburg -
I am wondering why the plugin directory is telling you to install the Moodle 3.3 version of fordson when you have Moodle 3.2?
I have a suspicion this is caused by the fact that you have both plugin versions same value 2017051000. I suppose that was a mistake and your theme 3.3 version should have higher number.
Please see the info for $plugin->version at https://docs.moodle.org/dev/version.php
The reason is that every plugin in the plugins directory is identified by two things: the component name (frankenstyle) and the plugin version.
So theme_fordson@2017051000 is supposed to uniquely identify a ZIP package. In your case, you have two ZIPs with this version. So when a remote Moodle asks for this plugin, it gets the later one.
There is an open issue in the tracker that the Plugins directory should not allow you to do this mistake but it has not been fixed yet.
OK. So if I change up the version # for the Moodle 3.3 Fordson theme then it should work?
In reply to Chris Kenniburg
Re: Fordson - Problem installing from plugin database
by Herbert Keijers -
Hi Chris,
I see what you have done with the version #.
Sadly to inform you I still get a validation error.
I'm on Moodle 3.3rc2 (20170509)
In reply to Herbert Keijers
Re: Fordson - Problem installing from plugin database
by Chris Kenniburg -
Herbert,
I don't know if it makes a difference or not but I removed the style folder in the latest version for Moodle 3.3 in version
#2017051200
Try out this new release and let me know if it passes the install checks. I did not get an issue.
In reply to Chris Kenniburg
Re: Fordson - Problem installing from plugin database
by Herbert Keijers -
All goes well this time !
THX
In reply to Herbert Keijers
Re: Fordson - Problem installing from plugin database
by Chris Kenniburg -
Well, now I know what to do moving forward. Thanks for your patience while we got it figured out.
Chris