Afterburner logo unresponsive in M2.6

Afterburner logo unresponsive in M2.6

by Gareth J Barnard -
Number of replies: 6
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hi Mary,

In regards to https://moodle.org/mod/forum/discuss.php?d=348234 - I've tested and the logo is un-responsive and of fixed size.

Afterburner version: 2013110500.

Moodle 2.6 version: 2013111811.01 - 2.6.11+ (Build: 20150619).

Should I use M2.7+?

Thanks,

Gareth

Average of ratings: -
In reply to Gareth J Barnard

Re: Afterburner logo unresponsive in M2.6

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

https://github.com/moodle/moodle/blob/MOODLE_26_STABLE/theme/afterburner/style/afterburner_responsive.css#L140-L143

looks like it could be a typo as looks to be a space between a. and logo sad

should be a.logo

I can't tell as my mobile is slow and struggling to get to my website.

vle.bylazydaisy.co.uk/?theme=afterburner

In reply to Mary Evans

Re: Afterburner logo unresponsive in M2.6

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Thanks Mary,

It does appear that the 60% is kicking in and there is no space between 'a' and 'logo'.  However that is what I consider to be partially responsive and not really responsive in the concept of what the 'img-responsive' class implies.  This is where it allows the image to fill the available space and then dynamically adapt according to any given resolution, not just a specific media boundary point.

In reply to Gareth J Barnard

Re: Afterburner logo unresponsive in M2.6

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

In that case how about you apply the same img responsive styles using less...

For example:

.logo-essential {
    .img-responsive;
}

assuming you are adding the image in an <img> tag not a background image?

Of course you can add the img-responsive (or equivalent in Bootstrap4) when ilogo is added. Otherwise you can only use background-size as I did in Afterburner. 

Moodle 3.2 may be different as you have the breakpoints in the layout CSS selectors for the grid.

M

In reply to Mary Evans

Re: Afterburner logo unresponsive in M2.6

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Thanks Mary,

I've looked into this in more detail and Essential used to employ a form of the grid percentage widths (Shoehorn uses a similar technique) to set the containment of the image box.  I seems that it did this without the 'img' tag but in M3.2 I cannot get it to work without (and the 'img-responsive' class).

However as things improved in Essential and to be more progressive with the social icons and the navigation bar underneath the header area - and to be good in all resolutions, the logo had to be come a fixed property entity.  This allows the height of the page header to be static and then makes the control of the navbar when scrolling easier.  It might be possible to be dynamic, will have to see.  But with the percentage width option then this makes large logo's problematic (say using 'span2') unless there is a setting, but too large a span ('span10' for instance) then the social icons get squashed.  Catch-22.

Therefore responsive logo's are a matter of give and take in combination with the other functionality around them.

Afterburner being a simpler theme could employ the 'span2' container width technique though and be more responsive than it already is.

In reply to Gareth J Barnard

Re: Afterburner logo unresponsive in M2.6

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi Gareth,

Every theme is different, and with Moodle it is harder as there are restrictions that seem to be old ideas that filter through, and can cause frustration, so sometimes it's better to do what you feel to be right.

The problem with Logos is that these too can vary in size, from tiny to very large...so you need to cater for all.

Afterburner is a Base only theme so would not be using span2. but I understand what you mean, so I'll take a look at that.

Thanks, 

Mary