Further to this, the following seems to be happening (we have 2 attempts to get a passing grade set):-
Student submits and passes all work - course completion is triggered as complete - this is expected and correct.
Student submits all work, but assignment is reopened (after grading) for second attempt to receive passing grade (not yet a passing grade is assigned) - course completion is triggered as complete - this should not happen as the student has another attempt at an assessment. Course is not yet complete but moodle signals it is.
Student submits all work, but fails two attempts at an assignment (as per our activity settings, 2 attempts allowed) - course completion is triggered as complete - this is expected and correct. The student has no more attempts so the course is complete (albeit failed).
So it seems that this might be a bug? Moodle is not considering the impact of reopened attempts as part of its completion workflow. It should ignore reopened attempts and not mark course as complete until all the attempts are exhausted or all activities set receive a passing grade.
