Hi,
Since moodle 3.1, core notification templates are coupled with bootstrapbase theme...
Wouldn't it be better to write theme-agnostic templates in core code and move these templates in bootstrapbase theme itself?
Regards
Jean-Roch Meurisse
Yes.
Given: https://github.com/bmbrands/theme_bootstrap/issues/420 - thus is technically a 'bug' with core code design but will probably be called an 'enhancement' or ignored as 'contrib' is not allowed to affect core. Please raise a Moodle Tracker issue.
I added some comments to that link Gareth that point to the original tracker.
Here is a discussion thread started by Andrew Nicols about the proposed changes at the time.
https://moodle.org/mod/forum/discuss.php?d=328161
Cheers
Mary
Thanks Mary.
From that and the comments on the Bootstrap theme issue, it looks like with https://docs.moodle.org/dev/Templates#How_to_I_override_a_template_in_my_theme.3F that the notification files: https://github.com/moodle/moodle/tree/MOODLE_31_STABLE/lib/templates need to be in any custom theme that does not use core Bootstrapbase (Bootstrap V2.3.2). I wonder if the files should really be here: https://github.com/moodle/moodle/tree/MOODLE_31_STABLE/theme/bootstrapbase in a templates folder, like the 'base' theme does: https://github.com/moodle/moodle/tree/MOODLE_31_STABLE/theme/base/templates/core and thus core templates need to be theme independent.