BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Gareth J Barnard,
Nombre de réponses : 7
Avatar Core developers Avatar Particularly helpful Moodlers Avatar Plugin developers

M 2.9.3+ (Build: 20151209) - 2015051103.06

BCU 1.3.1 2015070100

With developer debugging on and the user having received messages:

Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$contexturl in F:\moodledev\moodle29\theme\bcu\renderers.php on line 217
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 117
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 132
Notice: Undefined property: stdClass::$from in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141
Notice: Trying to get property of non-object in F:\moodledev\moodle29\theme\bcu\renderers.php on line 141

and font fetching has been coded incorrectly:


Annexe 2015-12-10 17_37_21-Moodle 29 - with a really long name for the purpose of testing really long names.png
Moyenne des évaluations: -
En réponse à Gareth J Barnard

Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Gareth J Barnard,
Avatar Core developers Avatar Particularly helpful Moodlers Avatar Plugin developers

P.S. the core course renderer has the navbar() method which is not called or exists in the parent class.

Moyenne des évaluations: -
En réponse à Gareth J Barnard

Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Gareth J Barnard,
Avatar Core developers Avatar Particularly helpful Moodlers Avatar Plugin developers

Ditto for the 'render_navigation_node()' method.

Moyenne des évaluations: -
En réponse à Gareth J Barnard

Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Gareth J Barnard,
Avatar Core developers Avatar Particularly helpful Moodlers Avatar Plugin developers

Where is '$rcourses' and '$rhosts' here?:

    public function frontpage_my_courses() {
        global $USER, $CFG, $DB;
        $output = '';
        if (!isloggedin() or isguestuser()) {
            return '';
        }
        $courses = block_course_overview_get_sorted_courses();
        list($sortedcourses, $sitecourses, $totalcourses) = block_course_overview_get_sorted_courses();
        if (!empty($sortedcourses) || !empty($rcourses) || !empty($rhosts)) {

and as the parent has:

        if (!empty($CFG->navsortmycoursessort)) {
            // sort courses the same as in navigation menu
            $sortorder = 'visible DESC,'. $CFG->navsortmycoursessort.' ASC';
        } else {
            $sortorder = 'visible DESC,sortorder ASC';
        }
        $courses  = enrol_get_my_courses('summary, summaryformat', $sortorder);
        $rhosts   = array();
        $rcourses = array();
        if (!empty($CFG->mnet_dispatcher_mode) && $CFG->mnet_dispatcher_mode==='strict') {
            $rcourses = get_my_remotecourses($USER->id);
            $rhosts   = get_my_remotehosts();
        }
        if (!empty($courses) || !empty($rcourses) || !empty($rhosts)) {

is this not a major omission for remote courses?


Moyenne des évaluations: -
En réponse à Gareth J Barnard

Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Gareth J Barnard,
Avatar Core developers Avatar Particularly helpful Moodlers Avatar Plugin developers

When initialising PHPUnit I get this:

PHP Notice:  Undefined index: s_theme_bcu_market1_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
Notice: Undefined index: s_theme_bcu_market1_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
PHP Notice:  Undefined index: s_theme_bcu_market2_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
Notice: Undefined index: s_theme_bcu_market2_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
PHP Notice:  Undefined index: s_theme_bcu_market3_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
Notice: Undefined index: s_theme_bcu_market3_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
PHP Notice:  Undefined index: s_theme_bcu_market4_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
Notice: Undefined index: s_theme_bcu_market4_draftitemid in F:\moodledev\moodle29\theme\bcu\libs\admin_confightmleditor.php on line 160
Moyenne des évaluations: -
En réponse à Gareth J Barnard

Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Fernando Acedo,
Avatar Plugin developers Avatar Testers

Gareth,

I made more 50 installations of BCU, most of them in development where I use debugging to highest level, and never seen this errors before.

I even was testing in version 3.0 and all was working well. The theme is compatible with v3.0 even it is not changed in the plugins directory.

I will make a test later to verify this problem.

 

 

 

Moyenne des évaluations: -
En réponse à Fernando Acedo

Odp: Re: BCU V1.3.1 - 2015070100 - M2.9.3 - theme issues

par Rafał Szałaśny,

Hi I've got moodle 3.0 and the same errors, anyone helps with this ?

Moyenne des évaluations: -