Clean theme navbar links on invert and collapse

Clean theme navbar links on invert and collapse

by Richard Jones -
Number of replies: 8
Picture of Plugin developers Picture of Testers

Hi Mary, Richard, Gareth

I saw some changes had been made in this area under MDL-39977. 

I have noticed that, when the Clean navbar is inverted and the screen width reduced to the point where the menu collapses, the hover state on the custom links remains very dark.  Also the dividers look a bit silly IMO.

I hesitate to report this as a bug as it seems quite minor.  As far as I can the rule is here:

.nav-collapse .nav > li > a:hover, .nav-collapse .nav > li > a:focus, .nav-collapse .dropdown-menu a:hover, .nav-collapse .dropdown-menu a:focus, .nav-collapse .dropdown-submenu a:focus, .nav-collapse .dropdown-submenu a:hover, .nav-collapse .dropdown-submenu a:active, .nav-collapse .dropdown-menu > li > a:hover, .nav-collapse .dropdown-menu > li > a:focus {
    color: #FF0;  /* Or whatever seems OK - maybe white wink */
    background-image: none;
}
/* I've added this to remove the divider in the collapsed state */

.nav-collapse .nav .divider {
        display:none;
}

This does also seem to affect the non-collapsed menu but I'm not sure why that is.

Cheers

Richard

Average of ratings: -
In reply to Richard Jones

Re: Clean theme navbar links on invert and collapse

by Richard Jones -
Picture of Plugin developers Picture of Testers

Ah

I want .navbar-inverse .nav-collapse of course, but still applies to the non-collapsed inverted menu.

Richard

Average of ratings: -
In reply to Richard Jones

Re: Clean theme navbar links on invert and collapse

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Probably needs a media query.  What version of Moodle are you running Richard?

Average of ratings: -
In reply to Gareth J Barnard

Re: Clean theme navbar links on invert and collapse

by Richard Jones -
Picture of Plugin developers Picture of Testers

Hi Gareth

I'm running 2.9.1.  Like I said, not a big deal, more intellectual curiosity.  Plenty of colours that look good both on black and white backgrounds.  Just thought it was an odd choice as you really can't read the link on hover in the original Clean theme.

Thanks for getting back to me.

Richard



Average of ratings: -
In reply to Richard Jones

Re: Clean theme navbar links on invert and collapse

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Richard,

I'm just working on this now in MDL-51234 and see on Moodle 3.0 development the dividers are horizontal in Clean and More theme. Are you using another theme?

Average of ratings: -
In reply to Mary Evans

Re: Clean theme navbar links on invert and collapse

by Richard Jones -
Picture of Plugin developers Picture of Testers

Hi Mary

I had been modifying the theme and, in fact removed the dividers on both collapsed and non-collapsed views in the modified theme.

Looking again now, I added css in the custom settings to Clean at some point which caused that to happen and forgot to take it out again.  Sorry for the confusion. blush

Just the colours then.

Cheers

Richard

Average of ratings: -
In reply to Richard Jones

Re: Clean theme navbar links on invert and collapse

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

  .navbar-inverse .nav-collapse.in .nav > li > a:hover,
  .navbar-inverse .nav-collapse.in .nav > li > a:focus {
    color: #ffffff;
  }
  .navbar-inverse .nav-collapse.in .dropdown-menu a:hover,
  .navbar-inverse .nav-collapse.in .dropdown-menu a:focus {
    color: #ffffff;
  }
  .navbar-inverse .nav-collapse.in .dropdown-menu > li > a:hover,
  .navbar-inverse .nav-collapse.in .dropdown-menu > li > a:focus {
    color: #ffffff;
  }
  .navbar-inverse .nav-collapse.in .dropdown-submenu a:hover,
  .navbar-inverse .nav-collapse.in .dropdown-submenu a:focus,
  .navbar-inverse .nav-collapse.in .dropdown-submenu a:active {
    color: #ffffff;
  }

This was a devil of a job to do!

Will be fixing later today.

@Gareth

Hope you can Peer Review MDL-51234 then it might get integrated this weekend?

Cheers

Mary

Average of ratings: Useful (1)
In reply to Richard Jones

Re: Clean theme navbar links on invert and collapse

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Hi Richard,

The inverse link colour is a pain...can you report it as a bug in Moodle Tracker?  I'll try and get it changed to a shade you can see by default!

Thanks

Mary

Average of ratings: -