Kristi,
I believe you are talking about "download all instructor files".
Yes, it looks bit odd, but definitely works. I just wanted to minimize the code change and tried to reuse the existing functions for "download assignment submission" in the assignment module. In order to make "/mod/assign/view.php" work properly, I had to specify a random assignment ID (actually it is the minimum assignment ID in your Moodle system. I believe any Moodle system should have at least assignment). The assignment ID is static, but the course ID is definitely dynamic, which is the course you are currently in.
We use this feature from our 2.5, 2.8, and now on 3.0. This customization also has been used by other institutions successfully.
I am not sure which Moodle version you are using now, for different version, probably there will be slight difference. Let me know if I can help.
But, anyhow, here is the link for Moodle 3.0: