Essential LTR / RTL testing

Essential LTR / RTL testing

by Gareth J Barnard -
Number of replies: 9
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Hello Themers,

I have been working on a new solution to implement left to right / right to left language swapping capability in themes (see: https://moodle.org/mod/forum/discuss.php?d=264955) and after discussions with David, this is planned for the next release (2.7.8).  However, it is radical.  Therefore if you have a test server and can do so, then please can you test.

You can get the code from: https://github.com/DBezemer/moodle-theme_essential/archive/master_249.zip - please do not fork this branch though, as I push fixes to it and rebase it against the current development.  Its separate as it falls in line with the concept of a 'feature branch' to make it easier to maintain the development of it at the same time as the main push.

I would be grateful if you could either post screen shots here or on the issue: https://github.com/DBezemer/moodle-theme_essential/issues/249 - you do not have to even be using an RTL language as some aspects of LTR may have been altered due to the ordering of CSS file imports.

I cannot stress enough that this MUST not be placed on a DEVELOPMENT server.

Essential development relies on the support of the user.  You have the power to help us improve and make the theme better for all.  Please help.

Thank you,

Gareth

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential LTR / RTL testing

by Mary Evans -

Just to let you know I have found an error in the config.php to do with Secure layout. You have footer blocks in the regions array, and yet secure.php has no footer. It does not have one by default.

I'm going to test it with that left as it is and see if it throws a wobbler!

The config.php looks mighty complex to me, I hope you know what you are doing as I sure don't! lol

Mary

Average of ratings: -
In reply to Mary Evans

Re: Essential LTR / RTL testing

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Thanks Mary.  I think that might be on current master branch as not touched that part of the file.  And yes, we do know what we are doing :D

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential LTR / RTL testing

by Mary Evans -

Is there a reason why I am always getting a white screen each time I go to a different page? Landing on frontpage and going to a course page leaves me in a kind of white cloud limbo, with the spinner going like the clappers in the tab of my browser.

Average of ratings: -
In reply to Mary Evans

Re: Essential LTR / RTL testing

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Odd.  Anything on the browser console?  I've not tested with TDM off.  Also may need a purge all caches.

BTW, raised: https://github.com/DBezemer/moodle-theme_essential/issues/270 thanks.

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential LTR / RTL testing

by Mary Evans -

It seems to work OK, but I will keep on testing in different pages...its just taking forages to load a page. It did not use to originally, so may be the DB is overloaded and causing my server some strife!

I've found another RTL BUG which I am currently testing in Clean theme as it is a Moodle thing. Its the rotation of the title RTL needs it to be only 90degs whereas LTR needs it to be 270degs. As LTR are head to the left shoulder reading BTT bottom-to-top and RTL are head to right shoulder reading BTT. which gives the appearance that we are all reading in the same direction! LOL

Anyway the CSS seems to be working OK.

Cheers

Mary

Average of ratings: Useful (1)
In reply to Mary Evans

Re: Essential LTR / RTL testing

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Oh, that's odd with the title rotation as master seems to already have code to cope with that in the dock: https://github.com/moodle/moodle/blob/master/lib/yui/src/dock/js/dock.js#L137-L219 - unless you are talking about something else?

Thanks for testing Mary.  Odd about the page load time.  There is only an additional request and that's cached by the browser the second time around, even with TDM off.

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential LTR / RTL testing

by Mary Evans -

Yes it is odd as it appears they have got it wrong. Reading Hebrew is not easy but it 's plain to see that the letters have been rotated 90degrees and then flipped over so they are back to font and upside-down.

Originally they where docked on the left. So in that respect it would have been the correct position. But now that we are styling the dock on the right in RTL I suspect it is hard to read. 

Average of ratings: -
In reply to Gareth J Barnard

Re: Essential LTR / RTL testing

by m question -

شكرا

thank you for your great work, it support RTL perfectly

there is still the category icon issue , but I think  I need to change manually to work as u told me once in Readme  but I could not find now

other than that , it is really great

thanks

Average of ratings: -