I think it is a bug related to adding advanced search in 1.5.
When using moodle.org, I notice that that some search results display with context as before while others display only author and forum. Possibly difference between normal and advanced search, although I seem to recall getting one or the other output from advanced searches (but may be my memory fails me).
Also, the advanced search link in top right is not always shown when search box is shown there.
When using moodle.org, I notice that that some search results display with context as before while others display only author and forum. Possibly difference between normal and advanced search, although I seem to recall getting one or the other output from advanced searches (but may be my memory fails me).
Also, the advanced search link in top right is not always shown when search box is shown there.
In reply to Robert Brenstein
Re: Contextual information when searching forums?
by Martin Dougiamas -
When do you only see author and forum? It's definitely a bug if you're seeing that (I've never seen it). Normally full posts are shown, with highlighting and further links.
Can you give me a replicable search I can see so I can look into it?
Can you give me a replicable search I can see so I can look into it?
Martin-I've been seeing this too-It shows up when you do a search for "these words should appear as whole words." Try a search on: Martin 2005 and you'll get a replicable search:
http://moodle.org/mod/forum/search.php?id=5&words=&phrase=¬words=&fullwords=martin+2005&hfromday=1&hfrommonth=1&hfromyear=1&hfromhour=1&hfromminute=1&htoday=1&htomonth=1&htoyear=1&htohour=1&htominute=1&forumid=0&subject=&user=
http://moodle.org/mod/forum/search.php?id=5&words=&phrase=¬words=&fullwords=martin+2005&hfromday=1&hfrommonth=1&hfromyear=1&hfromhour=1&hfromminute=1&htoday=1&htomonth=1&htoyear=1&htohour=1&htominute=1&forumid=0&subject=&user=
Ack!
I'm pretty sure that was working before, so it may just be something minor.
Martin, if it's not something trivial, let me know. I'm sort of swamped at the moment (there's a new cohort of grad students to orient and teach, and we're on deadline for our LD paper) but I can try to make time if necessary.
I'm pretty sure that was working before, so it may just be something minor.
Martin, if it's not something trivial, let me know. I'm sort of swamped at the moment (there's a new cohort of grad students to orient and teach, and we're on deadline for our LD paper) but I can try to make time if necessary.
By the way Hansen, your post shows that we need a kind of an auto-wrapper so that a long URL like yours does not break the theme layout. (The theme should have been 100% wide),right Martin?
As long as the solution doesn't break the URL instead.
There is a solution. You can just do this
Your image didn't load but I suspect we are on cross lines.
My solution was an alternative to posting very long URLs which break the theme - it was not a solution to the search problem which I have just noticed and still seems to exist.
Has this been raised in the bug tracker?
Darren
PS - The image is present as indicated by the image properties (here) but I guess the forums don't support inline tiffs. It's interesting (and potentially a problem) that it does not show up as an attachment on the site (prob does if you got it through email)
The lack of support for inline tiffs has nothing to do with the forums-inline tiffs are simply not supported in any browser, and never have been. That's why people use other formats on the web.
... so the forum should display the tiff as an attachment instead of trying to display it inline.
Sorry...wasn't paying attention when I uploaded that (Mac OS X defaults screenshots to .tiff format, so there's an extra step involved to convert to more browser-friendly formats). I hope JPG is PC enough for everyone...
The lack of support for inline tiffs has nothing to do with the forums-inline tiffs are simply not supported in any browser, and never have been.
Actually, that's not quite correct: Safari has no problems rendering inline TIFF images.
But I digress...
Actually, that's not quite correct: Safari has no problems rendering inline TIFF images.
But I digress...
The bug should be fixed now.
It was only occurring when using "must have" search terms like this: +word. The highlighting function doesn't like these terms and blanked the string. Fixed in 1.5 CVS and HEAD by removing these terms before passing to the highlighting function.
I'd close the bug report in the bug tracker but no-one made one.
Please keep testing and reporting bugs.
It was only occurring when using "must have" search terms like this: +word. The highlighting function doesn't like these terms and blanked the string. Fixed in 1.5 CVS and HEAD by removing these terms before passing to the highlighting function.
I'd close the bug report in the bug tracker but no-one made one.
Please keep testing and reporting bugs.
bug 3361...
Bit late now, but thanks.