Essential 2.6.2 released

Essential 2.6.2 released

by Julian Ridden -
Number of replies: 39

Hi All,

Sorry I have been so quiet lately. Been extremely busy in the "real world" front.

Today I have released a new version of Essential which pretty much is a maintenance release. No new features, just a whole bunch of bug squashing. this also now brings the version of Essential in the plugins DB up to speed with what is in Github. Full breakdown is below.

  • FIX: Numerous CSS fixes
  • FIX: Third level dropdown in custom menu now works
  • FIX: iOS 7 custom menu now works when changed to a sing dropdown in portrait view
  • FIX: Social networking icons now line up properly
  • FIX: GoogleFonts will now load in HTTPS setups
  • NEW: Frontpage content now goes full width if all blocks removed.

As usual keep all bugs reported in THIS THREAD only related to this release.

Grab it from the Plugins DB here or direct from the GitHub Repository here

Regards

Julian

Average of ratings:Useful (2)
In reply to Julian Ridden

Re: Essential 2.6.2 released

by Brian Schmidt -

I still seem to be having an issue with alignment of the social icons in Chrome (31.0.1650.57):

chrome

Moodle version: Moodle 2.6 (Build: 20131118)
Essential version: 2013120200

I purged all caches after upgraded Essential.

 

Average of ratings:Useful (1)
In reply to Brian Schmidt

Re: Essential 2.6.2 released

by David Pesce -
Picture of Plugin developers

Same here. 

Getting this error: "event.returnValue is deprecated. Please use the standard event.preventDefault() instead."

within 

jquery-1.10.2.min.js:5

 

In reply to Brian Schmidt

Re: Essential 2.6.2 released

by David Pesce -
Picture of Plugin developers

It seems only related to the "Website" button.

Looking at it in dev tools shows that it's inheriting a style 'vertical-align: middle'. Unchecking it seems to fix the problem. 

Looking further at the CSS file, it looks like '.useralerts [class^="fa-stack"]' may be the culprit. I haven't debugged this any further, but will look more tomorrow.

In reply to David Pesce

Re: Essential 2.6.2 released

by Mary Evans -

I think it's the CSS for the stacked icons so try this instead...in other words remove the - (minus sign) and make it margin-top:4px

In reply to Mary Evans

Re: Essential 2.6.2 released

by David Pesce -
Picture of Plugin developers

Hmm, doesn't change anything in Chrome.

In IE, it looks like it drops it about 1-2px below the other social network icons.

In reply to Mary Evans

Re: Essential 2.6.2 released

by David Pesce -
Picture of Plugin developers

This is the exact value I'm removing to get it to fix (in either browser).

Attachment essentialsCSS.png
In reply to David Pesce

Re: Essential 2.6.2 released

by Mary Evans -

I would have been tempted to add css to override those font css rules in a new css stylesheet and call it undo-fa.css thus keeping the font-awesome.css in its original state.

In reply to Julian Ridden

Re: Essential 2.6.2 released

by Ben Howard -

Really loving the new release but I had to downgrade my Moodle install to 2.5 and thus my Essential theme sad

I don't suppose you would be willing to update the custom menu dropdowns like you did for 2.6.2 for Moodle 2.5?

The error I get is: Dependencies check failed for theme_essential - REQUIRES theme_bootstrapbase (2013050100)

Thanks

Ben

In reply to Ben Howard

Re: Essential 2.6.2 released

by Julian Ridden -

Sadly not Ben. Essential is just written by me in my spare time and I don't have enough of it to support two releases.

At least you know it is there with new features when you get to 2.6

Julian

In reply to Julian Ridden

Re: Essential 2.6.2 released

by Ben Howard -

Ok, thanks for the reply.. its understandable smile

Still an awesome theme.

Thanks

Ben

In reply to Ben Howard

Re: Essential 2.6.2 released

by Mary Evans -

Hi,

If you were to change the version.php in this theme you would be able to get it to work in 2.5.

$plugin->dependencies = array(
    'theme_bootstrapbase'  => 2013050100,
);

In reply to Mary Evans

Re: Essential 2.6.2 released

by Julian Ridden -

But it wont Mary. Things like the useragent function changed and it will throw quite a few errors.

Julian

In reply to Julian Ridden

Re: Essential 2.6.2 released

by Diego Eckhardt -

Best template ever!

I am having a couple of small issues, the first is that when in a course view with tracking turned on, the "your progress"  info link shows through the dashboard menu.  

 

 

 

 

 

 

 

 

 

The second is that in a page view or an activity view the blocks on the right move down and display at the bottom of the activity.  The example is a forum..this also happens on the site pages I have on the front page. In a course, this only happens at the activity level. In the main course view both columns of blocks display on the right correctly. I have tried this in three different course formats and using all of the different width settings.  I have it in both firefox and chrome.  also just upgraded to Moodle 2.6

 

 

 

 

 

 

 

Any help would be greatly apreciated, again thanks for the great template!

Diego

In reply to Diego Eckhardt

Re: Essential 2.6.2 released

by Mary Evans -

Hi Diago,

Thanks for adding this question here.

Can you verify that the version is the latest?

The problems in:

1. Seems to be a z-index problem caused by this CSS rule in theme/bootstrapbase/less/moodle/course.less

.path-course-view .completionprogress {
    display: block;
    float: right;
    height: 20px;
    position: relative;
    z-index: 1000;
}
To fix this in Essential theme just add the following rule in the Custom CSS in Site Admininistration > Appearance > Themes > Essential > General (settings)

2. Seems to be a layout problem...however I cannot replicate it.

Cheers

Mary

In reply to Mary Evans

Re: Essential 2.6.2 released

by Diego Eckhardt -

moodle version is  2.6+ (Build: 20131129)

template is essential 2.62

your fix worked perfectly for the first issue

Seems like the 2nd issue has to do with how the nav and admin blocks do a default move from the left column to the right when there are no other blocks in the right column.  This site is an upgrade from a clean 2.5 install, it worked perfectly in the previous version. If I move each block manually in edit mode they stay where they should. But who wants to adjust the position every block in every activity sad

Another detail, when the page is loading they appear for a second where they should then move down as the page finishes loading.

Thanks for the fix on the z index

 

 

   

In reply to Diego Eckhardt

Re: Essential 2.6.2 released

by Mary Evans -

OK...in that case it is dependent on where you position the blocks using only center | right. In this case there is a potential BUG in Essential which will make it falter when using the Admin layout when all the blocks are set as Right and they need to be Left!  Interesting.

OK will test this and see what I find.

We should be able to fix this in CSS.

Mary

In reply to Mary Evans

Re: Essential 2.6.2 released

by Judy Steidl -

Thanks!  Meanwhile...I'll upgrade to 2.6 and work on it from my end.  Much appreciation!

In reply to Julian Ridden

Re: Essential 2.6.2 released

by zizo zizo -
I installed moodle2.6 with essential theme and all feature were working fine but now at frontpage i can not add new block and the action button at top right of any block not work. Can you help me

 

Attachment moodlesmall.jpg
In reply to zizo zizo

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

JavaScript is probably broken.  Turn on developer tools in the browser, look at the console tab and refresh the page.  Report errors here.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by mart van der niet -

Same here.

Debugging info from browser:

TypeError: o.node is null,

yui_co...-min.js (line 1)
 
In reply to mart van der niet

Re: Essential 2.6.2 released

by mart van der niet -

Another observation on this problem:

When using the code from the installation where the problem happens with a moodle_db from a site where the problem does not occur (both sites same version moodle) everything works ok.

Anyone a clue to were to look in the DB for a problem??

In reply to mart van der niet

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

It won't be the DB then, it will be content added to the page.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by mart van der niet -

What do you mean by "Content added to the page" ?

 

(problem reproduces with theme=clean and courses with differetn formats)

In reply to mart van der niet

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

I mean that a html block etc. has content that breaks things.  If the same code base works with one DB and not another then it must be the rendered content.  Looking in the DB will not help as a hay stack.  Look at what is on the page and the difference between the working and non-working content.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by mart van der niet -

Problem solved:

I manually removed all offending blocks (in the admin region of the frontpage) from mdl_block_instances.

Now another problem, will make a separate post.

Thanks for all advice.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by mart van der niet -

Same here.

Debugging info from browser:

TypeError: o.node is null,

yui_co...-min.js (line 1)
 
In reply to mart van der niet

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Thanks for the screenshots. If the error does not happen when you switch to the Clean theme then its an issue with Essential.  Would you be so kind as to state the steps you did to reproduce the issue and any further customisations beyond 2.6.2 of Essential along with the specific version of Moodle you are running.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Just tested Essential 2013120200 on Moodle 2013111800.04 2.6+ (Build: 20131205) on the Frontpage and cannot reproduce.  Code retrieved from https://github.com/moodleman/moodle-theme_essential/tree/ESSENTIAL_262.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by zizo zizo -

I'm using this ver of theme2.6.2 and moodle 2.6 and this error still . Please see attached files

Attachment moodlesmall.jpg
In reply to zizo zizo

Re: Essential 2.6.2 released

by zizo zizo -

error

Attachment moodle1.jpg
In reply to zizo zizo

Re: Essential 2.6.2 released

by zizo zizo -

This error not appear when using clean theme

In reply to zizo zizo

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, one person is saying one thing and the other another.  What is it to be?  Or is there two separate issues.

In reply to Gareth J Barnard

Re: Essential 2.6.2 released

by zizo zizo -

Two separate issues not same

In reply to zizo zizo

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

In that case I cannot help you solve the issue without more information.  Please first read my previous post and turn on developer level debugging.  Also report all contributed plugins and any html content blocks.  The good / not working binary chop is starting from the fact that mine works with Essential 2.6.2 etc. as stated and yours does not.  Therefore the difference between the two contains the fault.  Therefore list all the differences between a locally hosted M2.6 with Essential 2.6.2 only and your installed site.  Please start to execute the investigation method I've previously specified.

Like:

  • Does the issue happen in an LTR language?
  • Does the issue happen when I remove all contributed plugins?
  • Have I removed all of the changes I've made from the downloaded code?
  • Does the issue happen when I remove any additional HTML blocks?

......

In reply to zizo zizo

Re: Essential 2.6.2 released

by Gareth J Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers

Ok, thanks for the repeated screen shots.  They indicate that JS is indeed failing, this is why the other functionality is not working.  However, now need to investigate further by turning on developer level debugging.  Which I think will cause the error to manifest itself in the console window as a line number in the uncompressed (all code shown in the minimised version - only line 1).  This will indicate the specific code where the error happens.

The 'null' bit means that in this context that a tag or class or identifier in the mark-up cannot be found.  This usually is because it is not there or the structure is wrong or the structure has been mangled.

Therefore given the logic that the issue only manifests on a given data set with the same code base and also with the Clean theme on that data set that the problem is not with the Essential theme or the Clean theme or a contributed plugin.  So, it must be with the content on the page or how the code is initiated in some way.

So, now need to find what is the specific content is.  So go and look at the content on the page between the working and not working and gradually remove the additional content until the problem goes away.  Then you will know what specific content is causing the issue.  Then with that knowledge you can a) replicate the issue and b) in a position to understand the issue and make testable code changes to cope with the issue or preventative measures even if they are human ones.

In reply to Julian Ridden

Re: Essential 2.6.2 released

by wellness systems -

Hello, I have upgraded my site to the 2.6.2 release - AWESOME.

The only problem I seem to be having is with the "Frontpage content now goes full width if all blocks removed."

I have removed the blocks and even removed them from the docking area just in case that was causing the glitch.  I have even tried uninstalling and reinstalling the theme, but my frontpage content is still squished into the left two columns, not going full width.

Any insight or direction?????

Attachment essential-theme-frontpage-not-full-width.jpg