Please fail QA tests when you find setType() warnings

Please fail QA tests when you find setType() warnings

by Dan Poltawski -
Number of replies: 2

Hi Testers,

You may have noticed that there during testing of Moodle 2.5 release there are little warnings popping out of the woodwork whilst testing like:

Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.

This is a new developer warning, to help us improve the security/robustness of our forms in Moodle, introduced by MDL-34311.

We've noticed that a few of your have been encountering these messages and passing your tests because it does not affect the functionality of Moodle. I'd like to ask if you do encounter these warnings (or any other warning whilst running QA tests), please fail the test.

We are aiming to eliminate any of these developer warnings before release, and having the failed QA tests is a good way to ensure we do not miss any of them.

Thanks a lot for all your hard work testing Moodle 2.5!

Dan

Average of ratings: Useful (3)
In reply to Dan Poltawski

Re: Please fail QA tests when you find setType() warnings

by Séverin Terrier -
Picture of Documentation writers Picture of Particularly helpful Moodlers Picture of Testers Picture of Translators

Hi Dan,

In short, if i understand well, the message is "don't hesitate to fail a test", rather then beeing tempted to mark as passed, if any little thing isn't all perfectly as expected?

Séverin

Average of ratings: -
In reply to Séverin Terrier

Re: Please fail QA tests when you find setType() warnings

by Dan Poltawski -

Yes please. We might decide to pass the test anyway, but at least we are not missing errors which we might want to fix.

Thanks

Average of ratings: -