Moodle in English: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月15日星期五 02:01

Hi all,

M2.3.1+ version from:

https://moodle.org/plugins/pluginversion.php?id=2384 - Edited from original post to update from version with bug.

M2.4.1+ version from:

https://moodle.org/plugins/pluginversion.php?id=2385 - Edited from original post to update from version with bug.

M2.3.1+ improvements:

1. Improved mobile and tablet theme detection and support.
2. Fixed 'float' issue for jQueryMobile themes as reported in CONTRIB-4108.
3. Implemented round toggle borders to reduce the harshness and integrate with jQueryMobile themes.
4. Changed the readme to ['Markdown' format](http://en.wikipedia.org/wiki/Markdown).
5. Added 'Download and documentation' to the readme to clarify download locations.
6. Cleaned JavaScript through use of http://jshint.com/.
7. Added 'Previous versions and required version of Moodle' to the readme.
8. Changed 'Open / Close all sections' to 'Open all / Close all' as per 2.4 version.
9. Tidied up lang files as Moodle.org now does automatic translation.
10. Added mobile toggle data hidden div tag for future use.
11. Implemented MDL-37901.
12. Improved MDL-34917 code.
13. Implemented CONTRIB-4198.

M2.4.1+ improvements:

1. Improved mobile and tablet theme detection and support.
2. Added 'Download and documentation' to the readme to clarify download locations.
3. Cleaned JavaScript through use of http://jshint.com/.
4. Added 'Previous versions and required version of Moodle' to the readme.
5. Implemented MDL-37901.
6. Implemented MDL-37976.
7. Moved 'float: left' to styles.css for Henrik Thorn - CONTRIB-4198.
8. Improvements for MDL-34917.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月16日星期六 10:09

We just upgraded from 1.9 to 2.2 and now to 2.4. I have upgraded to the newest collapsed topics format and it looks like everything is working well. However, I just realized that things aren't sticking. I happen to have two sections in my physics course open and no matter how I change it such as closing them both or opening some other sections if I go away from the page and then come back the original two sections are again opened. I hope I'm not missing something easy that I should have figured out by myself?

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月16日星期六 18:44

Dear Marc,

It sounds like the AJAX toggle saving functionality is not working on your system for some reason and the old data is being reloaded. Have you:

Clicked on Site Administration -> Notifications?
Performed a 'Purge All Caches' - please see Readme.md.
Is one of the sections a current section?
Did it happen before the upgrade?
Does it happen in other Collapsed Topics courses?
Does it happen if you change the course format to 'topics', save then back to 'Collapsed Topics'?

Also, please can you tell me the specific version / build of Moodle, Theme and Collapsed Topics from the entire contents of their version.php file if the above does not work.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月16日星期六 22:03

Dear Marc,

Correction, there appears to be a bug in module.js. I'm going to hide the versions published and make a fix.

In the mean time, please edit module.js and change around line 250 from:

if (togglePersistence === 1) // Toggle persistence - 1 = on, 0 = off.

if (togglePersistence == 1) // Toggle persistence - 1 = on, 0 = off.

Then do a 'Purge All Caches'.

Thanks,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月16日星期六 22:34

That was it! I feel like I should have found that code change on my own but it was easier to just ask So, I think I have a better idea of how it is working now. If I highlight a section that would force it to be open for all my students? If I want them to be able to collapse all sections I just won't highlight the current section? Currently I have debugging turned on in Developer Mode. Although, the format seems to be working I do still have the following error thrown on the page:

Notice: Trying to get property of non-object in /Volumes/Moodle_Data/Webserver/Documents/moodle/course/format/topcoll/lib.php on line 73 Notice: Trying to get property of non-object in /Volumes/Moodle_Data/Webserver/Documents/moodle/course/format/topcoll/lib.php on line 75 Notice: Trying to get property of non-object in /Volumes/Moodle_Data/Webserver/Documents/moodle/course/format/topcoll/lib.php on line 91

I changed back to Topics and then back to Collapsed Topics and the error was gone. Then I moved a topic around and the error comes back up. Nothing seems to be wrong though.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月16日星期六 23:26

Dear Marc,

Thanks for the information, always helpful in deducing the issue

It's all to do with get_config returning strings when I'm expecting an integer when I set-up the admin setting in settings.php. I'm going to publish a better fix soon.

With the 'non-object' issue it looks like 'get_section_name()' in '/course/format/lib.php' now either accepts an object or an integer but when I originally overloaded the method it was only an object, so will put a fix in for that too. I think I made a mistake on that one.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月16日星期六 23:40

After some more testing the non-object issue is not specific to the collapsed topics format. I changed to the topics format and then tried to move a section around and the same error will show up. I think it has something to do with AJAX?

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月16日星期六 23:51

Dear Marc,

Possibly, what is the error when you did the same in Topics please. File names and line numbers can be so helpful

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月16日星期六 23:54

Actually, this looks like a bug in core as in the topic's format's lib.php, the code is:

/**
* Returns the display name of the given section that the course prefers.
*
* Use section name is specified by user. Otherwise use default ("Topic #")
*
* @param int|stdClass $section Section object from database or just field section.section
* @return string Display name that the course format prefers, e.g. "Topic 2"
*/
public function get_section_name($section) {
$section = $this->get_section($section);
if ((string)$section->name !== '') {
return format_string($section->name, true,
array('context' => context_course::instance($this->courseid)));
} else if ($section->section == 0) {
return get_string('section0name', 'format_topics');
} else {
return get_string('topic').' '.$section->section;
}
}

With the parameter description stating that it could be an integer but, there is no checking code as in the parent's method:

/**
* Returns the display name of the given section that the course prefers.
*
* @param int|stdClass $section Section object from database or just field course_sections.section
* @return Display name that the course format prefers, e.g. "Topic 2"
*/
public function get_section_name($section) {
if (is_object($section)) {
$sectionnum = $section->section;
} else {
$sectionnum = $section;
}
return get_string('sectionname', 'format_'.$this->format) . ' ' . $sectionnum;
}

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月17日星期日 00:03

But have now noticed the line:

$section = $this->get_section($section);

So, umm should work in either case.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月17日星期日 00:19

But...

In '/course/format/lib.php'...

public final function get_section($section, $strictness = IGNORE_MISSING) {
if (is_object($section)) {
$sectionnum = $section->section;
} else {
$sectionnum = $section;
}
$sections = $this->get_sections();
if (array_key_exists($sectionnum, $sections)) {
return $sections[$sectionnum];
}
if ($strictness == MUST_EXIST) {
throw new moodle_exception('sectionnotexist');
}
return null;
}

Can return 'null' as $strictness is 'IGNORE_MISSING'. Which would cause the error.

Could you list in graphic detail the steps you did to reproduce the error as I cannot, but if I can then it can be used for the foundation of a core fix.

Thanks,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月17日星期日 02:24

For the life of me, I can't get the error to show up now on either of the courses. I apologize if I've wasted your time. I'll post again if it shows up again but for now it looks like everything is working. I really appreciate your work on this!

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月17日星期日 02:48

Dear Marc,

No worries , after all, I have fixed a bug and learnt more about the perils of not having type safety in a language.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月17日星期日 21:41

Dear all,

I have fixed the bugs and uploaded new versions. I've edited the original post with the new links. The old links are no longer valid as I've disabled them.

Even if you downloaded and installed the previous version, please update as normal using the standard instructions in the Readme.md file.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月18日星期一 06:46

I found the error again but now realize it has nothing really to do with any of the formats so it's probably nothing you have to worry about. It showed up once I went back to work on trying to get the Sidebar Block to work. I had deleted the sidebar block to get rid of some deprecated errors and hadn't realized that the format error was actually part of that problem instead. Here is what the error looked like if you are interested.

Strict Standards: Creating default object from empty value in /Volumes/Moodle_Data/Webserver/Documents/moodle/blocks/side_bar/block_side_bar.php on line 60

Function get_course_section() is deprecated. Please use course_create_sections_if_missing() and get_fast_modinfo() instead.

line 3032 of /lib/deprecatedlib.php: call to debugging()
line 167 of /blocks/side_bar/block_side_bar.php: call to get_course_section()
line 756 of /blocks/moodleblock.class.php: call to block_side_bar->get_content()
line 232 of /blocks/moodleblock.class.php: call to block_list->formatted_contents()
line 953 of /lib/blocklib.php: call to block_base->get_content_for_output()
line 1005 of /lib/blocklib.php: call to block_manager->create_block_contents()
line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()
line 6 of /theme/base/layout/general.php: call to block_manager->region_has_content()
line 804 of /lib/outputrenderers.php: call to include()
line 734 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 240 of /course/view.php: call to core_renderer->header()

Function get_all_mods() is deprecated. Use get_fast_modinfo() and get_module_types_names() instead. See phpdocs for details

line 3004 of /lib/deprecatedlib.php: call to debugging()
line 170 of /blocks/side_bar/block_side_bar.php: call to get_all_mods()
line 756 of /blocks/moodleblock.class.php: call to block_side_bar->get_content()
line 232 of /blocks/moodleblock.class.php: call to block_list->formatted_contents()
line 953 of /lib/blocklib.php: call to block_base->get_content_for_output()
line 1005 of /lib/blocklib.php: call to block_manager->create_block_contents()
line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()
line 6 of /theme/base/layout/general.php: call to block_manager->region_has_content()
line 804 of /lib/outputrenderers.php: call to include()
line 734 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 240 of /course/view.php: call to core_renderer->header()

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月19日星期二 00:57

Dear Marc,

Thanks for that . Was it a custom block or a standard block? This is because the error relates to recent course / course format API improvements by Marina Glancy.

The Collapsed Topics bit is because my 'get_section_name' in lib.php can be called by anything that needs it and if called with an invalid value can cause issues.

Thanks,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月19日星期二 06:07

It was a side bar block that I really want to use but it's not fully updated yet to 2.4.

I just downloaded the newest version of the collapsed topic format. I noticed the rounded toggle heading now. Although it's cool, I'm playing with the CSS of a moodle theme and was wondering how I can make it be rectangular again?

I try to put borders around the topic sections and although I can always get it to work in regular Topic format I can never get a right border to show up in Collapsed Format except for around the orphaned sections and the Open All, Close All section.

Any way if I have a border around it, the toggle heading looks better if it is rectangular. If it's easy to do let me know. Thanks.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月19日星期二 18:00

Dear Marc,

Thanks for the info on the side bar block.

The style that does the rounded corners is in the file 'styles.css':

/* -- The section name and summary of a Toggle -- */
.course-content ul.ctopics li.section .content .toggle {
display: block;
text-align: left;
padding: 0 0;
width: auto;
-moz-border-radius: 0.7em;
-webkit-border-radius: 0.7em;
border-radius: 0.7em;
}

Which is easily overrideable in the theme styles.

Could you post a screen shot of the right border issue and I'll look at it.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月20日星期三 00:43

I don't want you to waste too much time on this as it's not that big of a deal. I was able to put a nice clean box around the inner content so that will work ok as you can see in the picture. But around the outer box that would include the editing icons and highlight I can get borders around everything except the right side. It's like it's one pixel off or something because the right border does show on the Open/Close box as well as any orphaned sections. I have however just installed the Grid Format and the teachers are going to LOVE that!

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月20日星期三 01:48

Thanks for the CSS location for the curved toggle. I've checked that off of my list of moodling!

I'm very excited about the grid format because in the past I showed teachers how to make icon maps in section 0 that would jump to their other sections. This is kind of like that but way cooler! One thing that I was thinking would be really nice would be able to go into the Edit Settings to change some colors like you can in the collapsed topics format. Currently, it's based off of your theme but in one theme I was using the colors didn't look that great together in the pop-up. It would be nice if I could change background and link colors on that pop-up page. I'm not complaining though because the format is already way awesome. The grid format is just one more selling point that I have that just might save my life when I roll out 2.4 for my faculty.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月20日星期三 04:18

Dear Marc,

Thanks for the screen shot, really helps - I see what you mean by the 1px, odd when I get time I'll look into it as I'm a perfectionist.

With the Grid format for Moodle 2.4, you can get the latest and greatest version from https://github.com/gjb2048/moodle-courseformat_grid/tree/MOODLE_24_STABLE - I'm currently discussing with Juilian about taking over publishing of the format. There is one idea in the pipeline of being able to set the size of the grid boxes which would introduce settings (Juilian has asked me for this), then it would be less work to add colour to the borders of the boxes. However, I am aware of this functionality crossing over into the realm of themes, so styles there might be more appropriate unless they have to be per course.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月20日星期三 08:09

I was going to suggest different sized boxes also but didn't want anyone to think that I don't think the format is awesome. Since you are the moodle expert as far as the colors go, is it a "moodle bad thing" to cross over into the realm of themes? I really am always wanting my teachers to have more control over changing how their courses look. Basically, as the admin, I have to provide them with themes to choose from. I love it and so do they when they can change how things look like by themselves like with your collapsed course format. I'm still waiting for a theme that teachers can use where all of the background and font colors can be changed by them. Maybe this isn't that easy to do? Just curious.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月21日星期四 00:37

So I was playing around with the grid format and I logged in as a fake student and none of the grids showed up. I found the thread: https://moodle.org/mod/forum/discuss.php?d=218505 where you said the code should be: $showsection = $has_cap_vishidsect || ($thissection->visible && ($thissection->available || $thissection->showavailability || !$course->hiddensections)); I made the change and that fixed it. However I'm pretty sure I downloaded the "latest and greatest" format so I thought I would let you know to check it.

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月21日星期四 01:43

Dear Marc,

RE: Grid format. Thanks for reminding me about the logic issue - was on my todo list and must have forgotten to push the change to GitHub.

The boundary between course formats and theme's can be a little blurred at times. I think that themes should establish a site wide consistent style and then course formats follow that through style reuse where ever possible. However, when it comes to arranging the layout and course specific styling, that is the domain of the course format. So, certain user configuraton functionality depends on the granularity of the solution you want to implement.

Therefore, do you want user's to be able to change their overall style for all courses, in which case that's a theme issue and needs to be addresed there through some sort of per user configuration. Or if it is to establish a style for a course for all users of that course, then that can be achieved though the use of course specific settings as I already do with Collapsed Topics. If the latter, what more customisations would you like?

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月21日星期四 01:54

Dear Marc,

RE: Grid format.

Looking into it, I had made the change on line 282 of renderer.php and pushed the change to GitHub 24 days ago. What version did you download to have to make the change?

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月21日星期四 06:41

Hmmm. Maybe I didn't have as new a version as I thought.

This is from the version file:

$plugin->version = 2012082200;

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月21日星期四 20:32

Dear Marc,

The version number for the Grid format does not tend to change unless the database does - long story. What is the value of 'release' please?

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月21日星期四 23:28

whoops

// User-friendly version number
$plugin->release = '2.4.0.6';

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月22日星期五 02:24

Dear Marc,

Thats the older version. The latest stable is 2.4.1 from https://github.com/gjb2048/moodle-courseformat_grid/tree/MOODLE_24_STABLE.

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月23日星期六 07:00

Thanks, I've reinstalled.

Can you give me a quick point where in my theme I can find some CSS? When I click on a grid block in the grid format in my physics course the background color in the popup is too close to some of the text and I want to see where that color is coming from?

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Richard Oelmann - 2013年03月23日星期六 15:15

Use firebug - and add on for firefox - or similar tools in Chrome/IE to help you identify the selectors and where they are coming from. There is a firebug tutorial video on the themes forum.

Richard

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月26日星期二 07:11

Thanks. I'm surely but slowly learning. It was .shadebox

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月26日星期二 18:17

Dear Marc,

Sorry for not replying, have you sorted it? Was it an issue with the theme or the grid format?

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Richard Oelmann - 2013年03月21日星期四 05:59

per user configuration inside one theme is not something I've seen anywhere to date, but would be interesting to try. I know we can make changes in themes by using the course (or category) id as a body class and applying changes that way, I presume we could add a user id body class with a bit of logic to add it (I don't think its there automatically), but whether we could generate theme settings on a per user basis other than by coding them (or putting them, site wide but using a userid body class, into customcss) could be interesting --- maybe a customcss box as a custom user profile field [thinking aloud rather than having tried this at all!!!]

Richard

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年03月21日星期四 20:35

Dear Richard,

Humm, interesting - perhaps there needs to be something like in 'My Moodle' that adds the capability for users to have customised theme colours and fonts to make their learning environment more 'personalised'. I did mess with the concept back in 1.9 by providing different varients of the same theme and allowing users to pick one.

This I think leads to a themes forum post to discuss this .

Cheers,

Gareth

平均分： -

Re: Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Marc Hermon - 2013年03月16日星期六 22:05

Clicked on Site Administration -> Notifications? Yes

Performed a 'Purge All Caches' - please see Readme.md. Yes, several times

Is one of the sections a current section? yes, is that how it works now? That the highlighted section will always be open even if a student closes the arrow? I changed the highlighted section in two different courses and that section would always be open when I came back to it.

Did it happen before the upgrade? no, at least not on 1.9, We were only on 2.2 for a couple of weeks where I tried to update everything and I am pretty sure it was working on there.

Does it happen in other Collapsed Topics courses? In both courses I'm testing in if I highlight a different section it will always be open. If I try to open another section besides the highlighted section when I come back it will not still be open. In one of the courses my section 10 is always open. I moved the section 10 content up to section 8 to see if it had anything to do with the content but section 10 is still open with its new content. However as soon as I did this the following error was thrown on the page.

Does it happen if you change the course format to 'topics', save then back to 'Collapsed Topics'? yes, also have tried this several times

Also, please can you tell me the specific version / build of Moodle, Theme and Collapsed Topics from the entire contents

Moodle 2.4.2 (Build: 20130311)

Topcoll version (2013031400) release (2.4.3.1)

Standard Theme in both courses (version 2012112900)

平均分： -

Re: Translate Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Guido Hornig - 2013年04月22日星期一 19:35

Thanks for the great topcoll plugin.Togehter with decaf, it makes moodle so much more attractive.

I want to translate, because I need a german lang file.
In AMOS is no maintainer visible. Due to my lack of knowledge about AMOS, I don't know if it makes sence to continue there. What happens to the translations I add?

I red that older lang files can be uploaded by the maintainer.

Can you upload the lang files from moodle 2.2 into AMOS, there where some translations already, this could save some time - but many things changed.

Because of the enormous fantastic new features, the admin part needs some more translation and I want to encourage other people to help.

Here is th AMOS topcoll link

Any other German Users out there?

平均分： -

Re: Translate Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年04月22日星期一 21:30

Dear Guido,

I've done so now, http://lang.moodle.org/local/amos/contrib.php?id=5886, just waiting for the language maintainer to commit them. But not all strings translated, so help appreciated in AMOS.

Cheers,

Gareth

平均分： -

Re: Translate Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Jonas Rüegge - 2013年05月8日星期三 18:48

The School I work for wants to use the topcoll plugin in 2.4.3+ (and it works fine), so same issue here (Translation in German)

平均分： -

Re: Translate Collapsed Topics add-on for Moodle 2.3.4+ and 2.4.1+ updated.

Gareth J Barnard - 2013年05月8日星期三 19:50

Dear Jonas,

I'd be quite happy to submit to AMOS a translation of the English language file in German if it was provided as I can only use Google Translate. Currenly some of the strings are translated, but I don't know how that works yet in an installation. So might be possible to add and send me the changes.

Cheers,

Gareth

平均分： -