Looks basically OK, so far as you've done! It needs the settings page options, database change to store them, etc., plus tidying to meet code style guidelines.
By the way I realise you might not have done it yet, but it's worth learning how to use the Moodle Tracker and github to submit proposals as it's a lot easier for other people to review patches that way!
--sam