Is notification page supposed to be free of require_login()?

Is notification page supposed to be free of require_login()?

על ידי Daniele Cordella בתאריך
מספר תגובות: 1
תמונה של Core developers תמונה של Particularly helpful Moodlers תמונה של Plugin developers

It is late in the night.
I am upgrading moodle code. (git fetch...)
Baby cries and I run to him.
The time passes and I go to sleep.
Next morning I go back to notification page... and login is not required.
Moodle upgrade happens regularly.
Is this supposed to be allowed?

ממוצע דרוגים: -
בתגובה ל: Daniele Cordella

Re: Is notification page supposed to be free of require_login()?

על ידי Tim Hunt בתאריך
תמונה של Core developers תמונה של Documentation writers תמונה של Particularly helpful Moodlers תמונה של Peer reviewers תמונה של Plugin developers

It has to be. For major upgrades, like 1.9 -> 2.0, the database tables that the login code uses may have changed a lot between releases, so require_login cannot work until after the upgrade is comlete.

This is why you should put your site into maintenance mode before starting to upgrade.