SCORM

Hi, I work with Andrea and we may have found a solution to this problem, that implies commenting a few code lines in moodle.

I will resume here the problem and the solution. The question is: does our solution affect negatively other parts of the Moodle code?

The problem
As Andrea already said, we have inserted a SCORM learning object in our Moodle, and we expect to see in the reports each lesson as "completed" after viewing the 80% of it.
What we actually see is:
- viewing lesson for a few seconds (<80%) and stop: report says "incomplete"
- viewing same lesson for another few seconds (<80%): "complete"
- viewing same lesson for another few seconds (<80%): "incomplete"
- viewing same lesson for another few seconds (<80%): "complete"
- ... and so on: complete, incomplete, complete, incomplete...
- until I reach 80% of the lesson, then the report always says "complete"

Steps to reproduce
You can find the course zip here:
http://dl.dropbox.com/u/3198614/impress_scorm_con_asset_v2.0.zip
The SCORM has been generated with Adobe Captivate 4, with this reporting options:
- SCORM 1.2
- Report interactions and the score
- Report Complete/Incomplete
- Report Score to LMS as Percent
- 80% or more of total score to pass

Moodle SCORM configuration is shown in the Andrea's post screenshot.

The proposed solution
After doing some debugging with firebug and monitoring DB changes we noted that:
- every time the player loads the lesson, it's set "completed" even before actually playing it the first time (loadSCO.php)
- when the sco is being played, after each slide it sends the status information to the LMS
- when the sco is stopped, it sends the completion information to the LMS, which in case of status "incomplete", overrides the "completed" set by moodle when the player is loaded
- the problem is here: the completion status is being sent to the LMS only alternately

I think the problem is on the Captivate side.
Anyway, we have seen that commenting this lines in Moodle's moodle/mod/scorm/loadSCO.php solves the problem:

(lines from 72 to 77)

/* if ($sco->scormtype == 'asset') {
$attempt = scorm_get_last_attempt($scorm->id,$USER->id);
$element = ($scorm->version == 'scorm_13' || $scorm->version == 'SCORM_1.3') ? 'cmi.completion_status':'cmi.core.lesson_status';
$value = 'completed';
$result = scorm_insert_track($USER->id, $scorm->id, $sco->id, $attempt, $element, $value);
} */

This way it works fine for us.
Any comment on this? Is it dangerous to leave this lines commented?

Thanks for any suggestion.

Cheers,
Federica.