General plugins

Hello,

I got this to work (or at least, I got it to load the page without errors) by copying exercise_get_best_grade() and renaming it exercise_get_best_submission_grades().

Do you think this is the correct solution? That is, do you think the function call in line 274 simply has the name of the function wrong? Or is there another problem I should address? Has anybody else seen this?

Please forgive my newbie ignorance.


Thanks,
Orville

///////////////////////////////////////////////////////////////////////////////////////////////
// I am adding this function to fix an error a professor encountered accessing the gradebook
// for a course: https://ilearn.sfsu.edu/course/grades.php?id=13
// He received an error:
// Fatal error: Call to undefined function: exercise_get_best_submission_grades()
// in /Library/WebServer/Documents/mod/exercise/lib.php on line 274
// It appears to me that the the above function, exercise_get_best_grade($submission), is the one
// the programmer intended to call. I do not know for certain whether the above function is called
// by other php scripts in the moodle application, so I did not want to edit that function.
// Therefore, I copied that function and renamed it to match the name of the function that is
// called in line 274.

function exercise_get_best_submission_grades($submission) {
// Returns the best grade of students' submission (there may, occassionally be more than one assessment)
global $CFG;

return get_record_sql("SELECT MAX(a.grade) AS grade FROM
{$CFG->prefix}exercise_assessments a
WHERE a.submissionid = $submission->id
GROUP BY a.submissionid");
}