turn editing on in course list breaks css in IE8

turn editing on in course list breaks css in IE8

by dan attwood -
Number of replies: 4
I have a custom theme that works fine in IE, FF, chrome etc for all pages apart from the course list pages. If I view these pages with editing on in IE8 the css goes all screwy and the content div is to big - see screeny.

It works fine in Firefox and Chrome - does anyone have any suggestions?
Attachment css-issue.jpg
Average of ratings: -
In reply to dan attwood

Re: turn editing on in course list breaks css in IE8

by Patrick Malley -
There is no way to know what might be causing this without seeing the actual site or theme. Can you provide a link or upload the theme?
In reply to Patrick Malley

Re: turn editing on in course list breaks css in IE8

by Andres Ortiz -
Sorry Patrick... but maybe you can help me...

I installed the theme "Sky High" (http://moodle.org/mod/data/view.php?d=26&rid=2385&filter=1) but I have problems with viewing iexplorer 7 and 8, i think the problem is in the header.html and is related to the div ... but i dont sure... = S can you help me? please.
In reply to Andres Ortiz

Re: turn editing on in course list breaks css in IE8

by Mary Evans -
Hi AndresR

I've been taking a close look at this theme, and what a nice theme it is too. It is new to me but has some nice features.

The problems you are encountering in IE7/IE8 are caused by some minor things happening in the theme.css. The header also has a few little things which need tidying up but not critical to other browsers but obviously upset Internet Explorer!

If you look at <h1> tag in header its been coded as a nested tag which is probably OK but not my choice. So if you close the first tag </h1> after heading and then delete the 2nd </h1> after summary. This puts the heading back into IE7/IE8.

Other things are missing semicolon ; before the ?> of <php? tags. These are probably minor things but for consistency should be put in I think.

In the theme.css you need to change header.navbar, header-home.navbar to just .navbar that puts the correct colour background into the navigation bar just underneath the header.

That's about it.

Mary

Edit: Here are the changes to the header.html (see attached file top right of this comment).
I've attached the theme.css in the next post.
In reply to Andres Ortiz

Re: turn editing on in course list breaks css in IE8

by Mary Evans -
And here are the changes to the theme.css (see attached file top right of this comment).
There where a couple more things needed to be changed in the theme.css. The styling for h1.headermain and h1.summary needed tweaking...little minor things like float and such...but all's well now!
It works OK in my version of IE8 now with or without compatibility mode.

I really enjpyed fixing this...so thanks for posting it here.

By the way...I have a feeling Patrick is very busy with Moodle 2.0.

I also trust Julian Ridden who created the theme wont mind me fixing it! smile

Mary