Moodle in English: theme issue with OU wiki

Wiki

theme issue with OU wiki

This discussion has been locked because a year has elapsed since the last post. Please start a new discussion topic.

theme issue with OU wiki

by Fritz Richter - Monday, June 22, 2009, 4:47 AM

Hi Sam,

Using non-standard themes, I'm experiencing some problems with the footer on subpages of a OU Wiki. The footer looks fine on the main page of a wiki. On subpages however, the footer jumps upwards and messes up the content. Since this issue appears with all custom themes, I assume there is a tiny bug in the code that generates the footer for subpages. Maybe you have any idea?

Best Fritz

Re: theme issue with OU wiki

by Fritz Richter - Monday, June 22, 2009, 6:26 AM

well, I think I got it:

I changed line 746 of ouwiki.php

$result.='</ul>';

into

$result.='</ul></div>';

now the footer is displayed correctly for wiki subpages.

Best Fritz

Average of ratings: -

Re: theme issue with OU wiki

by sam marshall - Tuesday, June 23, 2009, 12:31 AM

Thanks! You are correct. Sorry about that - we should have spotted it because it causes pages to fail the HTML validator.

I have fixed this in the official code - and also fixed 2 other validation errors (which may not have been doing any harm, but you never know). Now the page validates fully.

Bug is CONTRIB-1370 and fixed ouwiki version is 2009062200.

By the way - thanks to Helen for passing this on to me! I'm afraid I am not subscribed to this forum because most of the discussion is not related to OU wiki, so it would really help if you could report ouwiki problems using the tracker. If you select 'contributed code' to start with, and then 'Module: OU wiki' in the component field, it will go straight to me. (Of course I welcome forum discussions as well, you can link these in the bug if you want me to read them!)

(If there's something that isn't a bug but just a discussion about ouwiki that you'd like me involved in, um, let me know!)

--sam

Average of ratings:Useful (1)