Overall Feedback Problem in 1.9.4

Overall Feedback Problem in 1.9.4

由Deb Burdick-Hinton發表於
Number of replies: 10
Hello All-
I am not sure if this problem just started occurring or if it was present in 1.9.2 before we upgraded but I am noticing it now. See attached screen shot. The overall feedback still appears to be working but this message is currently displayed in the "Update Quiz" settings of all of our quizzes even though there is a grade associated with this quiz: "This quiz is not graded, so you cannot set overall feedback that differs by grade. "

Not sure what this message means? I reset attempts and took the quiz as a practice student earning two different grades and got the feedback but this message might discourage others to use this feature and am concerned their might be other issues with it in the future. I have gone into a variety of quizzes with a wide range of settings and this message appears in all of them. Odd?

Appreciate any feedback you have.

Thanks
附件 OverallFeedbackMessage.jpg
評比平均分數： -
In reply to Deb Burdick-Hinton

Re: Overall Feedback Problem in 1.9.4

由ben reynolds發表於
We just upgraded to 1.9.4 and that's the first time I saw it. My quizzes have various grades on them, so they ARE graded.
評比平均分數： -
In reply to ben reynolds

Re: Overall Feedback Problem in 1.9.4

由Deb Burdick-Hinton發表於
Do you also see that message? All of my quizzes are graded as well and I still have that message displayed in the quiz settings.
評比平均分數： -
In reply to Deb Burdick-Hinton

Re: Overall Feedback Problem in 1.9.4

由ben reynolds發表於
Yes, but it doesn't seem to have any effect on anything except, of course, on teachers who might believe it.

I went back to a quiz and entered overall feedback, which does show up in the gradebook.

Googling "Moodle Tracker 'This quiz is not graded'" produces only this topic, so it seems like an appropriate bug to report.

Tim Hunt might know what to do about it.
評比平均分數： -
In reply to Deb Burdick-Hinton

Re: Overall Feedback Problem in 1.9.4

由Tim Hunt發表於
Core developers的相片 Documentation writers的相片 Particularly helpful Moodlers的相片 Peer reviewers的相片 Plugin developers的相片
This is something I added recently (MDL-18583), and it looks like I messed up.

I have just fixed it (MDL-18871). The error only involves the decision about whether to display the warning message, the actual functionality of the form is fine, as far as I can see.
評比平均分數： -
In reply to Tim Hunt

Re: Overall Feedback Problem in 1.9.4

由Azhar Ghani發表於

Hi Tim,

Your help required for a hack..

I have customized New Quiz Settings.. I want to put default Overall Feedback in the system  as:

100%  Pass  --  40%   Fail -- 0%

and do not display on new quiz settings for the teachers.

Could you please guide me?

Thanx

評比平均分數： -
In reply to Azhar Ghani

Re: Overall Feedback Problem in 1.9.4

由Azhar Ghani發表於

Changes required in the code (below):

$repeatarray = array();
$repeatarray[] = &MoodleQuickForm::createElement('text', 'feedbacktext', get_string('feedback', 'quiz'), array('size' => 50));
$mform->setType('feedbacktext', PARAM_RAW);
$repeatarray[] = &MoodleQuickForm::createElement('text', 'feedbackboundaries', get_string('gradeboundary', 'quiz'), array('size' => 10));
$mform->setType('feedbackboundaries', PARAM_NOTAGS);
 
if (!empty($this->_instance)) {
               $this->_feedbacks = get_records('quiz_feedback', 'quizid', $this->_instance, 'mingrade DESC');
          } else {
               $this->_feedbacks = array();
           }
           $numfeedbacks = max(count($this->_feedbacks) * 1.5, 5);
 
           $nextel = $this->repeat_elements($repeatarray, $numfeedbacks - 1,
                   array(), 'boundary_repeats', 'boundary_add_fields', 3,
                 get_string('addmoreoverallfeedbacks', 'quiz'), true);

Thanx

評比平均分數： -
In reply to Azhar Ghani

Re: Overall Feedback Problem in 1.9.4

由Azhar Ghani發表於

Customized code is as under:

$mform->addElement('static', 'gradeboundarystatic1', get_string('gradeboundary', 'quiz'), '100%');
        
        $mform->addElement('static', 'feedbacktext', get_string('feedback', 'quiz'), 'Pass');
        $mform->addElement('static', 'gradeboundarystatic2', get_string('gradeboundary', 'quiz'), '40%');
        $mform->addElement('static', 'feedbacktext', get_string('feedback', 'quiz'), 'Fail');

        //$repeatarray = array();
        //$repeatarray[] = &MoodleQuickForm::createElement('text', 'feedbacktext', get_string('feedback', 'quiz'), array('size' => 50));
        $mform->setType('feedbacktext', PARAM_RAW);
        //$repeatarray[] = &MoodleQuickForm::createElement('text', 'feedbackboundaries', get_string('gradeboundary', 'quiz'), array('size' => 10));
        $mform->setType('feedbackboundaries', PARAM_NOTAGS);
        
        if (!empty($this->_instance)) {
            $this->_feedbacks = get_records('quiz_feedback', 'quizid', $this->_instance, 'mingrade DESC');
        } else {
            $this->_feedbacks = array();
        }
        $numfeedbacks = max(count($this->_feedbacks) * 1.5, 5);
        $nextel = $this->repeat_elements($repeatarray, $numfeedbacks - 1,
                array(), 'boundary_repeats', 'boundary_add_fields', 3,
                get_string('addmoreoverallfeedbacks', 'quiz'), true);

        // Put some extra elements in before the button
        //$insertEl = &MoodleQuickForm::createElement('text', "feedbacktext[$nextel]", get_string('feedback', 'quiz'), array('size' => 50));
        //$mform->insertElementBefore($insertEl, 'boundary_add_fields');

        $insertEl = &MoodleQuickForm::createElement('static', 'gradeboundarystatic3', get_string('gradeboundary', 'quiz'), '0%');

But messing up while trying to remove Button Add 3 more Feedback Fields.

Any Clue..

評比平均分數： -
In reply to Azhar Ghani

Re: Overall Feedback Problem in 1.9.4

由Tim Hunt發表於
Core developers的相片 Documentation writers的相片 Particularly helpful Moodlers的相片 Peer reviewers的相片 Plugin developers的相片

have you commented out the call to repeat_elements?

評比平均分數： -
In reply to Tim Hunt

Re: Overall Feedback Problem in 1.9.4

由Azhar Ghani發表於

Thanx Tim for the response..

Yes I did.

評比平均分數： -
In reply to Azhar Ghani

Re: Overall Feedback Problem in 1.9.4

由Azhar Ghani發表於

done after little modification:

//$numfeedbacks = max(count($this->_feedbacks) * 1.5, 5);
        //$nextel = $this->repeat_elements($repeatarray, $numfeedbacks - 1,
                //array(), 'boundary_repeats', 'boundary_add_fields', 3,
                //get_string('addmoreoverallfeedbacks', 'quiz'), true);

        // Put some extra elements in before the button
        //$insertEl = &MoodleQuickForm::createElement('text', "feedbacktext[$nextel]", get_string('feedback', 'quiz'), array('size' => 50));
        //$mform->insertElementBefore($insertEl, 'boundary_add_fields');
        $mform->addElement('static', 'gradeboundarystatic2', get_string('gradeboundary', 'quiz'), '0%');
        //$insertEl = &MoodleQuickForm::createElement('static', 'gradeboundarystatic3', get_string('gradeboundary', 'quiz'), '0%');
        //$mform->insertElementBefore($insertEl, 'boundary_add_fields');

評比平均分數： -