David Scotson

That's a great piece of documentation, does it have permanent home somewhere (maybe the wiki) where we can refer people to it?

A random minor bug that'll I'll just leave here while it's on my mind:

The first entry in the Navigation block, "home" needs to be special cased because the underlying HTML is a bit of a bodge. That menu is actually a collapsable one (similar to the Settings block) that's been hacked so that it never collapses shut, and also to make the sub-items line up with the parent item ("home").

As a result you probably want to specify a different icon for that item (perhaps the little house?) and adjust the styles on that ul tag so that it counteracts whatever indentation you're using in the other settings menus and restores the illusion that it's not a sub-list at all.

And, totally unrelated to that, but I just noticed the use of Font Awesome in the performance info, nice touch!

I use $CFG-themedir and it's working for me. I just double-checked in case I was getting a local copy of the font, but Firefox tells me it's loading the font from the themedir I set. I looked at the code and it's checking for themewww, so maybe it's because I've got that set as well?

I think an option to get the font from a CDN (http://www.bootstrapcdn.com/#tab_fontawesome) could be good, and make things slightly faster as well as avoid some of the weirdness people experience. I'd recommend that as the default in fact.

Also, I think you typo'd that middle bug, or at least I can't figure out the link.

My primary test site is following 2.6 master, the Font Awesome icons partly work with the new drop down (so you get the correct hover effect with the icon switching from black to white when the background changes to blue, unlike the standard icons that remain mid-gray) but fails in other ways e.g. the new menu item is missing so you have to click a blank space to get the dropdown, the seperators look odd etc.

Don't know if that's relevant until 2.6 gets released but thought you'd want to know anyway.

Apart from the occasional weird one, like the eye, and some that are hard coded, you should be able to output the i tag from the renderer along with a span.accesshide for the alt text rather than add them via CSS :before and :after and hide the img tag. Then your well on the way to fixing all icons throughout moodle in a way that core Moodle may adopt.

You can vote and follow a relevant bug:

Use the Font Awesome icon font for all icons in Moodle
https://tracker.moodle.org/browse/MDL-40759