David Scotson

Really nice.

Some random questions/comments:

1. Are the blocks always at the bottom? I'd been thinking I was going to limit my next theme to two columns, with the blocks always on the less important side (i.e. right if LTR), but I really like the idea of having them at the bottom instead to further de-proiritize them and limit their number. I can see all that whitespace being divisive though, people really want to get the most of the big monitors they've bought, even if the result is difficult to read text that looks totally different to how their students see it on netbooks and iPads..

2. Is the text in block descriptions or labels? The feedback one seem to stick out left more than the rest, and there's a very small (unintentional?) indent on the links. I've just been working around some bugs in labels to make them integrate with the resource links better, basically removing padding/margin above and below them. But with the vertical space on your hearders, it might actually just work with this look.

3. I really like the lack of icons. I've noticed before that it's the icons that contribute most to making things "Moodle-y", particularly as they're generally so difficult to change. Even if people intend to use icons, I think it makes a lot of sense to get everything else right first, then add the icons back as needed.

It says 349 replies on the main page (350 including this one), or are we counting two different things?

Either way it's impressive to see the enthusiasm.

I've updated the page, the changes are:

1. new text for the MySQL collation issues: "This is expected to fail if you are running MySQL. These tests should pass if you use the utf8_bin collation on your database for unit tests, but we recommend utf8_unicode_ci for actual live Moodle sites. Work is being done to resolve this issue, read more about the Database collation issue for further info."

2. grouping the three MySQL failures together

3. changing the solutions from being seperate headings as it was cluttering the table of contents

4. making command line error messages, or instructions of what to type to fix problems into code rather than quoted text.

5. seperating out general issues (like the tests taking too long) from specific individual failures.

I also filed a bug for adding a pointer to this page from the releveant unit test failure messages: MDL-43132

I think it's spread since then, there probably needs to be a bug for the whole of Moodle, and to deal with the fact that people have been using both these names interchangeably for a couple of years now.

I filed MDL-43112

I think it's basically a mistake, it's caused issues like MDL-39292 when both styles are used right next to each other and there's no rhyme or reason to it that I can detect.

There's fewer smallicon than iconsmall and the names are unique enough that a single search and replace across Moodle could probably sort this out.

edit: MDL-26786 seems to suggest smallicon is just a typo that got out of hand.