I just noticed this line in the 2.4 release notes.
"We will probably drop support for IE8 in Moodle 2.5 (June 2013)"
http://docs.moodle.org/dev/Moodle_2.4_release_notes#Requirements
This kind of took me by surprise, is there some component or other that is forcing this issue, or was it just felt time to draw a line in the sand? When will the final decision by made?
David Scotson
Mezuen egilea: David Scotson
Some conflicting info there:
{theme name}_{plugin type}_{plugin_name}_{subtype}_renderer_{target}
where theme name prefix, subtype infix and target suffix are optional.
vs.
class theme_overridetest_core_renderer extends core_renderer {}
What we have added is the class definition for our first renderer. Note:
The name of the renderer is VERY important it is made up of three sections joined by underscores:
theme : This will always be the same when overriding renderers from the theme.
overridetest : This is of course the name of our theme, and should be the name of the theme the renderer is being overridden from.
core_renderer : This is the renderer that we are overriding.
It would be nice if I could leave the name of the theme off, as a) it means less typing, b) it would be easier for people to share and re-use renderers. Perhaps it was only suggested to use it since you need to make the classname different in some way from the class you are using, so we could all just use "theme" instead?
{theme name}_{plugin type}_{plugin_name}_{subtype}_renderer_{target}
where theme name prefix, subtype infix and target suffix are optional.
vs.
class theme_overridetest_core_renderer extends core_renderer {}
What we have added is the class definition for our first renderer. Note:
The name of the renderer is VERY important it is made up of three sections joined by underscores:
theme : This will always be the same when overriding renderers from the theme.
overridetest : This is of course the name of our theme, and should be the name of the theme the renderer is being overridden from.
core_renderer : This is the renderer that we are overriding.
It would be nice if I could leave the name of the theme off, as a) it means less typing, b) it would be easier for people to share and re-use renderers. Perhaps it was only suggested to use it since you need to make the classname different in some way from the class you are using, so we could all just use "theme" instead?
Is there some documentation on this?
The first "renderer(s)" in my class name is actually part of the theme name "bootstrap_renderers", confusing I know, but I chose the name before I knew about the naming convention.
I've always assumed you needed to copy the full name in order for it to find the right class. And I've got so many renderers that I can't call them all "theme_bootstrap_renderer".
The first "renderer(s)" in my class name is actually part of the theme name "bootstrap_renderers", confusing I know, but I chose the name before I knew about the naming convention.
I've always assumed you needed to copy the full name in order for it to find the right class. And I've got so many renderers that I can't call them all "theme_bootstrap_renderer".
It's not a big problem, I just wasn't sure if I was doing it right, I'd spent a day wondering why some other course renderer stuff wasn't working and eventually realised I'd missed "theme" off the start of the class name so I was beginning to doubt myself.
Sorry, it was actually course/format/renderer.php that I'm having trouble with, since that is an abstract class that is then inherited by course/format/topic/renderer.php. But when you create renderers that inheritence relationship is broken (as far as I can tell) and your topic/renderer.php always points at the core class.
Actually typing that out has suggested a solution to me, that I need to explicitly extend the theme_themename class. I'll give that a try.
Actually typing that out has suggested a solution to me, that I need to explicitly extend the theme_themename class. I'll give that a try.