Posts made by Joseph Rézeau

Picture of Core developers Picture of Plugin developers Picture of Testers Picture of Translators

Hi Mike,

So you upgraded your Moodle straight from 1.5 to 1.7 (i.e. you skipped the 1.6 version). A certain number of changes have been introduced in Moodle themes behaviour with version 1.6, for better accessibility compliance.

Also you have transferred your "old" customized theme from 1.5 to 1.7 and were hoping it to work straight away... Unfortunately, this is not the case, as you have found out.sad

You might try to fix your old 1.5 customized theme to make it work with 1.7, but I would strongly recommend basing a new customized theme on 1.7 standard. If you don't want to do this, the minimum you'll have to do is make the necessary "accessibility" changes to your customized theme's header.html file (located in your customized folder, i.e. http://www.cardinal-heenan.org.uk/moodle/theme/college15_fixed/header.html).

Have a look at moodle 1.7 \theme\standard\header.html file and compare it with your own header.html file. You will see that you have to incorporate the changes in red in the extract below.

<?php //Accessibility: 'headermain' is now H1, see theme/standard/styles_layout.css: .headermain
if ($home) { // This is what gets printed on the home page only
?>
<div id="header-home" class="clearfix">
<h1 class="headermain"><?php echo $heading ?></h1>
<div class="headermenu"><?php echo $menu ?></div>
</div>
<?php } else if ($heading) { // This is what gets printed on any other page with a heading
?>
<div id="header" class="clearfix">
<h1 class="headermain"><?php echo $heading ?></h1>
<div class="headermenu"><?php echo $menu ?></div>
</div>
<?php } ?>
<?php //Accessibility: breadcrumb trail/navbar now a DIV, not a table.
if ($navigation) { // This is the navigation bar with breadcrumbs ?>
<div class="navbar clearfix">

All the best,

Joseph

PS.- Please avoid cross-posting on these forums.wink

Picture of Core developers Picture of Plugin developers Picture of Testers Picture of Translators
Tim > The quiz preview is meant to give teachers a good indication of what students will see, so don't display extra junk there.

I quite agree. That's why I needed a way to tell Quiz preview from Question preview.

I'll keep my $state->attempt method for the time being, then.

When you say that There is no guarantee what value $state->attempt will have in a question preview, any idea where $state->attempt gets its value from when entering question preview?

Thanks,

Joseph

Picture of Core developers Picture of Plugin developers Picture of Testers Picture of Translators

Thanks, John. Nothing brilliant about it, only took me about half a day to do a number of tests, try to re-write partly the Flash player (in Flash), change and re-change filter parameters and finally sort of stumble upon this weird solution for a weird bug.surprise

Glad it helped other people, anyway.

Joseph