Posts made by Joseph Rézeau

Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
Stephen > "IE7 hangs on both the Print Blank and Print this Response buttons (opens a new window but with no content regardless of popup settings or tab settings) but worked fine on FireFox"

This bug has been fixed (but I had forgotten to update my own moodle test site!). Done now. See this discussion.

Joseph

Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators

Hi Pierre and Tim,

I was not aware of MDL-3274 which is an old bug recently revived. Further to this discussion (which did not spark a lot of reactions at the timewink) I have added the following to my local version of multianswer/questiontype.php and am quite happy with it. I see no reason to add a random length element as suggested by Pierre in the bug tracker discussion. We must not be paranoidevil about the provided input length "giving away" the answer to the student, just practical that input length should be reasonably long enough to accomodate the longest correct answer (if there are more than one).

case 'shortanswer':
case 'numerical':
// set length of answer input field to length of longest expected answer
$snmaxlen= 0;
foreach ($answers as $snanswer) {
 if (strlen($snanswer->answer) > $snmaxlen){
 $snmaxlen = strlen($snanswer->answer);
 }
}
if ($snmaxlen<6){ $snmaxlen= 6; }

Joseph

Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers Picture of Testers Picture of Translators
While we are on the (touchy) topic of countries and nations, I would like to see France:Metropolitan removed from that list, for the very good reason that it does not (or no longer) exists. Wikipedia article calls the expression "un abus de langage", and I fully agree.
Joseph
Attachment image00.jpg