General developer forum

Here's a little secret. I'm not a coder, not a PHP programmer, I don't know a fieldset object from my a**. When David Cannon wasn't able to update the certificate from 1.6 on, I took over. It needed backup/restore. Ok, go look at the journal mod and see how its done. Wouldn't it be nice to save the certificates in moddata? Hmmm, go look at the assignment mod and see how it saves the files. Now we need to update for roles, update for mod_form, add some functions and on and on. Go look at other code, hack away for hours on end, then somehow manage to get it to work. That's how I've volunteered my time to maintain and develop the certificate.

There are 3 functions in the certificate that rely on the deprecated _grades functions. Now it needs updated to the new gradelib API. I tried to get it to work, but I can't. If anyone would like to volunteer (how about someone using the certificate?), that would be great. Then, I can also update the activity locking code for 1.9 too -- it relies on similar deprecated functions.

/************************************************************************
* Search through all the modules, pulling out grade data *
************************************************************************/
function certificate_get_mod_grades() {
global $course, $CFG;

/// Collect modules data
get_all_mods($course->id, $mods, $modnames, $modnamesplural, $modnamesused);

$printgrade = array();
$sections = get_all_sections($course->id); // Sort everything the same as the course
for ($i=0; $i<=$course->numsections; $i++) {
// should always be true
if (isset($sections[$i])) {
$section = $sections[$i];
if ($section->sequence) {
switch ($course->format) {
case "topics":
$sectionlabel = get_string("topic");
break;
case "weeks":
$sectionlabel = get_string("week");
break;
default:
$sectionlabel = get_string("section");
}

$sectionmods = explode(",", $section->sequence);
foreach ($sectionmods as $sectionmod) {
if (empty($mods[$sectionmod])) {
continue;
}
$mod = $mods[$sectionmod];
// no labels
if ( $mod->modname != "label") {
$instance = get_record("$mod->modname", "id", "$mod->instance");
$libfile = "$CFG->dirroot/mod/$mod->modname/lib.php";
if (file_exists($libfile)) {
require_once($libfile);
$gradefunction = $mod->modname."_grades";
// Modules with grade function (excluding forums)
if (function_exists($gradefunction) and $mod->modname != "forum") {
// Modules with grading set
if ($modgrades = $gradefunction($mod->instance) and !empty($modgrades->maxgrade)) {
$printgrade[$mod->id] = $sectionlabel.' '.$section->section.' : '.$instance->name;
}
}
else { //Modules without a grade set but with a grade function
}

} // libfile
} // no labels
} //close foreach
} // if section
} // isset section
}
if(isset($printgrade)) {
$gradeoptions['0'] = get_string('no');
$gradeoptions['1'] = get_string('coursegradeoption', 'certificate');
foreach($printgrade as $key => $value) {
$gradeoptions[$key] = $value;
}
} else { $gradeoptions['0'] = get_string('nogrades', 'certificate'); }
return ($gradeoptions);
}

/************************************************************************
* Prepare mod grade for printing *
************************************************************************/
function certificate_mod_grade($course, $moduleid) {
global $USER, $CFG;
$cm = get_record("course_modules", "id", $moduleid);
$module = get_record("modules", "id", $cm->module);
$libfile = $CFG->dirroot."/mod/".$module->name."/lib.php";
if (file_exists($libfile)) {
require_once($libfile);
$gradefunction = $module->name."_grades";
if (function_exists($gradefunction)) {
if ($modgrades = $gradefunction($cm->instance)) {
$modinfo->name = utf8_decode(get_field($module->name, 'name', 'id', $cm->instance));
$modinfo->percentage = round(($modgrades->grades[$USER->id]*100/$modgrades->maxgrade),2);
$modinfo->points = $modgrades->grades[$USER->id];
return $modinfo;
}
}
}
return false;
}
/************************************************************************
* Search through all the modules, pulling out grade data *
* and prepare to print the course grade. *
************************************************************************/

function certificate_get_course_grade($id){
global $course, $CFG, $USER;
$course = get_record("course", "id", $id);
$strgrades = get_string("grades");
$strgrade = get_string("grade");
$strmax = get_string("maximumshort");
$stractivityreport = get_string("activityreport");

/// Get a list of all students

$columnhtml = array(); // Accumulate column html in this array.
$grades = array(); // Collect all grades in this array
$maxgrades = array(); // Collect all max grades in this array
$totalgrade = 0;
$totalmaxgrade = .000001;

/// Collect modules data
$test=get_all_mods($course->id, $mods, $modnames, $modnamesplural, $modnamesused);

/// Search through all the modules, pulling out grade data
$sections = get_all_sections($course->id); // Sort everything the same as the course
for ($i=0; $i<=$course->numsections; $i++) {
if (isset($sections[$i])) { // should always be true
$section = $sections[$i];
if (!empty($section->sequence)) {
$sectionmods = explode(",", $section->sequence);
foreach ($sectionmods as $sectionmod) {
if (empty($mods[$sectionmod])) {
continue;
}
$mod = $mods[$sectionmod];

$context = get_context_instance(CONTEXT_MODULE, $mod->id);
if ($mod->visible || has_capability('moodle/course:viewhiddenactivities', $context)) {
$instance = get_record("$mod->modname", "id", "$mod->instance");
$libfile = "$CFG->dirroot/mod/$mod->modname/lib.php";
if (file_exists($libfile)) {
require_once($libfile);
$gradefunction = $mod->modname."_grades";
if (function_exists($gradefunction)) { // Skip modules without grade function
if ($modgrades = $gradefunction($mod->instance)) {
if (empty($modgrades->grades[$USER->id])) {
$grades[] = "";
} else {
$grades[] = $modgrades->grades[$USER->id];
$totalgrade += (float)$modgrades->grades[$USER->id];
}
if (empty($modgrades->maxgrade) || empty($modgrades)) {
$maxgrades[] = "";
} else {
$maxgrades[] = $modgrades->maxgrade;
$totalmaxgrade += $modgrades->maxgrade;
}

}
}
}
}
}
}
}
}
$coursegrade->percentage = round(($totalgrade*100/$totalmaxgrade),2);
$coursegrade->points = $totalgrade;
return $coursegrade;
}

I don´t know why but wheb I try to add conditional access via Activity Lock Block, I see always this message:

The coursemodule object you gave to grade_exists() isn't set up correctly. Either instance () or courseid (4) field isn't set.

I don´t know how to solve

I´m using moodle 1.9