Blocks

Hi All, I've found a silly bug that was resulting in same effect :

The fix is :

in lib/blockslib.php

function blocks_get_by_page($page) {
    $blocks = get_records_select('block_instance', "pageid = '". $page->get_id() .
                "' AND pagetype = '". $page->get_type() ."'", 'position, weight');

    $positions = $page->blocks_get_positions();
    $arr = array();
    foreach($positions as $key => $position) {
        $arr[$position] = array();
    }

    if(empty($blocks)) {
        return $arr;
    }

    foreach($blocks as $block) {
        // very important fix. Fixes lost blocks in flexipage and front page format
        // renumbers the duplicate weights in order...
        while (array_key_exists($block->weight, $arr[$block->position])){
            $block->weight++;
            update_record('block_instance', $block);
        }
        $arr[$block->position][$block->weight] = $block;
    }
    return $arr;
}

Maybe it has something to do with the error you're experimenting. It fixed all weird behaviour definitively in our instances. I'll seek for a tracker entry... may help.

Problem is that some block moves do not calculate correctly the weight of the landing block, and weight duplicates appear in database. This fix recalculates dynamically the weights of the blocks in the page so they are in correct order, and no one is forgotten. Beware : you may have some ghosts reviving !!

Cheers.