Adaptable Upgrade to 405.1.10

Adaptable Upgrade to 405.1.10

by Donna Smith -
Number of replies: 19

We are at Moodle 4.5+. Upgraded a couple of weeks ago and solved one problem but today found this:

  1. Front page user can no longer see available courses from Navigation block if you are not logged in. If you click on a course it briefly lets you see the course description them goes to login page.

I discovered how to fix one of the problems dealing with site pages but so far this still eludes me. 

Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

Not an Adaptable theme issue.

Kind regards,

Gareth
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
We have 5 Moodle sites, this is the only one that we upgraded the theme and it's the only one that does it. We have the same site in a test site that we also didn't upgrade the theme and it doesn't do it either. So it seems it is the theme. I'm going to upgrade the test site theme and see if your theory is correct. I'll let you know.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

In that case, screen shots would really help me to understand where exactly the problem is.

G
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
Ok, hoping I can upload a short video. Here is our site with the theme updated to the current version, where it skips the description and goes right to login screen when the course is clicked.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Donna Smith -
Here is the same site as a test site where the theme is not current and when you click on the course it shows the description but if you try to enter the course it goes to the login screen, as it should. Hope this explains the problem so I can fix it...maybe just a setting that has been changed but I haven't found it yet.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

In 'BD-themeupdated.mp4', on the front page you are expanding the 'Courses' into their categories, then clicking on the course name taking you to the login screen. In 'BD-themeNOT.mp4' you are clicking on 'Courses' which takes you to 'course/index.php', where the categories are then expanded on that page to show the course name summary etc. You are then clicking on the course name taking you to the login screen.

Therefore there is nothing for me to fix as the sequence of events is not the same in each screencast.

G
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
Thanks for trying to help...must be a setting I'm missing. I'll keep looking.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

Please don't waste your time looking for a setting. In one version where you think it is working, you're clicking on 'Courses' that is taking you to the 'course/index.php' page. On the other version where you think it is not working, you're expanding 'Courses', showing categories, then the courses themselves then clicking on the course name. There is no problem to solve from a code / setting point of view.

Kind regards,

Gareth
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
I think there is a problem so I made 2 more videos and was very careful to click the same way because there is a difference if you click on the arrow or the name. I'm clicking on the name. I don't think I'm crazy...but maybe I am.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Donna Smith -
Here's the 2nd site with the older theme...there is a difference as to where the clicks take you...why is there a difference?
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

Okay, I can see on the screencasts what is happening. I've also used the urls to test in a browser and can replicate on your site. However, re-examining the code between 405.1.7 and 405.1.10 (your old and new) I cannot see anything that would cause this - course/index.php is being redirected to the login page before you even click on anything (Was for me and your screencast hints at this even though there is a delay - hinting possibly at JS). I also cannot replicate locally. Therefore, to be sure it is the theme, change the new site to the core 'Classic' theme as that also uses the Navigation block.

Kind regards,

Gareth
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -

Here's the site using the Classic theme and it behaves as it should.

Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

I am completely and utterly stumped. Nothing I can see has changed in the theme code to cause it. I've looked at the JavaScript on your site with the issue and there is only one 'window.location.replace' and that I know about and won't be causing it - been there for ages. Nothing I can see in any other plugin JS wise. I've looked with the browser debugger tools with persistent logging to see if there is anything network wise, nothing.

The only thing I can suggest is to install a Moodle locally on your PC / Laptop with https://download.moodle.org/windows/ - install Adaptable and use the theme export / import JSON settings functionality to copy the settings of your site from one to another:

 
 
And see if you can replicate initially with just core Moodle and the theme (https://moodle.org/plugins/theme_adaptable/405.1.10/37065) - before and after importing the settings from your site.  If you can't, then progressively add back the other contributed plugins you have and see if any of them are causing the issue.
 
BTW, the current version at the time of typing is now: https://moodle.org/plugins/theme_adaptable/405.2.0/37358.
 
Kind regards,
 
Gareth
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
So changing to the Classic theme didn't help? It showed the site working correctly. We'll try your suggestion soon.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Gareth Barnard -
Picture of Core developers Picture of Particularly helpful Moodlers Picture of Plugin developers
Dear Donna,

Switching to the Classic theme proves that for some reason specific to your site that the issue happens in Adaptable.

What process do you follow / do in order to update Adaptable please?

Kind regards,

Gareth
Average of ratings: -
In reply to Gareth Barnard

Adaptable Upgrade to 405.1.10

by Donna Smith -
Sorry, we started our fall session of classes and are just now getting back to this. When we update the theme, we click 'Update' from the update screen for plugins... nothing unusual.
Average of ratings: -
In reply to Donna Smith

Adaptable Upgrade to 405.1.10

by Donna Smith -
We saw a new update for the theme came out today so we updated the theme and now everything works as it should. Thank you!
Average of ratings: -