Scheduler (plugin)

To correctly render both numbered grades and grading with scales, I have finally settled for the following, I reproduce lines 126 to 150 of the code in renderer.php, and have added bold to my changes:

$result = '';
if ($scaleid == 0 || is_null($grade) ) {
// Scheduler doesn't allow grading, or no grade entered.
if (!$short) {
$result = get_string('nograde');
}
} else {
// $grade = ( int) $grade; // Commented out, or rather moved to l. 143 - PK 2021-05-25
if ($scaleid > 0) {
// Numeric grade.
$grade = round($grade,2); // Added, PK 2021-05-25
$result .= $grade;
if (strlen($grade) > 0) {
$result .= '/' . $scaleid;
}
} else {
// Grade on scale.
$grade = ( int) $grade; // Added, or rather moved from l. 133 - PK 2021-05-25
if ($grade > 0) {
$levels = $this->get_scale_levels(-$scaleid);
if (array_key_exists($grade, $levels)) {
$result .= $levels[$grade];
}
}
}

This seems to work well, and I  may want to suggest it on the Tracker.

HOWEVER -  while comparing what Scheduler claims to be Gradebook's final grade outputs for the Teacher vs the Student , under such condtions:
- scales used for grading (e.g. Incompetent-Competent)
- mean aggregate selected for grading multiple appointments,

then

a combination of Competent + Not yet incompetent yields two different overall results :/ :
- Not yet competent - on the student's page ( /mod/scheduler/view.php?id=n - the value is taken from the Gradebook here, and I think this IS the correct interpretation)
- Competent on the Teacher's page (/mod//scheduler/view.php?what=viewstudent&id=... etc) - this calculation seems to be done within Scheduler, rather than taken from the Gradebook. which I think is understandable, but renders an incorrect result.

Anyway. this last discrepancy in aggregation reports seems like another bug to be squashed in Scheduler at some point.