FortAwesome does not render in headings

FortAwesome does not render in headings

由Visvanath Ratnaweera發表於
Number of replies: 9
Particularly helpful Moodlers的相片 Translators的相片
Moodle 3.5.6+ (Build: 20190614) Theme Classic theme_classic_moodle35_2018082000 and Boost 2018051400 (default in the core) As the various screen-shots demonstrate, FontAwesome renders in content but not in headings. Is it possible to get them also in the headings?
附件 farendering-collage.png
評比平均分數： -
In reply to Visvanath Ratnaweera

Re: FortAwesome does not render in headings

由Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片
That's not a core filter. So how can we reproduce if we don't know what it is?
評比平均分數： -
In reply to Visvanath Ratnaweera

Re: FortAwesome does not render in headings

由Adrian Perez Rodriguez發表於

On our platform it is working as expected, also with the less than character entity. Do you have the filter enabled in the "Course administration > Filter"?

Greets,
Adrian

附件 Fontawesome-as-heading.png
評比平均分數： -
In reply to Adrian Perez Rodriguez

Re: FortAwesome does not render in headings

由Visvanath Ratnaweera發表於
Particularly helpful Moodlers的相片 Translators的相片
Hi Adrian

Thanks a lot for the quick response! Under Site administration > Plugins > Filters > Manage filters > FontAwesome is set to Content and headings. Screen-shot attached.

I changed "Convert URLs into links and images" to Content (only) as a test. Didn't help.
附件 activefilter.png
評比平均分數： -
In reply to Visvanath Ratnaweera

Re: FortAwesome does not render in headings

由Adrian Perez Rodriguez發表於
These are the general settings, and they look correct. Only that we have at the "Convert URLs into links and images" set on "Content". But nevertheless, you must have enabled this filter in your course as well. Please check that.
評比平均分數： -
In reply to Adrian Perez Rodriguez

Re: FortAwesome does not render in headings

由Visvanath Ratnaweera發表於
Particularly helpful Moodlers的相片 Translators的相片
Yes, at course level it is the default. See screen-shot.

About "Convert URLs into links and images", as I already mentioned, 'I changed "Convert URLs into links and images" to Content (only) as a test. Didn't help.'
附件 filtersettingscourse.png
評比平均分數： -
In reply to Visvanath Ratnaweera

Re: FortAwesome does not render in headings

由Visvanath Ratnaweera發表於
Particularly helpful Moodlers的相片 Translators的相片
Found another missing piece: Site administration > Appearance > HTML settings > Remove HTML tags from all activity names (formatstringstriptag) was set, which was the default. Unticked and now FA icons also appear in headings.

It is still not satisfactory. Somehow the icon in the heading is "backspaced". See pic.
附件 twitter2.png
評比平均分數：Useful (1)
In reply to Visvanath Ratnaweera

Re: FortAwesome does not render in headings

由Adrian Perez Rodriguez發表於
Hello Visvanath

Thanks for your findings, you're absolutely right. I updated the documentation in the Moodle plugins repository.

The other problem is as I see, only when you are _not_ in edit mode. The difference is, that in edit mode the activityinstance-inner is wrapped in an <span> element. Without an own hack (probably CSS) or changes in Moodle core we can not offer you another solution.

Edit.
As I see it's because of these lines in Moodle core:
.section .activity .contentwithoutlink>a, .section .activity .activityinstance>a {
    display: block;
    text-indent: -31px;
    padding-left: 31px;
}

Unset both values would solve the problem. But I don't know why these CSS values are applied. It seems to me that it doesn't make a difference.

HTH,
Adrian
評比平均分數：Useful (1)
In reply to Adrian Perez Rodriguez

Re: FortAwesome does not render in headings

由Visvanath Ratnaweera發表於
Particularly helpful Moodlers的相片 Translators的相片
OK. For the others who are following, the activity name is properly formatted in edit mode. (Pic. attached).
附件 twitter2editmode.png
評比平均分數： -