Looks good. It looks like some of your code isn't following Moodle's coding style. If you're bringing it up to date you might want to run codechecker against your plugin.
If you are sharing your code on GitHub, you could also use moodle-plugin-ci to run a lot of automated checks with Travis.