moodle-bootswatches suddenly don't work

Re: moodle-bootswatches suddenly don't work

by Richard Oelmann -
Number of replies: 3
Picture of Core developers Picture of Plugin developers Picture of Testers

The boostswatches at https://github.com/roelmann/moodle-boostswatches have been updated with the relevant changes (as has the Waxed theme at https://github.com/roelmann/moodle-theme_waxed - will push it to the repository soon, but right now seems to be a major delay in getting these Boost themes approved- waxed and fordson both still waiting for approval - Seems a shame that with the desire to push Boost, that two of the new child themes built from it are waiting close on 50 days and still not approved, but at least they can both be reached from github).

A bit concerned that this will remove the font definitions that are pulled from that line, but not sure why its breaking.

I've tried adding the line as rawscss too and the import of the googleapi url breaks boost/waxed there as well - I'll keep investigating and if I can track it back to a boost/core bug I'll post it here and in tracker. In the meantime, the boostswatches should not break sites they are used for anymore.

In reply to Richard Oelmann

Re: moodle-bootswatches suddenly don't work

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

Surely Richard, the fact that the following line does not work...

$web-font-path: "https://fonts.googleapis.com/css?family=Lato:400,700,400italic" !default;
@import url($web-font-path);

...is because Boost theme does not have any association with it in any of it's layout files.

I found this link earlier this evening, which may or may not help with fixing this problem.

https://github.com/thomaspark/bootswatch/pull/516/files

Anyway I hope it helps?

Mary

In reply to Mary Evans

Re: moodle-bootswatches suddenly don't work

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

There wasn't (as far as I can see) anything in the layouts previously either, or from what I can see of the scss documentation any need to have - it's importing a css file into the css/scss. So not sure why there would need to be anything in the layout file?

It worked until I did a git pull on my Moodle when this was reported - ie no changes to the presets at that time, presumably no changes to the external googleapi css file but worked, did git pull of moodle master, stopped working.

I could probably manually create a fonts file in the theme and point the font-face (for each of the bootswatch presets) at that, but that doesn't solve the issue for anyone else adding a google font to their preset, or through raw scss.

I don't think that link applies Mary, because I was already using the latest version of the presets which has that patch already applied as its from 2015, so already using the amended version.

Something has changed in Boost/core but I can't see what (that's relevant), because the presets didn't change, but suddenly stopped working after an update of core moodle.

mixed

Thanks for looking! smile


R

In reply to Richard Oelmann

Re: moodle-bootswatches suddenly don't work

by Mary Evans -
Picture of Core developers Picture of Documentation writers Picture of Peer reviewers Picture of Plugin developers Picture of Testers

OK...I was thinking that the url was to add the fonts as well as the css. Usually this is done in the <head></head> tag of the layout, so I just assumed Boost was missing that...

Silly me!

LOL