Theme Elegance 2.9.0 for Moodle 2.9 release

Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Number of replies: 123
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

There is a new version of theme Elegance for Moodle 2.9 available on the plugins database

This version is a major rewrite of the Moodle 2.8 version by Danny Wahl and originally developed by Julian Ridden. If you are a theme elegance user and plan to upgrade please test it first because a lot has been changed! More info on the changes can be found here.

I have received some very valuable feedback from Emma Richardson already and welcome any other feedback / suggestions / bug reports.

Using this theme I hope to provide a nice and robust child theme with many customisable features for the bootstrap (version 3) theme.  In future release I will try and add more features that can enhance the user experience! 


評比平均分數:Useful (4)
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Cheers Bas, for keeping Elegance Alive and I am one of the very very few users of Elegance, just couldn't let this theme go off that easily, that is why kept myself on Moodle 2.7 (though older elegance did worked on 3.0 dev too) meanwhile only updating FontAwesome in theme fonts.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I think Elegance will make a huge rebound now that Bas has taken it over!  I think it only faded out due to lack of support.  Great theme!  I have it running on three sites.

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

What a coincidence, I am running (or planned) to run on 3 as well. Seems like users using it may be less, but practical implication is more. 微笑

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Well, we may not always agree on OS but we can agree on a great theme!! 眨眼

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Emma, from my side there has never been a disagreement over OS's, I never denied Linux as being better O/S for using Moodle. It's just that I had more expertise over using IIS despite ever since I started making use of hosting, it has always been on Linux, but a time will come I had to manage my own servers and that will put me at mercy of hosting admins setting up linux box for me, that is why (for the time being) re-routed myself towards Windows servers, besides there are many schools using Moodle on Windows plus many new users setup their boxes on Windows and IIS Express, so my knowledge wont go wasted 微笑

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

One small issue (or should'nt call it issue) as FrontPage Content in GENERAL settings was with HTML Editor in previous version, whilst this one only shows plain line to insert text, and entering text into that doesn't even shows up.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Ah yes, thanks Usman. Overlooked that one when rewriting all the settings 微笑

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

OK as I have started testing it on a test site and issues so far came out, besides FrontPage content now showing up. (please note if any of the issues arent showing up at your end, you can safely ignore them for I am using on a quick install, which itself brings loads of crap in moodle installation)

1: FontAwesome isn't upgraded to 4.4, where reference to cheat sheet includes new icons, using them doesn't show up while old ones do, means 4.3 is being used.

2: I tried disabling quick links, and they still showed up (rest marketing spots and slider works OK as far as disabling is concerned).


also one another (dunno weather its issue with theme), pull-left isnt working as it should in new elegance, see screen shots below


and when used in new theme, it doesnt work - have tried re-writing code still same issue



BTW thanks for adding two new options of adding more marketing spots and adjusting width, I was dying for these options. Theme just felt like more crisp and powerful.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

On first testing, I noticed different things in different browsers, so you might mention that too. 

I have replicated the Quick Links issue.  Hadn't thought to try disabling them again!!

Glad you are finding things that I hadn't noticed!  Also, Bas has a github for issues...

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Usman,

Thanks for testing 微笑

I have upgraded FontAwesome,

Fixed the enabling / disabling of quick links

Fixed the front page text


Not sure about the pull-left issue. The theme still supports it so I wonder what has changed. Could you post the HTML for the pull-left content you tried?


Thanks again!

評比平均分數:Useful (1)
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片
Thanks for a quick fix Bas!

The HTML I am using for pull left feature is
<i class="fa fa-film fa-3x fa-pull-left fa-border"></i> A long paragraph here to see pull effect in working.
Like I mentioned, I have installed theme on Script installed Moodle, so few things may not turn up as they are supposed to do, so if this issue doesn't replicates at your end then ignore it.

UPDATE: Soon after I pulled updated version from GitHub, the FontAwesome PULL-LEFT past started working fine too, so you can safely ignore it. I am assuming it was to do with updated FontAwesome.

P.S: I Have closed issues that I opened on GitHub.
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Header Background Image recommended size is set to 110px high, where header was not going anywhere in older Elegance version, for it was not showing on front page.

In new one header being part of front page, adding content to Front Page increases the height of the header clearly showing the split header image. As shown


Can you update tip beneath Header Background, making it larger than 110x, or remove header background from front page completely - What ever suits you.

Also text added to Front page Content inherits the color of the Theme, (although can be over ridden in HTML Editor), but I assumed changing text color will effect color of the text added to Front Page area as well.

Also a Suggestion, As may be older elegance was based on older version of Bootstrap, so hovering mouse over DEFAULT buttons were changing color to the theme's main color. Whilst in new one, though buttons are used default but hover changes them to light shade of grey - Though not an issue still, but for visibility purposes, can all SAVE and CANCEL buttons be changed into PRIMARY button type? - This is a suggestion. its just I had scrolled up and down finding the buttons to be apparently visible but they weren't in first instance so thought of getting button appearance changed.

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Thorough testing has brought another suggestion, I want to test as much of Elegance at this point where it didn't actually started rolling out to the production sites.

Can we remove the HEADER from front page all together? (I am backing it up with justification) Though there wasnt any place for uploading a larger logo in older elegance, but then there was a section besides marketing spots where site owners can upload  a bigger version of their site logo if someone wanted to using HTML block.

Now as front page is a course itself, so site name appears on header, where one wants to upload logo which in my case I dd using Front Page Content, the site name remains on top. Though course name in header looked very very cool as I browsed through courses, but on front page what If I want to show logo instead of site name. Screenshot below will make it more clear.


Now in older Elegance, adding anything to front page area shows up with theme color inherited as background color, can the course header be completely removed from front page with transparent background (inheriting the background of the theme)?


A Small Issue just noted: Enabling Marketing Spots now shows up ABOVE header area where header was suppose to show up above all.


Another Update (Apologies for bugging you so much): I just noticed in Theme Preview (Screenshot), Header is no where to be found on Front Page - Shown Below. Have  you accidentally or intentionally turned Header on for Front Page?


In All, if header showing up on front page is by mistake, you can safely ignore my above 2 posts and update the theme with no course header on front page, that will solve all issues from my side at least.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片
The header only shows up if you have Front Page content.  The front page content somehow becomes a header (or takes on the header qualities) when implemented.  I actually like the feature but would like to see it under the NavBar instead of under slideshow and Marketing spots.

Maybe it should actually be two different things - there should be an option for a header on the front page and a separate area for Front Page content which does not take on the header background/site name...
評比平均分數:Useful (1)
In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Emma, I must say that there is a mix up of few things. I have thoroughly tested this above all.

First things first: attaching screen shot of General Settings > Front page Content - See the highlighted area showing location appearing as highlight UNDER slideshow <--- this all together would have made perfect sense.


Now just to test what you said (The header only shows up if you have Front Page content. ) I deleted everything from Front Page Content. and Header area still shows up between Marketing Spots and QuickLinks. (See Below)



In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

You are correct - my bad.  I had put something in there when it wasn't working and then the header showed up when Bas "fixed" the front page content so I wrongly presumed that it was purely there because of the front page content I had added.  Do you have something in on his github?  If not, go ahead and add it there - I had more of a feature request regarding that but now I see it could be classified as a bug!

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

All three previous issues/enhancements I added to his GitHub were removed later as when I saw them solved. Now will add this one with reference link to this  form post.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Thanks for reporting this Usman

I simply changed that to be a plain box added underneath the banner as described in the settings, without much styling / background etc. This way its just an area you can use / style anyway you want!

Hope this helps

評比平均分數:Useful (1)
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Indeed this would help as this makes Elegance Unique for users can have control of Front Page Content.

Quick update did manage to get rid of header from front page, but we are kind of back to square one, where inputting text in front page content area doesn't show up on front page. Tried clearing theme caches and testing on 3 different browsers, same result.

Also, as I have just tested the slider, and height remains static at 250px, can you add as tip beneath the slider images to keep height at 250px so users will have idea of what size of images they should be using - on second thought, can slider be made flexible? I mean inheriting the image dimensions?

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Hi,

Thanks for taking this on and giving us a workable version for 2.9.

I'm testing it on Moodle 2.9  $release  = 2.9.2+ (Build: 20151023)

Installed OK but then got a strange Fatal Error with the elegance_renderer.php at Line 468.

I played about with the PHP removed the $content = ' '; and that appeared to let it work.

I have added it back since and it seems to be working OK.

Just one more query...where is the URL mentioned in this text in the General settings page for the theme?

"Simply copy the URL below and store it in the "mobilecssurl" setting 
under "Web Services -> Mobile".

Thanks

Mary

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Further to last comment:

This line is missing therefore will not show footer Debugging info.

        <?php echo $OUTPUT->standard_footer_html(); ?>

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Touché to that, had seen it while testing but forgot to mention, Thanks Mary!

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Derek Chirnside發表於
Just curious. 

What is the attraction with Elegance. 

With specifics. ??

-Derek

PS, OT.  Is anyone else having trouble getting email reply to Moodle.org forums to work?

In reply to Derek Chirnside

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Derek, this is a very very difficult question to answer - what is to love about Elegance.

I think, there are few themes which gives you the tools to be productive with visual elements where user have full control over how they can bring out their ideas from keeping the moodle look as simple as it can be to a wow effect, and Elegance and Essential (to my knowledge) are only two of the themes having these qualities. Means specially in these two themes you can turn everything off and no body can tell which theme they are, whilst you can use your productive ideas to make these two themes so much customized that one can't tell if it's a moodle site. for me they are like a Manual transmission, where user have full control over.

Where Essential remains the king of the hill (I am still holding essential for the later shebang) there are plenty other themes (specially emerging since 2013) Like we have Flexibase by Richard, Evolve-D & Pioneer by Chris, BCU, Square and plenty others to mention and yet I cannot still point out the unique things to love about Elegance, or may be Julian must have casted spell over it while developing - "Thou Shall Fall In Love With it, Once You Use it!".

Also regarding forum replies from e-mail - working for me.

P.S: Other Elegance lovers  may not fully agree! So rather I'll wait for their input too.

In reply to Derek Chirnside

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I agree with Usman - it has some magical charm about it.  Elegance is true to its name - simple, clean and elegant.  In Julian's original release, it includes course tiles and some very cool hover effects which I miss in the later versions but understand that there are issues with both.  (I have since customized a course format to bring back tiles - I need to update it but once I do that, I will push out to the community).

I think the idea of making Moodle less Moodly is what we tend to love about themes.  I myself find Essential too busy but do like some of the new themes.  When Danny left I was starting to look for new themes as I am running Elegance on three sites currently so was extremely happy when Bas took it over and even let me bug him with a wish list!

評比平均分數:Useful (2)
In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Derek Chirnside發表於

94 (now 95) posts in this thread - any more reasons you like Elegance?  Besides it casting spells and being magical?

-Derek

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Thanks for you feedback Mary!


I have updated the settings page to include the link for the mobile css,

Added the $OUTPUT->standard_footer_html();

Fixed the error on install by adding 

if (!during_initial_install()) {

     $usermenu = $OUTPUT->user_menu();

      ....

}

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Thanks Bas,

Can you explain what the elegance_renderer.php does...its classed as a widget, It was late last night when I was testing Elegance and now I am not able to work on my PC as am away from home...so just so very curious what that function actually does?

Cheers

Mary

PS I was thinking of making a Lite version of Elegance, based off More theme to see how it looked?

Have you any objections?

Mary

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Mary,

The elegance renderer takes care of rendering all the custom Elegance specific features like the slideshows, marketing spots, quick links etc. 

For each of these features it;

  • gets the configured values for the theme settings
  • loads the associated mustache template from the templates folder
  • inserts the combined settings in the mustache templates
  • returns the output

Feel free to use this theme in any way you like, it's GPL anyway..

I think the 2.9 version of this theme is already a Lite version compared to the 2.8 version, it is based on the Bootstrap theme so you will need to rewrite the Bootstrap 3 classes to Bootstrap 2 if you want to base it of the More theme.

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Stephen Bourget發表於
Core developers的相片 Plugin developers的相片 Testers的相片

Bas,

Thanks for working on improving the elegance theme.  I was testing it on my Moodle 2.9.2 (20151028) site and found a few small things:

1. The following notices are displayed due to strings that were removed from core but are used in the elegance theme.

Invalid get_string() identifier: 'unreadnewnotification' or component 'message'. Perhaps you are missing $string['unreadnewnotification'] = ''; in lang/en/message.php?
  • line 349 of \lib\classes\string_manager_standard.php: call to debugging()
  • line 6681 of \lib\moodlelib.php: call to core_string_manager_standard->get_string()
  • line 514 of \theme\elegance\renderers\elegance_renderer.php: call to get_string()
  • line 487 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->process_message()
  • line 428 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->get_user_messages()
  • line 378 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->message_menu()
  • line 88 of \theme\elegance\layout\default.php: call to theme_elegance_widgets_renderer->navbar()
  • line 1015 of \lib\outputrenderers.php: call to include()
  • line 945 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
  • line 164 of \my\index.php: call to core_renderer->header()
Invalid get_string() identifier: 'unreadnewnotification' or component 'message'. Perhaps you are missing $string['unreadnewnotification'] = ''; in lang/en/message.php?
  • line 349 of \lib\classes\string_manager_standard.php: call to debugging()
  • line 6681 of \lib\moodlelib.php: call to core_string_manager_standard->get_string()
  • line 514 of \theme\elegance\renderers\elegance_renderer.php: call to get_string()
  • line 487 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->process_message()
  • line 428 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->get_user_messages()
  • line 378 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->message_menu()
  • line 88 of \theme\elegance\layout\default.php: call to theme_elegance_widgets_renderer->navbar()
  • line 1015 of \lib\outputrenderers.php: call to include()
  • line 945 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
  • line 164 of \my\index.php: call to core_renderer->header()
Invalid get_string() identifier: 'unreadnewnotification' or component 'message'. Perhaps you are missing $string['unreadnewnotification'] = ''; in lang/en/message.php?
  • line 349 of \lib\classes\string_manager_standard.php: call to debugging()
  • line 6681 of \lib\moodlelib.php: call to core_string_manager_standard->get_string()
  • line 514 of \theme\elegance\renderers\elegance_renderer.php: call to get_string()
  • line 487 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->process_message()
  • line 428 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->get_user_messages()
  • line 378 of \theme\elegance\renderers\elegance_renderer.php: call to theme_elegance_widgets_renderer->message_menu()
  • line 88 of \theme\elegance\layout\default.php: call to theme_elegance_widgets_renderer->navbar()
  • line 1015 of \lib\outputrenderers.php: call to include()
  • line 945 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
  • line 164 of \my\index.php: call to core_renderer->header()

2. I get a fatal error when switching to the elegance theme:

Fatal error: Call to protected method theme_bootstrapbase_core_renderer::render_custom_menu_item() from context 'theme_elegance_widgets_renderer' in C:\web\sites\Moodle\moodle29\theme\elegance\renderers\elegance_renderer.php on line 471

3. The page background seems to stretch when expanding the administration tree.  I found that adding this css rule seems to fix it:

#page-content-wrapper { background-attachment:fixed; background-size:auto}

4. Not directly related to Moodle 2.9 but when I applied it to my Moodle 3.0 beta test site most of the upgrade screens were unreadable due to the text being super-imposed onto the page background without the benefit of the white background (See the attached screenshot)

附件 M3-upgrade.jpg
In reply to Stephen Bourget

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

looks like you fixed these in the github pull request! Thanks.

I have not started testing on Moodle 3 yet. I guess most of the work for Moodle 3 will affect the bootstrap theme. Guess I will just have to compare bootstrapbase versions to find all the new css.

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Hi Bas,

I've done similar things in the past to maintain Shoehorn, but found that some bits were not actually needed, like between M2.8 and M2.9 there was a new header, which I chose not to implement as I did not like it.  Plus some bootstrapbase code works well in clean but not in other themes.  More of a pick and mix to see what works and what does not work.  I've not looked at the M3.0 changes yet though.  I've still of a mind to create a theme with only the BS  CSS / LESS / SASS, the plugin styles (which get included anyway) and then build the theme 'moodle' bit up as needed and discover how much of the CSS is 'really' required, but that's a pipe dream at the moment.

Cheers,

Gareth

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Stephen Bourget發表於
Core developers的相片 Plugin developers的相片 Testers的相片

Bas,

I was able to fix issues #1 and #3, but haven't been able to sort out how to fix the fatal error triggered in #2. (I can trigger it reliably simply switching from any theme to elegance by using the theme selector).

As I play with the theme, I found a few other small items:

#5 The transparency option doesn't seem to work.  The background for blocks and content always seems to be solid.

#6 In the 2.7 release (running on Moodle 2.9.2), the navigation bar (breadcrumb) was displayed inside of the header (on the white background) in 2.9 release it is displayed underneath.  Is this intentional?  (As it makes it harder to read when a background image is applied)   I've included screenshots below.


#7 The v2.7 release had a configuration option that allowed us to add a copyright statement to the footer of each page.  It looks like that feature was lost during the rewrite. Any chance that feature could be restored?

Thanks for all your great work on improving the elegance theme!

-Steve

In reply to Stephen Bourget

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

I can confirm for transparency not working, as I had noticed earlier but thinking that I don't have any background applied so may not be showing through.

for Navigation, The new idea looks cool for displaying course name on header, but I totally overlooked the possibility of applying a dark background hence making them unreadable, can we apply independent white background strip to navigation while keeping course names in header, or any possibility of keeping both in header?

For Copyright link, I ignored it thinking that can be manually added to the footnote, or if adjustments are required in footnote as it was showing 2 different color strips, one can always come back to it later.


In reply to Stephen Bourget

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Thanks for reporting this!

I moved the breadcrumb underneath the header and I think it looks a lot better there, at least if you do not use a page background image. So as a solution I have added a white background when a body background is present. 

You can still add a copyright statement but it's not a custom setting. Use the Footnote are to add any custom text including copyright.

I have re-enabled the transparency on content. I think it needs to be used carefully because it can make texts quite hard to read.

I have implemented a new feature for the background images. You can choose if you want it to use the background as a tile (a repeating image), as a scrolling full page image or a fixed full page image. Personally I think using a tile is the best option when using a light and subtle background tile.

See this example


In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Stephen Bourget發表於
Core developers的相片 Plugin developers的相片 Testers的相片

Bas,

Thanks for the fixes, I almost have my test site looking like my production using elegance 2.9.  I just have a couple more questions:

1. The older version of the elegance theme had rounded corners on blocks and the content areas.  Is there any chance that could be restored?  I think the rounded edges help make my site look more modern.

2.  I had a local hack that added links to the download page for the mobile app next to the social media links in the bottom of each page .  I've submitted the patch as a pull request if this feature is something you would consider including in an upcoming release.

-Steve

In reply to Stephen Bourget

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Thanks for adding those Mobile icons. They look very nice. I have merged your pull request and will upload a new version to the plugin database tomorrow.

I am going to try and get the early 3.0 bird award for this plugin 微笑 

See https://moodle.org/mod/forum/discuss.php?d=322172

In order for it to be ready for 3.0. So anybody willing to try and get it ready for 3.0 will be added to the theme credits, and if your are added already I WILL CHANGE IT TO FULL CAPS!! 微笑

That said, I am already very happy with all the responses I got here!



In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Cheers Bas,

One more thing, since you've removed Header from front page, the content added to Front Page area stopped showing up again. anxiously waiting for that fix.

Thanks

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

working on latest github release...

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

微笑

Looking at iMoot's websites for since 2011, Elegance stands out well, and other plus is rendering time is quickest for I have tested today with PHP 7, looks like Moodle just got turbo installed.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

RE: "rendering time is quickest for I have tested today with PHP 7, looks like Moodle just got turbo installed" - same thing happens when you go back to Moodle 1.9.

In reply to Gareth J Barnard

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Derek Chirnside發表於

I know what you mean Gareth.  But my Mum sometimes talks fondly about the old days.  She forgets the lack of fridges, Panadol, McDonalds, dishwashers and cell phones.

-Derek

In reply to Gareth J Barnard

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Indeed 1.9 was light as I taught whole MBA course on a shared server and 300 concurrent students rushing to submit assignments at last minute yet bluehost's shared server never coughed.

But then, No Essential, Elegance, Bootstrap, Flexibase, Evolve-D and many more to be seen there. I believe it was Essential that brought in whole lot of ideas to theme developers else the only colorful theme was Aadvark that time.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

As long as we are reminiscing, let's not forget Rocket - another of Julian's non-moodly themes!  I believe Elegance actually predated Essential..I could be wrong though..it does happen!

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

For me, especially in Shoehorn the ideas I have put in it have come from needs I've identified as requiring, pick and mix from other things and Wordpress.  Mutant Banjo was a stand alone experiment.  Shoelace is Clean but with colour and a few little extras.  Campus is a super-charged child of Shoelace.  Essential now has elements of the BCU theme, which I believe has elements of Essential.  Essential also fully implements the RTL / LTR switching I first prototyped in Shoehorn.  It also has fixes from my early themes I helped Julian with when he was developing it.

Open Source is therefore like a virus, everything gets infected ;).

In reply to Gareth J Barnard

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Richard Oelmann發表於
Core developers的相片 Plugin developers的相片 Testers的相片

Likewise, I have taken bits of Essential, Elegance, BCU, and others to create flexibase (along with bits of my own). I can also trace bits of my original flexi themes into the history of some of the current themes - as well as 100% acknowledging the work of Shaun, Danny and Mary that helped me create those earlier themes (built on the likes of Aardvark, Zebra, Cafe-Lite etc etc).

The open source community - and Moodle in particular (I would say especially with regard to themes, but then that's the area I'm most involved in)- is a thriving example of sharing good practice, mutual learning and development, the key to which (I feel) is the mutual respect and acknowledgement of everyone else's work that we use and reuse and learn from every day 微笑

I have to say this is a HUGE difference to some of the other work I do and deal with - with another big HE learning environment and various tools, as well as the attitude around several IT departments and companies I have worked with and spoken to over the last few years (not only as part of my day job). Coming back to share (or even just read through and see other people sharing) with the Moodle community after a day dealing with issues around closed source **** (self-censored!) can be a great tonic for the day!

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Just pulled latest update from GitHub, Front Page fixed - Yayyyyyy

another small issue arose - Performance Info now is trimmed  from top, as shown

Though not an issue effecting end user, but because I am side-by-side doing testings of Moodle on PHP 7, so really means to me for performance figures.


Also, can the Front Page content border be aligned to the logo (above) and marketing spots border (below) as shown.


or is it intentional ?

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Just upgraded moodle to 3.0, so far so good, all tests went as they were on 2.9, except a small (and weird) thing - but this issue was with previous Elegance as well and not breaking anything for me to worry about - though wasnt in Julian's version also in Bas's version it wasnt on Moodle 2.9, but appeared on 3.0.

Others may not be able to replicate that as this only happens on FireFox (Chrome, Safari, Opera, IE all works fine) and even on FireFox it only happens when used on 1280 pixels wide screen, rest I have used it on wider screens even reducing the size of window to 1280 and this doesnt happens on FF there even.

Issue (or not issue) is rough edges of Fonts and FontAwesome icons, as I have attached clip above, so attaching same clip again this time on Moodle 3.0

Notice slightly rough edges of Fonts, my current elegance (previous version) is running with same thing on Production Moodle 2.7.


or additional clip here



Also regarding the "performance info" in footer (mentioned in previous post)

1: if no footnote is used, then it trims first 3-4 lines as showed in above post

2: if, social icons are enabled, then it only trims one line (as shown)


3: If footnote is extended beyond social media icons, then it shows full (as shown)

May be something to do with overlap 微笑

and lastly,

Transparency works fine now, but visited links tends to fade into the background, can the background for navigation be kept solid (unaffected by transparency) or some other alternative.


In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I have also discovered that if you dock the Admin block and have a fixed navbar, in Chrome (not firefox), when you expand the admin settings menu, the block will expand towards the top of the page and hide the title bar behind the navbar.  In Firefox it also expands upwards but stays on top of the navbar.  Github issue added.

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

I seem to remember this as a BUG in Moodle...not sure if it was fixed or not now?

Gareth might remember?

Cheers

Mary

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

another small issue. or may be this was from start and no one bothered as I just happen to use a darker background just for test and it showed up.

When using dark colored backgrounds, and on installing plug-ins, the initial plug-in settings font becomes hard to read, as shown

I personally don't intend to use dark backgrounds, its just being tested as someone may. or a Tip can be added to background Upload area, as plug-in settings can always be opened later.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Stephen Bourget發表於
Core developers的相片 Plugin developers的相片 Testers的相片

I found the same thing, it looks like the Installer re-write in MDL-49329 made some significant changes to the styling of the install and upgrade screens.  I found that the system check (which I posted earlier), the new plugin screen, and the upgrade progress screen were all in need of some CSS fixes.  Many of which seem to be missing the backgrounds for the headers and even-numbered rows.

(Not sure if this helps but here are the list of changes to bootstrapbase specifically around the plugin installation screens (https://github.com/moodle/moodle/commits/master/theme/bootstrapbase/less/moodle/admin.less)

Other than that the theme is looking pretty good on Moodle 3.0, Although I'm still getting that weird fatal error if I try switching themes using the theme selector.

(fatal error: Call to protected method theme_bootstrapbase_core_renderer::render_custom_menu_item() from context 'theme_elegance_widgets_renderer' in /Applications/MAMP/htdocs/moodle29/theme/elegance/renderers/elegance_renderer.php on line 476)

In reply to Stephen Bourget

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Stephen,

I added the new CSS for the update / plugins screens in the parent Bootstrap theme for Moodle 3.0 which I just released on the Moodle plugin database.

The error you see is weird! It refers to to theme_bootstrapbase which elegance should inherit from theme_bootstrap. So perhaps it's a core bug, but I will see if there is anything I can do to debug it.



In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Usman

Thanks for reporting!

Would you mind adding the issues on Github in future? On the Moodle forums it is hard to keep track of things reported, and I am afraid I will be missing / forgetting about them if just posted here.

I have already added the one for the Jaggy edged fonts and footer. The padding on the frontpage text will be removed, so no need for a github issue.

I think setting the transparency very high with a dark / very busy background looks bad indeed. Not just on the breadcrumb but on all places that show text. I also think the ones that will configure the theme should be given the freedom to make it look as good or bad as they want to 微笑 So I would rather just keep it this way. I did add a class to the breadcrumb container that allows you to add custom css to force the background color to white.

Just add

.breadcrumbcontainer {

    background-color: #FFF !important;

}



In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Cheers Bas,

I couldn't find the image insert option on GitHub (or may have overlooked) , that is why kept on posting here despite I had entered issues there before later to remove myself as when they were resolved.

rest assured I will be adding issues there, which may not be needed as looks like all major issues got resolved already. 眨眼

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

I know it must be good to find Moodle works  with PHP7 however it is not a pre requisite of this theme or Moodle, so I think you might be better using the Php version required to test Elegance fairly.

Thanks

Mary

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

That was a quick test Mary, not that I am permanently using for test beds as PHP 7 is still in RC version, so error generation possibility is still there. All themes are tested on stable versions of PHP. 

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Nadirshah Ferozepurwalla發表於

As requested by you, i am posting the question here

Hello,

I am trying to install the elegance theme, but receive the following error,

This error appears on localhost, and also on hostgator online hosting.

I have been searching the net for the last 3 days but cannot find any solution to this error.

Please help thankyou


The error,

Fatal error: Call to protected method theme_bootstrap_core_renderer::render_custom_menu_item() from context 'theme_elegance_widgets_renderer' in /home4/ab10213/public_html/hifi/theme/elegance/renderers/elegance_renderer.php on line 476


In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Do you have the latest bootstrap version too?

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Nadirshah Ferozepurwalla發表於

yes, 2.9 all bootstrap, elegance, moodle even then this error comes

I tried it on hostgator hosting, the theme gets installed and works! but the error appears right after installing theme.

Though i am not able to use certain functions of the theme

Such as,

The Slideshow images has link option, which doesnot get set, no matter the link.

It always points on mywebsite/0

??

In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Nadirshah Ferozepurwalla發表於

Theme : Elegance Version 2.9

I donot know where this post should be, but i spend 3 hours on correcting this mistake in the theme with very little coding experience, and severe lack of documentation in fact no documentation  sad


Hope this  helps other users  and saves their time


The homepage or the starting page of this theme displays slideshow but the links even if given within the settings, donot 


work, the links of the slideshow keep on redirecting to the same page.


And there is no setting to open the links in a new windows/tab!, this shows how to open the slideshow link in a new window/tab


Step1

theme/elegance/templates/banner.mustache


change

 <a class="btn" href="{{bannerurl}}">{{bannerlinktext}}</a>

To

 <a class="btn" href="{{bannerlinkurl}}"  target="_blank">{{bannerlinktext}}</a>




Step2

moodle/theme/elegance/renderers


After the lines

 $bannerlinktext = 'bannerlinktext' . $bannernumber;

            if (!empty($settings->$bannerlinktext)) {

                $banner->bannerlinktext = $settings->$bannerlinktext;

            } else {

                $banner->bannerlinktext = false;

            }


Add these lines


  $bannerlinkurl = 'bannerlinkurl' . $bannernumber;

            if (!empty($settings->$bannerlinkurl)) {

                $banner->bannerlinkurl = $settings->$bannerlinkurl;

            } else {

                $banner->bannerlinkurl = false;

            }


In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

RE: "severe lack of documentation in fact no documentation"

I feel I need to point out that Elegance is GPLv3: http://www.gnu.org/licenses/gpl-3.0.html - and thus there is no requirement in the licence to provide support or documentation.  Elegance itself for M2.9 has just been released through the hard work of Bas and the many others (including Emma and Usman) who have worked tirelessly over recent weeks to bring the theme up to date after Danny moved on to pastures new.

Therefore to complain about the lack of documentation is not really fair to the people who have put so much into the theme now and in the past.

評比平均分數:Useful (1)
In reply to Gareth J Barnard

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Well said Gareth!  That being said, his post did prompt me to look at the documentation and I plan to work on updating the help docs for Elegance in the next couple of weeks.  As soon as I get done with the Quick Guides for grading!!

評比平均分數:Useful (1)
In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Nadirshah Ferozepurwalla發表於

Quick guides for grading , where will it be posted? would be really useful

In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

The theme only changes the presentation and has limited capability, therefore the Moodle Doc's are your friend: Grades.

In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Actually the 3.0 docs will have a section of Quick Guides meant to just give the basics and be quick and easy to get started.  Glad you guys reminded me about docs - I really need to get those done!

In reply to Nadirshah Ferozepurwalla

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Try buying OEM vs Retail packaging of windows, you'll surely know the difference in price and documentation 眨眼 Or as a matter of fact, get any Retail packaging of enterprise grade linux (SuSE, Red Hat) vs downloading it for free from website. you wont be mentioning this concern here 眨眼

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Thank for re-igniting the Elegance theme.  Loved it then and love it now.


I promptly downloaded the 2.9 version and installed for a test.   Really do want to go back to this theme on our Prod box. A couple of things though:

a/ width of the slideshow.   Is there any way to set this to a fixed width and not have it stretch the images all the time.  This is very annoying and cosmetically ruins our site.

b/ horizontal scroll bars on html block next to marketing spots.   We try and put a small image in the space next to the marketing spots, and no matter what we put there, a scroll bar always appears - whether it is needed to not.  Again this cosmetically ruins our site.

Any ideas on how to fix these.   If we can fix these we will go back to Elegance on our prod site as it is just a magically theme.


Thanks


g



In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Are you sure you have the latest release - in the latest release there is no space next to the marketing spots - they span the whole page....

In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Graham, looks like you are refering to older (previous) version of the elegance theme, as in new one, the  slider adopts the width of the site, now you have freedom to adjust the width to your precise pixel.

secondly, where you referred to Horizontal bar appearing, again that was in previous version where HTML block was adjusted beside marketing spots, in new version marketing spots sit independently beneath Slider.

So if you want to use the new version, you can start using that, else if you want to keep on using the older version, then go to theme folder > style > elegance.css

find the line number 1506 and you'll find the code

#block-region-side-middle .block .content {

there, change the value overflow-y: auto (change auto to hidden)

save and flush theme caches.


again reminding, you are actually using older version as these issues you are referring to were in previous release, not new one.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Yep - I'm a goose.  I just checked and I'm running:


Elegance
theme_elegance
Additional 0.1.2 2.6.2 (Build: 20140321)

Next question though - why isn't our system picking up that there is an upgrade for this theme?  We are notified by moodle of updates to other plug-ins etc.  But this one didn't get notified to us.

Alternatively, can i rename the directory for the original and ftp the new one in and then run update and have all the old Elegance theme settings in place?

Thanks


graham


In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

What you need to do is...

  1. make sure you have a copy of the theme Elegance that is currently on your server, and stored in a safe place!
  2. next MANUALLY remove (DELETE) the Elegance theme from the server DO NOT UNINSTALL as this will wipe all your current settings from the database.
  3. now ADD (FTP) the latest Elegance theme to your server
  4. LOGIN and go to Site Administration > Notifications
  5. THIS SHOULD THEN START THE INSTALL PROCESS.

Hope that helps?

Cheers

Mary

評比平均分數:Useful (1)
In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Thanks Mary


All installed now and tweaking it.....very excited by elegance coming back 微笑



graham



評比平均分數:Useful (1)
In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Usman Asar發表於
Plugin developers的相片 Testers的相片

Regarding your auto upgrade notification, I am not sure if I am right to say, but new  version is dependent upon Bootstrap 3, whilst older was running on Bootstrap 2, where new version couldn't find dependencies being met so haven't given notification.

You may have to upgrade your Bootstrap to accommodate new Elegance as well, in fact you should do it meanwhile using new elegance.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Richard Oelmann發表於
Core developers的相片 Plugin developers的相片 Testers的相片

Elegance has always been Bootstrap3, although I believe it was only when Danny took it over that he changed it to depend on Bas' theme as a parent rather than being a standalone theme.

In reply to Usman Asar

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I think that if you do not install the original plugin through the web interface, you will not get upgrade notifications..not totally sure as I am running Elegance github version

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Hi all,

I've now got the current Elegance version running and all looks very good.  However one thing that is most important to us - the language selector menu seems to have disappeared from the top menu (the horizontal strip at the top of the screen).

we have the option selected to show the language selection menu in the language setting but it doesn't appear in the top menu.   Any ideas?



thanks


graham

In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Good catch - I will add that to the github issue reports.  Bas has been pretty good about getting things fixed.

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Thanks for reporting this Graham! and thanks Emma for adding it as an issue on Github! 

I have added the language menu back in.

For everybody reporting issues / problems using this theme you can also post your issue description here:

https://github.com/bmbrands/moodle-theme_elegance/issues

That way I won't loose track of issues reported and can ask for more information if needed. When reporting an issue on Github you can easily drag screenshots into the issue description window.

If you're note comfortable using Github it's ok to post them in this forum discussion 微笑




In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Good morning all,

I'm trying to change the background colour in the footer by adding the following in the custom css field:


#page-footer {

    background-color: #27282a;

    border-top: 2px solid rgba(240,255,255,.2) !important;

}


but doesn't seem to be working.   Is my syntax ok?


Thanks



graham


In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Try this:

.page-footer-inner{

    background-color: #27282a;

    border-top: 2px solid rgba(240,255,255,.2) !important;

}


評比平均分數:Useful (1)
In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Thanks Emma - that works.



graham


In reply to graham green

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Larry Turner發表於

Hello,

I just wanted to say I love the theme you have here.  I'm currently modifying the theme to cater our college, but I'm trying to find the location to enable the custom login.  I added the background picture, but it won't load.  It seems I'm missing an important piece to this puzzle.  Any assistance would be appreciated.  Thanks


In reply to Larry Turner

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Larry,

What's the URL of your Moodle site? I could have a look and try and figure out what's wrong.

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Larry Turner發表於

Hello Bas,

Thank you for responding.  Here's our sandbox:  http://online.carolinascollege.edu/sandbox/.

Thanks again.

Larry

In reply to Larry Turner

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi Larry,

I had a quick look and it looks like your theme is missing a file.

Could you check if the file /theme/elegance/ajax/themesettings.php exists ?



In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Larry Turner發表於

Hello Bas,

I just checked and I do have that file in the folder.  I just reloaded the theme just to make sure all files are there as well.  Not sure why it isn't working correctly.  Any other suggestions?

In reply to Larry Turner

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Do you get any apache / php logs? If the file is there it looks like it can not be accessed. Perhaps there is a permissions issue?

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Hi All,

Thanks so much for helping test, improve and motivate me working on the Elegance theme. Today I released the stable version for Moodle 2.9 and Moodle 3.0 so hopefully it will get some sort of award on the plugins database.

But really the award goes out to all of you participating on this! 

My plans are to keep this theme stable and up to date and to add features suggested by you and things I might find useful. In any case I want to make sure this is a community theme and include all of you on decisions on any major changes.

So feel free to use / change / hack this theme and suggest cool / useful or just fun ideas to improve it.

Thanks again!

評比平均分數:Useful (1)
In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

graham green發表於

Thanks Bas and to others for the great update on a great theme.

We have now put Elegance back on our Production box and still tweaking it but are very happy on it.  It is good to be using this theme again.

If it were in my power, you'd be receiving an award for your work on Elegance.


Thanks


Graham





In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Bas, 

Thank you for an excellent theme. 

Quick Q - is there some way to resolve the repeated banner on the carousel? This the emulation for iPad attached, but on iPhone 6 too the image repeats three times.

[Moodle 3.0 | 2015111500]



In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Hi,

I think this happens when the height of the image is smaller than the pre-defined height of the area itis covering so by default of the background-repeat property, it will repeat assuming that the carousel is using the uploaded image as a background-image via CSS.

A quick fix in this case is to add :

background-repeat: no-repeat;

to the CSS style where the original css is added inline.

It looks to be missing from the mark-up for the carousel. So needs to be reported to Bas as a BUG.

https://github.com/bmbrands/moodle-theme_elegance/blob/master/templates/banner.mustache#L11

Cheers

Mary

In reply to Mary Evans

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Mary, 

You're a superstar. Thank you, banner.mustache#L11 was where I added no-repeat and it's worked a charm. I've not got a Github, I hope Bas sees this and adds the bug - my Github account is no longer unfortunately.  

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Folks, it would appear something has broken with my elegance installation. Earlier I was receiving 500 errors at theme/jquery.php/theme_elegance/elegance.js resulting in a 'text only' version loading. 

I've now amended all the file permissions for elegance and bootstrap to ensure it's not a fine permissions error on the shared hosting. After doing that I now receive a service unavailable at the same address. 

Removing and reinstalling without using the Moodle Installer has no effect. Any suggestions? 

M3.0.2 and the Elegance version from the plugins database is what I'm working with.

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

What changed before it broke? 

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Hi Emma, 

I updated Moodle to 3.0.2 along with the latest Elegance theme from the Moodle Plugin DB. 

I'm back to Failed to load resource: the server responded with a status of 500 (Internal Server Error) at /theme/styles.php/elegance/1452581979/all

Really appreciate the help, would hate to see myself having to migrate to a new theme.

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I presume that you updated bootstrap too?

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Quick update: I contacted the service provider and it would appear that my installation is runs out of resources when using the Elegance theme on M3.0.2. Other themes load fine.

The site is on shared hosting while I tinker with things so it's not a train smash.

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Bas Brands發表於
Core developers的相片 Peer reviewers的相片 Plugin developers的相片 Plugins guardians的相片 Testers的相片

Oh that's weird. I guess the most resource intensive is the creation of the CSS files through phpless. Please let me know if you receive any more info on this issue.

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Gareth J Barnard發表於
Core developers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

When you get 500 errors and it is clear that the 'all' file has not been generated, look in the php.log file.

In reply to Gareth J Barnard

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Gareth, the PHP logs do not show anything (I'm investigating why not, seems wrong). 

Developer Tools shows /theme/styles.php/elegance/1452581979/all fails to load.

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

You might try reinstalling the Elegance theme.  I would delete the folder from the server first and then manually download a fresh copy.  Perhaps something went wrong in the installation.

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

James Hamilton發表於

Sadness. 

Uninstalled from web, removed folder. Download new elegance from plugin DB. Extracted to /themes reinstalled from Notifications. No joy.

I can't believe that this theme would require such substantially higher resources to generate /all. 

I'm no closer to finding a solution, shy of upping the server capacity which i'm not even convinced would work.

James

EDIT: I've just tried on a brand new Moodle install as a subdomain, still no luck.

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

I am confused by this so I pulled up my developer tools and ran some pages, even pages I have been seeing some issues with but no error with the elegance theme and less is loading correctly.  Have you checked the permissions on the folder - I wonder if something is going wrong with permissions due to your host

This isn't one of those host moodle installer packages is it?  Are you installing moodle manually?

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Hello again James,

Have you turned Debugging on? If not then do so as this could be caused by something unrelated to the Elegance theme. Debugging needs to be set to DEVELOPER mode.

Site Administration > Development > Debugging

Cheers

Mary

In reply to James Hamilton

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Hi,

Further to my last comment, is your website the 'outshine' site the one you are having problems with? If so then turn OFF Theme Designer Mode if set and then Purge all cache as the LESS files are not being generated.

This can happen if you make changes to the less files make a mistake. That's enough to break it.

Mary

In reply to Bas Brands

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Martin Woolley發表於
Has anybody else experience problems switching roles when using the Elegance theme? When our teachers click on the "Switch role to..." drop down, nothing happens, that is the roles drop down doesn't open. If I switch to a different theme, then the drop down does work correct.

Further, although unconfirmed, the drop down in Elegance works first time they enter a course, but after that it refuses to work for the rest of the day.

Thanks!


In reply to Martin Woolley

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Emma Richardson發表於
Documentation writers的相片 Particularly helpful Moodlers的相片 Plugin developers的相片

Have you tried upgrading?  Sounds like a bug.  The theme has been rewritten since then and I have not seen the issue in later versions.  

In reply to Emma Richardson

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Martin Woolley發表於

We are running version 2016081500 which I believe is the lastest.

In reply to Martin Woolley

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Mary Evans發表於

Hi...this sounds like a JavaScript conflict.

Moodle switched from using JavaScript to allow jQuery in the Bootstrapbase themes, so it may be that Elegance is still using the old Moodle bootstrap.js for the dropdown menu?

You will not see this behaviour in Clean theme as that will be using jQuery in the menu.

Have you checked to see if there is a block plugin on that page, if so then that could well be the problem?

This is just guess work based on problems I have experienced with some blocks or mods and themes in the past.

Hope this helps?

Mary

In reply to Martin Woolley

Re: Theme Elegance 2.9.0 for Moodle 2.9 release

Martin Woolley發表於

We are fairly satisfied that this is a bug. It seems random - some courses allow us to change roles, while on others it won't. We've put the following bodge into the custom css to force the drop down to always be open. It's makes the pages look a bit messy, but at least the change role function is available.


.block_settings .block_tree [aria-hidden="true"] {
    display: block;
}