Hi,
Thank you for your reply.
Now I attached 2 screenshots for your reference.
The 1st screenshot is from my built moodle site (v2.8) using a theme called "Morecandy".
The 2nd screenshot is from a moodle site of an institute and my friend have a teacher account.
Thanks again.
(Edited by Mary Cooch to clarify title - original submission Sunday, 2 August 2015, 3:04 AM)
Hi,
Thank you for providing the screenshots. To know the reason for this issue, would you please provide the html markup generating by moodle for activity rows. Here is my system html markup for assignment activity row. Are you getting icon url in the html markup?
(Edited by Mary Cooch to clarify title - original submission Monday, 3 August 2015, 8:57 AM)
For some reason I can only see the old style drop-down menus and not the Pop-up menu as seen in the screenshot above.
Can someone enlighten me on where to find the Add Activity/Resource setting in order that I can reverse the changes I made to my Moodle site when setting up 2.9 a few weeks ago? I remember testing it out but cannot think where it is now?
Thanks
Mary
It's in Site Administration > Appearance > Ajax and Javascript Mary
Or type 'Activity Chooser' into the settings search box at the bottom of the Administration block
Hi,
Thank you for your reply.
My moodle site is shown as below screenshot.
Thanks a lot.
Are the screenshots you have provided on the same Moodle but with a different theme or are they a different Moodle.
If they are a different Moodle, could you please test the same Moodle with a different theme (Clean or More) and confirm whether you can see the icons then.
Thanks
Richard
Thank you for your reply.
I have tried to change to another theme in my moodle site and I can see the icons.
Thanks a lot.
Hi,
The problem is in the morecandy/classes/core_renderer.php
You need to remove the following lines:
https://github.com/lazydaisy/moodle-theme_morecandy/blob/master/classes/core_renderer.php#L493-L541
I was experimenting and got it wrong, I need to rethink this...or Moodle HQ need to stop adding icons in with JavaScript!
Sorry for the inconvenience.
Mary
Hi,
Thank you for your reply.
The file "core_renderer.php" cannot be found only in C:\xampp\htdocs\moodle\theme\morecandy\renderers\ but there is no such line of code in the file.
Thanks a lot.
Hi, I forgot you are using the 2.8 version which has a renderers directory, where you will find the core_renderer.php
I was testing this last night and find that things were breaking in other places that otherwise were working OK with the renderer.
So frustrating with things like this. I'm going to see if I can mend it another way.
If you leave the core_renderer.php as it is you only lose the icons that are added via JavaScript and so if you can put up with those few missing icons for the moment, it is safer for the theme if nothing is changed, until I can get a better fix for this.
Again sorry for the inconvenience!
Mary
Hi,
Thank you for your reply and help.
I have added a logo and changes some CSS (mainly related to colors) in theme setting and it will be better for my boss and those users if activity icons can be shown (but not compulsory).
Look forward to your progress.
Thanks again.
There is a bigger problem now and it is all to do with the core_renderer.
As a result I have withdrawn the theme until I find a better fix.
So sorry.
Mary
Hi,
I have upgraded to version 2.9+ for some other reason, and would like to hear any news from you about your theme.
Thank you very much.
Hi,
There was a security issue with the renderer I had added so now that I have removed that it should be ok, the only draw back is that the FontAwesome icons that replaced the images in the side blocks have also gone too.
That said I will ask help on this as there should be a better solution than removing renderer.
Can you send me your email address and I'll try and get you a copy of the updated version for 2.9
Thanks
Mary
