Grid Format > Large space at top of screen

Grid Format > Large space at top of screen

Dan Jeffries -
回帖数:9

Hi

I am using Grid Format (not for the first time!) with a client but have noticed on this install a large gap at the top of the screen. I have tested it with 3 different themes (see images below).

I have used Grid on a different site with Gourmet and it looks fine.

Any ideas?

Thanks!

d

附件 Screen Shot 2014-09-18 at 11.06.30.png
附件 Screen Shot 2014-09-18 at 11.07.21.png
回复Dan Jeffries

Re: Grid Format > Large space at top of screen

Dan Jeffries -

Gourmet theme

附件 Screen Shot 2014-09-18 at 11.08.26.png
回复Dan Jeffries

Re: Grid Format > Large space at top of screen

Richard Oelmann -
Core developers的头像 Particularly helpful Moodlers的头像 Plugin developers的头像 Testers的头像

Not sure what you are referring to Dan,

You are commenting on the 'large' gap at the top of the screen but saying it looks fine on Gourmet, and yet on those screenshots, the gap at the top looks far bigger on Gourmet than on the others?

For reference (and because I've just changed this on my own site for various enforced design issues relating to the custom theme): The top margin appears to be set within the module.js of the grid format (Note - all the usual advice about editing files and potential effects when later upgrading apply here!)

    /* This is added here as not editing and JS is on to move the content from
       below the grid icons and into the shade box. */
    var content = document.getElementById('gridshadebox_content');
    content.style.position = 'absolute';
    content.style.width = '90%';
    content.style.top = 'YOUR_NEW_VALUE_HEREpx';
    content.style.left = '5%';
    //content.style.marginLeft = '-400px';
    content.style.zIndex = '1';
};

回复Richard Oelmann

Re: Grid Format > Large space at top of screen

Dan Jeffries -

Many thanks - I'll take a look.

What I meant to say was, I have use the Gourmet theme on other sites with the Grid format and it looks fine.

d

回复Dan Jeffries

Re: Grid Format > Large space at top of screen

Dan Jeffries -

Hmm. Changed it to 5px and no joy :/

回复Dan Jeffries

Re: Grid Format > Large space at top of screen

Richard Oelmann -
Core developers的头像 Particularly helpful Moodlers的头像 Plugin developers的头像 Testers的头像

Purged caches?

Bear in mind theme designer mode may not be enough as this is in a js file, not cached css.

回复Richard Oelmann

Re: Grid Format > Large space at top of screen

Gareth J Barnard -
Core developers的头像 Particularly helpful Moodlers的头像 Plugin developers的头像

Hi Dan,

The gap is deliberate because of this: https://moodle.org/mod/forum/discuss.php?d=266192#p1152232.  It was a recent fix, so the other sites might be out of date.

Purge all caches will do diddley squat because its a JavaScript solution.

The Gourmet theme is not supported as its a paid for theme and therefore I cannot test against it.  With other contributed themes that I can download and install I will at least consider adapting for / helping out on.

Gareth

回复Gareth J Barnard

Re: Grid Format > Large space at top of screen

Richard Oelmann -
Core developers的头像 Particularly helpful Moodlers的头像 Plugin developers的头像 Testers的头像

'Purge all caches will do diddley squat because its a JavaScript solution.'

I'll bow to your greater experience with js Gareth - but just comment that when I did exactly the change I identified, it didn't work until I purged all caches on the Developer menu of Administration. Maybe coincidence then.