Hi...
New feature:
- Categories: An entry could belongs to zero or more categories.Thanks to Ger Tielelman for the idea!
Bugs fixed:
- If an entry is deleted, its attachment is also deleted.
Will
Hi, thanks for the fix to the guest searching, and the categories, they are great. I just replaced my glossary directory with the one from CVS, and the lang/en/glossary.php file.
I have updated the module, and everything works beautifully except when I log in now as guest I only see two of the 9 topics I should be seeing (funily enough number 0 and number 2). I see all 9 when admin or a registered user.
Any thoughts?
cheers
Mark
I have updated the module, and everything works beautifully except when I log in now as guest I only see two of the 9 topics I should be seeing (funily enough number 0 and number 2). I see all 9 when admin or a registered user.
Any thoughts?
cheers
Mark
Hi again,
I also noticed that deleteentry.php does not work for me. I get as far as the confirmation: ("Are you sure you want to delete it?", but when I click on Yes, I get a blank page apart from the header, and when I go back (the only way to get off the page), the offending glossary entry is still there...
cheers
mark
I also noticed that deleteentry.php does not work for me. I get as far as the confirmation: ("Are you sure you want to delete it?", but when I click on Yes, I get a blank page apart from the header, and when I go back (the only way to get off the page), the offending glossary entry is still there...
cheers
mark
I found the bug that caused this problem and it's solved (in cvs). However, the first bug (the one with the guest account) is still unsolved as I can't duplicate the error.
Would you mind to send me a copy of the course where you are having this problem? If you can't, perhaps if you create a temporal course and import only that glossary...
Thanks,
Will
Hi,
thanks for the first fix.
For the second problem, you can find the course at:
http://www.microstructure.uni-tuebingen.de/moodle/
if you want me to add you as a teacher, let me know.
thanks
mark
thanks for the first fix.
For the second problem, you can find the course at:
http://www.microstructure.uni-tuebingen.de/moodle/
if you want me to add you as a teacher, let me know.
thanks
mark
You're welcome...
Well... I login as a guest and I saw more than 40 entries in the "Othe Online resources" glossary and a another big lot in the "Glossary of Microstructures"...
Could you tell me how many entries are in each glossary?
It's kinda strange...
Will
Hi,
er, I am at home now, and when I logged on as guest this time, the problem had gone away, which is after all the best form of problem, as long as it doesn't reapper.
Sorry to trouble you
cheers
Mark
er, I am at home now, and when I logged on as guest this time, the problem had gone away, which is after all the best form of problem, as long as it doesn't reapper.
Sorry to trouble you
cheers
Mark
np... thanks for your comments...
And your glossaries looks great!
Hi Will,
Your glossary module is developing really fast - congrats!
I've noticed a few things that might be improved - nothing serious, really.
1/ If, in the glossary settings, the teacher chooses NOT to have the "Special" or "All" links, the explanation still says that "Special will show all concepts that does not begin with a letter.
ALL will show all entries in one page." This might be confusing to students, because they will see a description referring to "Special" and "All", but they will not see anything like that.
2/ If "Special" link is not shown, the line breaks between the explanations and the alphabet are missing.
3/ Before the teacher creates any categories, he can add entries which are not categorized. Once he has created at least one category, "not categorized" entries are not possible any more.
4/ In the category selection drop-down box, there is a "Jump to...", which is not necessary (and therefore confusing), because the list is filled with "Not categorized" by default.
5/ It might be useful to have an "all categories" option in the category selection drop-down box.
6/ I've found a few minor mistakes in the language pack. See the attached file for corrections.
Cheers,
Przemek
Your glossary module is developing really fast - congrats!
I've noticed a few things that might be improved - nothing serious, really.
1/ If, in the glossary settings, the teacher chooses NOT to have the "Special" or "All" links, the explanation still says that "Special will show all concepts that does not begin with a letter.
ALL will show all entries in one page." This might be confusing to students, because they will see a description referring to "Special" and "All", but they will not see anything like that.
2/ If "Special" link is not shown, the line breaks between the explanations and the alphabet are missing.
3/ Before the teacher creates any categories, he can add entries which are not categorized. Once he has created at least one category, "not categorized" entries are not possible any more.
4/ In the category selection drop-down box, there is a "Jump to...", which is not necessary (and therefore confusing), because the list is filled with "Not categorized" by default.
5/ It might be useful to have an "all categories" option in the category selection drop-down box.
6/ I've found a few minor mistakes in the language pack. See the attached file for corrections.
Cheers,
Przemek
Hi Przemek, thanks for your useful suggestions.
Points 1, 2, 4, 5, and 6 are done now.
Point 3... Once he has created at least one category, "not categorized" entries are not possible any more They are indeed! You have to keep the control key pressed in order to toggle the status of a category. If you do not select any category, the entry will not belongs to any category at all.
However, I include a "Not categorized" link at the top of the list to make it less confusing so it's done too. If you select this "category", the entry will not be associated with any other category (even if they are selected too).
Thanks again!
Will
Hello Brothers Moodlers,
I've looked at the glossary module for the first time and find out that:
1. view.php
if ( !$course->visible ) {
notice(get_string("activityiscurrentlyhidden"));
}
I think it will be better to look if the current activity is hidden but not the course
2. The search function works only for words written in English letters( or I mistake?)
3. deleteentry.php needs lib.php to be included to work properly
Hope it will help
Hi.
Point 1 is done now.
Point 2, sincerly, is out of my current skills. If you could help me, I would appreciate that.
Point 3 was already solved in a previous post... You should be working with a out of date version.
Thanks,
Will
One more suggestion - once an entry has been exported to the main glossary, the red "plus" icon should disappear, or maybe be replaced with a "minus" icon allowing the user to remove this entry from the main glossary.
Uhmm... I don't agree with this point.. I think they should be deleted directly from the main glossary...
Let's what others thinks...
Dissapearing the plus icon... I though about it too... However, I drop it because it implies one extra query to DB... However, it makes more sense to me than changing it for a minus sign...
Once again, thanks a lot.. You've been very helpful!
Will
Uhmm... I don't agree with this point..
You're right - it will be more intuitive if the "minus" icon is available in the main glossary.
Dissapearing the plus icon... The reason why I think it should disappear is that then the teacher will know immediately (by just glancing at the entries) which entries are already exported to the main glossary and which are not.
You're right - it will be more intuitive if the "minus" icon is available in the main glossary.
Dissapearing the plus icon... The reason why I think it should disappear is that then the teacher will know immediately (by just glancing at the entries) which entries are already exported to the main glossary and which are not.
A question:
If an entry is exported to a main glossary, who should be able to delete or edit that entry? The teacher and the creator or just the teacher?
If I base this question on the current setting ("Student Can add entries"), s/he should be able to edit or even delete her/his entries.. No matter if it is an imported one or not.
However, I'm not sure it should work this way in the imported entries...
Wow, that's a difficult one. I think it could be dealt with like this:
Once an entry has been exported it must be deleted from the main glossary first and only then can it be deleted from the secondary glossary. The scenarios are:
a/ if the student can add entries to the secondary glossary AND to the main glossary, he will simply have to delete the entry from the main one first and from the secondary one then,
b/ if the student can add entries to the secondary glossary BUT NOT to the main glossary, he will also not be able to export entries from secondary to main. Now, if the teacher exports a "student-owned" entry from the secondary glossary to the main one, the student will not be able to delete it from the main glossary, and - consequently - he will not be able to delete it from the secondary one. It is a similar situation to the forum - users cannot delete their own post if there is a reply to it which they cannot delete first.
c/ if the student CANNOT add entries to the secondary glossary BUT CAN add them to the main glossary, he will be able to export entries and to delete exported entries from the main one, but not from the secondary one.
d/ if the student can add entries NEITHER to the secondary NOR to the main glossary - no problem at all.
What do you think? I've found it difficult to put this all in words, but I hope it makes at least some sense
Once an entry has been exported it must be deleted from the main glossary first and only then can it be deleted from the secondary glossary. The scenarios are:
a/ if the student can add entries to the secondary glossary AND to the main glossary, he will simply have to delete the entry from the main one first and from the secondary one then,
b/ if the student can add entries to the secondary glossary BUT NOT to the main glossary, he will also not be able to export entries from secondary to main. Now, if the teacher exports a "student-owned" entry from the secondary glossary to the main one, the student will not be able to delete it from the main glossary, and - consequently - he will not be able to delete it from the secondary one. It is a similar situation to the forum - users cannot delete their own post if there is a reply to it which they cannot delete first.
c/ if the student CANNOT add entries to the secondary glossary BUT CAN add them to the main glossary, he will be able to export entries and to delete exported entries from the main one, but not from the secondary one.
d/ if the student can add entries NEITHER to the secondary NOR to the main glossary - no problem at all.
What do you think? I've found it difficult to put this all in words, but I hope it makes at least some sense
It makes sense to me indeed... However, I see a little problem in all this:
A student can't export entries no matter what... It is a feature reserved only for teachers. I see this exporting feature almost like an administrative task (remember that I'm planning to make this a graded activity once it has all its basic features)
In fact... I was thinking about make the main glossaries only editable (it includes add/edit/delete) by teachers... The idea that I had in mind is that a main glossary will be like a final product created by students' entries "blessed" by teachers... I've been really tempted to stablish this behavior in the main glossaries... What do you think? If it is not the purpouse of a main glossary then... what's the point with them? Why are we differenciating them? I can't find any other reason.. Please, help me on this one, I'm not a teacher nor an educator or constructivist expert.
Well.. Back to point.
In point B you said: Now, if the teacher exports a "student-owned" entry from the secondary glossary to the main one, the student will not be able to delete it from the main glossary, and - consequently - he will not be able to delete it from the secondary one.
Assuming that if the main glossary purpouse is the one I mentioned before, then the student will not be able to edit/delete his own entries in the main glossary. Is it right? Then, will he be able to edit/delete from the secondary glossary? From your words I guess he will not.
Now, I'm the one who hope that his own words makes some sense..
Will
About the first part of your message - I agree with your point here - to me it makes perfect sense to "reserve" the main glossary for the teacher only (so export will also be a "teacher-only" action). However, in this case, I believe the interface for adding a glossary needs to be adjusted a little. If the glossary type selected is main, it should not be possible to set "Students can add entries" to "yes".
I'll get back to you about the second issue a little later - I need to check something first.
Przemek
I'll get back to you about the second issue a little later - I need to check something first.
Przemek
About the second part of your message - I didn't in fact realize how export works. Now I've checked it - if you export an entry to the main glossary, it is copied there, not linked. So, from the moment it is exported, it now exists in two instances, so it is possible to delete one instance without deleting the other. However, the problem is that it is just as possible to edit one instance without chaning the other. As a result, the definition of the same word in the main and in the secondary glossary may eventually become totally different. 
I think it would be better if exporting an entry meant linking it to the main glossary, so that there is only one record in the database, but it is displayed in both glossaries. And then yes, once an entry has been exported, it has been - as you put it - "blessed" by the teacher and the student cannot modify/delete it anymore - neither in the main glossary (which is obvious), nor in the secondary glossary. What do you think?
I think it would be better if exporting an entry meant linking it to the main glossary, so that there is only one record in the database, but it is displayed in both glossaries. And then yes, once an entry has been exported, it has been - as you put it - "blessed" by the teacher and the student cannot modify/delete it anymore - neither in the main glossary (which is obvious), nor in the secondary glossary. What do you think?
We have a deal on it... Thanks!
Hi,
As the current CVS version is somewhat stable, I'd prefer to post this here in order to allow you to test it without compromise the "official" version... I've changed many places in the code and I think I've test it enough but who knows...
Could you test it and let me know your comments?
There's an en language file inside too.
By the way... I've added that noone (not even a teacher) could edit or delete an exported entry from the secondary glossary. If a teacher needs to change it, s/he must edit or delete it in the main glossary.
Regards,
Will
Hi again,
I couldn't find the lang directory in the zip-file, so some text strings are missing, but that's not really a problem at this stage.
I've tested it a little and here are my comments:
The only bug is that when I'm logged in as a teacher, I cannot delete or "un-export" entries from the main glossary. I get "You are not allowed to edit or delete entries".
I seem to be keeping you very busy (sorry for that), but I've got some new suggestions.
1/ Why not display attached images inline (the way they are now displayed in the forums)? That would be perfect for illustrating entries.
2/ When viewing entries alphabetically, it would be useful to have an indication what category each entry belongs to. E.g. if the entry "behave" belongs to category "verbs", the entry display will say "Category: Verbs" and the word "Verbs" could be linked to the category view of "Verbs".
3/ When you enter Standard View, you get entries staring with "A" by default. When I first saw that, I thought: "Why A? Why not display all by default?" But then it occurred to me that this is a very good way of avoiding long download time when users enter the glossary. However, in category view, the default is "All Categories", which WILL cause long downloads. It might be better if either the first category or the "Not categorized" entries were displayed.
What do you think?
PS
I haven't had enough time to test thoroughly. I'll get back to you if I find anything else.
I couldn't find the lang directory in the zip-file, so some text strings are missing, but that's not really a problem at this stage.
I've tested it a little and here are my comments:
The only bug is that when I'm logged in as a teacher, I cannot delete or "un-export" entries from the main glossary. I get "You are not allowed to edit or delete entries".
I seem to be keeping you very busy (sorry for that), but I've got some new suggestions.
1/ Why not display attached images inline (the way they are now displayed in the forums)? That would be perfect for illustrating entries.
2/ When viewing entries alphabetically, it would be useful to have an indication what category each entry belongs to. E.g. if the entry "behave" belongs to category "verbs", the entry display will say "Category: Verbs" and the word "Verbs" could be linked to the category view of "Verbs".
3/ When you enter Standard View, you get entries staring with "A" by default. When I first saw that, I thought: "Why A? Why not display all by default?" But then it occurred to me that this is a very good way of avoiding long download time when users enter the glossary. However, in category view, the default is "All Categories", which WILL cause long downloads. It might be better if either the first category or the "Not categorized" entries were displayed.
What do you think?
PS
I haven't had enough time to test thoroughly. I'll get back to you if I find anything else.
I seem to be keeping you very busy (sorry for that),
Nah... I'm on vacation right now and I really enjoy moodling... Thus, I'm learning PHP on the way, which is something that I was about to do since a long time ago and never actually did it until now when I just noticed that I've a lot to learn yet (Thanks God!)...
Anyway...
The only bug is that when I'm logged in as a teacher, I cannot delete or "un-export" entries from the main glossary. I get "You are not allowed to edit or delete entries".What? It is quite strange. Are you completelly sure that that teacher is a valid teacher for that course??? It shouldn't happen. That message should appear only when:
- You tried to edit or delete an entry and
- You are not a teacher for that course or the students can't add/edit/delete entries.
The problem I see with your point 2 is that an entry could belongs to more than one category, and if it belongs in fact to many categories, this list could be disturbing or, at least, annoying. Don't you think so?
You hit the target in the reason why the first letter that you see is A instead of all entries... It was that way in the earlies stage of development but I thought that a big glossary could takes more time than what it should be if the user is looking for just a special concept.
However, I missed that point in the category view... and you're right... Not categorized should be the default view.
Will
I really enjoy moodling
That's good - I'll keep flooding you with work to do
Are you completelly sure that that teacher is a valid teacher for that course?
Yes.
Now, are you completely sure that the condition is You are not a teacher for that course or the students can't add/edit/delete entries? I think it should be You are not a teacher for that course and the students can't add/edit/delete entries. If the operator is or it's not going to work properly.
this list could be disturbing
You're right, I forgot that an entry can belong to many categories.
How about displaying images inline?
Cheers
That's good - I'll keep flooding you with work to do
Are you completelly sure that that teacher is a valid teacher for that course?
Yes.
Now, are you completely sure that the condition is You are not a teacher for that course or the students can't add/edit/delete entries? I think it should be You are not a teacher for that course and the students can't add/edit/delete entries. If the operator is or it's not going to work properly.
this list could be disturbing
You're right, I forgot that an entry can belong to many categories.
How about displaying images inline?
Cheers
are you completely sure that the condition is You are not a teacher for that course or the students can't add/edit/delete entries?
Sorry... My fault.. I meant to said not a teacher and student can't add entries...
I still wonder why you are getting that message... :/ I'm going to do more testing tonight...
Displaying images inline... I forgot to respond this... Yes, it is easy but I didn't do that that way because the images could have any size and could damage the layout.. I'd prefer to post just a link to a popup window which seems to be more elegant.
My second option was to crunch or cut the image the way the "Update Profile" do with user's images, but I drop it too because it could distort the image or cut important parts of it.
Will
Hi Przermek,
Sorry... I can't duplicate the error. I've posted the new release to CVS so everyone can test it and give his/her feedback.
It also solved the issue with the short tags.
Regards,
Will
I've got it!
I've just installed the latest hourly. And I still could not delete or un-export entries from the main glossary. But now I know what it depends on. It's the Students can add entries setting. It should apply only if the glossary is not the main one. However, if it is set to No, nobody can delete entries, not even the teacher.
Cheers!
I've just installed the latest hourly. And I still could not delete or un-export entries from the main glossary. But now I know what it depends on. It's the Students can add entries setting. It should apply only if the glossary is not the main one. However, if it is set to No, nobody can delete entries, not even the teacher.
Cheers!
Nop... I still can't duplicate the problem... I set that setting to No and I still can add, edit or delete imported or not imported entries if I'm loged on as a teacher of that course...
I REALLY need someone else that test it... I see that everything works smooth from my end...
Will
I've just installed glossary into my Moodle 1.1.1 live server, so I'll try to check it there again. I'll get back to you.