Themes

Hi Julian,

Will do when I get a mo.  Been working on MDL-43112 - if you get a chance and are near Damyon Wiese, could persuade him to hit the integrate button because its so important to get it done .

Cheers,

Gareth

Hi Richard,

Thanks for your reply and for helping me understanding style sheets. I still haven't found out why it doesn't display properly. 

With kind regards,

Hartmut

Thanks David. I am also following this.

Actually, this is why I asked Julian if he made some extra fixes in the theme to RTL, since bootstrap have not included RTL support yet.

Since, Bootstrapbase and Clean had to include a lot of RTL fixes for them to look properly in RTL.

Tomorrow, I will have time to finally download the theme and look at it myself and find out what needs to be done

Again, Amazing work!!!

It will be a full blown breakage along the lines of 'Must be fixed by a programmer'.  I'll do a screen shot when I get a chance with instructions of the work around.

It's all to do with the way that the method 'print_single_section_page' in '/course/format/renderer.php' is written.  It does not allow flexibility in terms of adapt-ion by calling other protected methods for the component parts.  The Elegance theme overrides it and changes it.  But because of the way the class hierarchy is performed for 'format_base' the theme has to extend the course formats extension of it.  This means an implementation on a per course format basis.  This can be simplified if the chunks are smaller and the overridden protected methods call theme specific functions - a write once, read many strategy - see https://github.com/moodleman/moodle-theme_elegance/blob/d74bd866547d994719e1025fda373f9b45d472f3/renderers/core_renderer.php#L491.  However, this is not the case for  'print_single_section_page'.  And Collapsed Topics and Columns implement a private call to set-up an internal attribute in their overridden version of 'print_single_section_page' so therefore Elegance when overriding the same method cannot do the same, it breaks.  The work around is simply to allow Elegance to set-up this private attribute by making it protected.  But in reality, this is a 'hack' as Elegance still has to implement many identical copies of 'print_single_section_page' one for each format!  = maintenance nightmare!

So, my long term solution will be to refactor 'print_single_section_page' such that is it is broken apart into small chunks which are the 'changes' which can be overridden and that overriding method calls the themes specific single implementation function.  Initially I will do this in all my formats so that the theme is simpler.  If that works, I'll propose changes to 'format_base' in core along the same lines - no regressions to contributed formats etc.  When that eventually / possibly gets past the 'process' then Elegance can update and be even simpler.

I hope all of this makes sense.  Currently it is a woolly cloud design in my mind.

Cheers,

Gareth

Edit course settings issue.  Version 2014011600. Chrome 32. 1024x600 display.

Thanks for the feedback. My response.

• You've got two #page-content divs.
  Fixed
  
  
• Your two columns aren't in a div.row, I think that's what's causing some padding issues (the right column has too much padding on the left when collapsed into a vertical column, and it looks like some CSS has been added to counteract this on the right hand side.).
  
  
• There's a 1 or 2px gap at the bottom of the hover on the top menu.
  Grrr.. Missed this in testing, Custom logo is too high. Will fix ASAP
  
  
• I think you can use fa-fw instead of some hand written css you've used on the social icons. 
  Thanks. Adjusted
  
  
• Something weird is going on with both the drop-down menus (collapsed and not) on Firefox (sorry for the vagueness, it seems to be weirdly intermittent, compared with Chrome which seems totally solid). 
  Cant replicate on my firefox (v26 on OSX) Solid here
  
  
• Are you pulling in some CSS twice, Font Awesome in particular?
  Nothing twice that I am aware of. What symptom do you see

I have updated github and the imoot site with the latest build

some hints anybody here ?

thanks .. michel

You are spot on. I am implementing grid so those three columns also resize on multiple browsers.

I have ALL the bootstrap elements working in Essential and Elegance Including lightbox, jumbotron, accordian and more. Sadly as these are jquery they wont be brought into core unless someone coverts them to YUI.

Julian

Hi Hartmut,

Nearly there. Light is at the end of the tunnel. Quick links should not be hardcoded anymore. Now a theme setting.

I will look at the other bugs asap. As iMoot is now using the Github version on the live site I am more conscious than ever that I need to squash the last minute bugs

Julian

Hi, The short/long horizontal lines are a design feature...

It is styled using this CSS...

.block .header .title h2:after {
    background-color: #2D91D0; /** this styles the colour of the short line **/
    content: "";
    display: block;
    height: 1px; /** this styles the height of the short line **/
    position: relative;
    top: 10px;
    width: 100px; /** this styles the width of the short line **/
}

.block .header .title h2 {
    border-bottom: 1px solid #DDDDDD; /** this adds the thin grey bottom border **/
    color: #27282A;
    font-size: 24px;
    font-style: normal;
    font-weight: 300;
    letter-spacing: 0;
    line-height: normal;
    margin: 0 0 10px;
    padding-left: 0;
    text-transform: none;
}

To remove add the following CSS rules to the Custom CSS box in Elegance settings page...

block .header .title h2:after {
    background-color: transparent;
    width: 0;
}

.block .header .title h2 {
    border-bottom: 0 none;
}

Hope this helps?

Mary

I have updated the config with what I think is the best solution for this.

Gareth, want to give it a quick look over and confirm my logic. Happy to take recommendations if you think there is a more efficient method.

Julian