New Krystle version for testing

New Krystle version for testing

by Richard Oelmann -
Number of replies: 11
Picture of Core developers Picture of Plugin developers Picture of Testers

A new (complete rebuild) of the Krystle theme is 'ready' for testing. (Much promised during the summer and finally done! :D)


It has been built using Moodle2.4 alpha and tested on Moodle2.3.2, using Firefox and Chrome (both on Linux) I plan on doing more testing on IE/Windows etc when I am back in work later in the week and have access to a Windows PC, but in the meantime I would appreciate any help in testing that may be available.
As beta code, the theme is not yet in the plugins database but can be downloaded from github here https://github.com/roelmann/krystle

All comments appreciated :D

Richard

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by Mary Evans -

Sorry to have to report it failed at the first hurdle. It would not install.

I did look through all the files and found you had some ghost files which I had to remove.

There were also some odd characters that my editor did not like so added a ? in the places the character should have been. I think you should be adding HTML encoded characters in their place. Found them in layout files as well as CSS.

I still have not found out why it is not installing though but will keep trying.

Sorry this is such bad news, as there is so many things I want to see working like the slider and the profilebar as well as the awesomebar etc.  sad

EDIT: Some good news and some bad...

I got the theme to install eventually. Silly me had it in the wrong version. I had been updateing Moodle 2.3.2 to 2.3.3 and changing all the settings on my Local host. I forgot I was on 2.3.3 instead of Moodle 2.4 (beta) which is where I put Krystal. So it's installed! smile

Now for the bad news...I'm getting this ERROR after selecting it...

Exception - Unknown type

Debug info:
Error code: generalexceptionmessage
Stack trace:
  • line 596 of \theme\krystle\lib.php: Exception thrown
  • line 526 of \theme\krystle\lib.php: call to krystle_expand_navigation->expand()
  • line 505 of \theme\krystle\lib.php: call to krystle_expand_navigation->initialise()
  • line 307 of \theme\krystle\renderers.php: call to krystle_expand_navigation->__construct()
  • line 269 of \theme\krystle\renderers.php: call to theme_krystle_topsettings_renderer->navigation_node()
  • line 108 of \theme\krystle\layout\general.php: call to theme_krystle_topsettings_renderer->navigation_tree()
  • line 793 of \lib\outputrenderers.php: call to include()
  • line 740 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
  • line 66 of \theme\index.php: call to core_renderer->header()

I'm wondering if it is the same problem Paul Nichols fixed in Decaf. Have you checked out Decaf V6?

Moodle 2.4 beta has changed bigstyle.

Mary

Average of ratings: -
In reply to Mary Evans

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Hi Mary,

I thought I had Paul's latest decaf as of last week to build the awesomebar bit so should have all the fixes in place - I'm not getting that error but will obviously try to find what's causing it. I'll also update to 2.4 beta from the alpha version I've got at the minute.

As for the ghost files - I thought I'd got rid of them already - I have on my local copy, but I think I'm doing something wrong with the github transfer as i don't seem to be able to get rid of them from there sad I guess I need to refresh what little use I've made of github over the last year anyway! smile

And the odd characters, I'll try checking the files in a different editor, I can't see anything out of place in gEdit (linux text editor) but I know I have done some of the editing in work on a Windows pc and some on my Linux pc and that - I should have remembered - can seem to cause problems sometimes.

I'll get 2.4beta downloaded later today and retest everything before I re-upload to git later today.

Thanks as always for taking a look at this Mary!!! smile

Richard

EDIT: Just upgraded to 2.4 and now getting the same error message - I guess I need to look at the changes between 2.4Alpha and Beta to see what's happening smile

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Update to the edit above - but I ran out of editing time smile

Just tested decaf on 2.4 beta and getting the same exception error, so something in the move from alpha -> beta 2.4 versions has broken awesomebar

NOTE: Because of the extent of this error, I have removed the github repository until its fixed! I don't mind putting stuff up for community testing that needs a bit of work to move from beta->RC->stable, but something that broken... smile

If anyone wants a copy of the theme as it stands at any point, to look at/work on yourselves, I'll be more than happy to email you a copy - but it will be changing frequently over the next couple of days as I try to debug what effect 2.4Beta has had!

Richard

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by Mary Evans -

Hi Rich,

I got that too with Decaf after I compared your krystle/lib.php with decaf/lib.php and found them athe same. So checkedout decaf and sure enough that is affected too. 

What I want to know is what do the Moodle Devs do to navigation at every update that screws up the awesombar...unless it's YUI js

So frustrating for all concerned. It's like the prob with custom block-regions, Moodle theme design inovation is being stopped.

You would need to trawl through the commits for 2.4 in https://github.com/moodle/moodle.git

I'll take a look see if I can spot something.

Mary


 

Average of ratings: -
In reply to Mary Evans

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

It's been frustrating me all summer, Mary. The original rewrite of Krystle that I was doing when we met up in the Lake District while I was on holiday got shelved because one of the features i was trying to build into the new theme was the custom blocks I used in Lagomorph (and Miriam has in Aerie and are in other themes too) but they no longer work as of 2.3.

Now awesomebar breaks between Alpha and Beta versions of 2.4

Theme designers are trying to get creative with the look and feel of Moodle, with the power and tools it can give us, but something seems to get in the way of each step forward sad

Progress is good - but if it comes at the expense of breaking things in every sub-version, then perhaps some of that 'progress' needs to be moderated a bit or perhaps communicated better from HQ???

Right now, I'm stuck between trying to flog this issue out and fix it - I really wanted this theme ready to go with the release of 2.4, or wait and see what happens when 2.4 becomes stable in case it changes again!

Anyway, for now I'm trying to find the issue - I have a couple of days holiday, but once I'm back in work on Thursday I'll probably have to leave it for a bit sad

I have copied the error messages into the decaf forum thread as well in the hope that Paul might be able to take a look too.

Richard

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Thanks to Paul for his work adjusting decaf for the changes in Moodle 2.4, Krystle is now also again ready for testing.

The rewrite of krystle integrates awesomebar from decaf (Paul Nicholls), the rebase responsive page layout from zebra (Danny Wahl), the profilebar from aardvark (Shaun Daubney/Mary Evans), a box-slider on the front page and My page (from several themes I worked on previously with Mary Evans, if anyone knows the original source I'd be more than happy to credit!) as well as the icon set from Lagomorph (based on the creative commons fugue icon set - details in the theme itself)

https://github.com/roelmann/krystle

As always, comments welcome

Richard

@Mary - I think I've remembered enough about my github to have removed the ghost files this time smile But I couldn't track down the odd characters you found - If you find them again now I've re-uploaded the theme, could you point them out for me to edit? Thanks as always Mary.

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by Mary Evans -

Dan Humpherson (Twitter) @moodledan

EduMoodle is were the slider was 1st used in Moodle

Average of ratings: -
In reply to Mary Evans

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

Thanks Mary, I'll add that credit into the theme later today - I think I've already mentioned the work you and I did to add the settings page for it smile

Average of ratings: -
In reply to Richard Oelmann

Re: New Krystle version for testing

by David Scotson -
Is the icon set available separately? I also used the fugue icon set for my theme and spent a fair bit of time deciding which Fugue icons suited which Moodle icon. It would be good to contribute that effort to an icon set that others could use.
Average of ratings: -
In reply to David Scotson

Re: New Krystle version for testing

by Richard Oelmann -
Picture of Core developers Picture of Plugin developers Picture of Testers

I don't have it separately at the moment David, although it should be fairly easy to just pull the pix folders out of the theme (I don't have the theme on my work computer at the moment and can't access github from behind our firewall to get them from there right now either). I think at the time it was just the pix_core ones I did rather than all the pix_plugins ones as well.

More than happy for other alternative/better suggestions or other options to add to the ones I did smile

Richard

Average of ratings: -
In reply to David Scotson

Re: New Krystle version for testing

by Mary Evans -

David you will find the icons in krystle/pix_core and krystle/pix_plugins so copy both those to your Bootstrap theme and they will works automaically. Moodle always uses the theme icon first and if not there will use the ones in Moodle/pix directory

HTH

Mary

Average of ratings: -