New Version of MyFiles in CVS/contrib

New Version of MyFiles in CVS/contrib

Michael Penney -
回帖数:11
Michael Avelar has fixed a number of security issues plus gives:

Share files among courses (students and teachers)
Send file to assignment (students)

Send to assignment gives the student a list of assignments accepting uploaded files, to which they submit a copy of the a file from their myfiles directory.

Admins can set max upload size and maz directory size for students and teachers.

Please test and let us know if you find any problems (esp. security problems).

Next phase (unless Petr finds more security probsblack eye) is to get the myfiles directory to show up in the browse for image and browse for link from the html editor, so it could be used to share files among courses and/or for students to post inline images in forums & journals.

Thanks!

回复Michael Penney

Re: New Version of MyFiles in CVS/contrib

W Page -
Hi Michael!

This is very nice.

QUOTE: Michael Penny
"Admins can set max upload size and maz directory size for students and teachers."


Is there a GUI for teachers to make more adjustment on upload and max directory size??

QUOTE: Michael Penny
"Next phase (unless Petr finds more security probsblack eye) is to get the myfiles directory to show up in the browse for image and browse for link from the html editor, so it could be used to share files among courses and/or for students to post inline images in forums & journals."


This would be very nice to have and hopefully enable posters to enrich forum postings with images and multimedia.

Thanks

WP1

回复Michael Penney

Re: New Version of MyFiles in CVS/contrib

Darren Smith -

What am I doing wrong? I can't see myfiles at:

http://cvs.sourceforge.net/viewcvs.py/moodle/contrib/

I also tried to get it from cvs directly this morning but couldn't get it there either. I can see block_shared_files but this looks old.

Thanks

回复Darren Smith

Re: New Version of MyFiles in CVS/contrib

Michael Penney -
Doh! I forgot that little commit step after CVS addblush.

OK it's all there. In CVS it's block_shared_files.

We'll try to get one name to rule them all in the next version眨眼.

回复Michael Penney

Re: New Version of MyFiles in CVS/contrib

Petr Skoda -
Core developers的头像 Documentation writers的头像 Particularly helpful Moodlers的头像 Peer reviewers的头像 Plugin developers的头像
Just started reviewing the code, I have found several problems already. I am going to report it at security.moodle.org later tonight, we can discuss it there 眨眼 (or do you want to discuss it here?)


skodak
回复Petr Skoda

Re: New Version of MyFiles in CVS/contrib

Michael Penney -
Hi Petr, I'll look for your report on security.moodle.org.

Thanks!
回复Michael Penney

Re: New Version of MyFiles in CVS/contrib

Petr Skoda -
Core developers的头像 Documentation writers的头像 Particularly helpful Moodlers的头像 Peer reviewers的头像 Plugin developers的头像
I have one more stupid question:
How will be solved backup?

It seems to me it will be a bit problematic, because blocks were originaly intended to be without any database tables - so there is no plumbing for backups, is there?. The relinking of external course data can get a bit messy too.

Even if you dump shared_files tables, you can not restore it into course created from normal backups. You will have to use complete database dump only for server restoration - normal moodle backups will not work, would they?

skodak
回复Petr Skoda

Re: New Version of MyFiles in CVS/contrib

Michael Penney -
Hi Petr, since the idea is to be independent of courses, to provide a file storage space not dependent on a particular course, then I'd guess it will have to have it's own backup also independently run (probably as an admin function rather than teacher--or perhaps as an option in the course id 1 backup?).

Linked files (files linked into course content from MyFiles directory, a planned but not implemented feature) could be handled via the course's backup, but we'd have to have a way to signal the new course to change the course id in the link to the new course id. The links themselves would be backed by the modules, but they would point to the old course id, so we would have to  change the links as the course is backed up, not fun, or manually re-link the links after the backup, not fun at all.

But in the current version, a user with files shared into a course, if the course was backed up and restored to a new course id, they would have to reshare the files to the new course id (which pretty much makes sense anyway, as it is functionally a new course). If the course is restored to the same id, it shouldn't matter, the shared files will still be there (since they are independent of the course).

It may not be a bad idea to try and figure out how to do the relinking of linked files in a course backup, as if there is to be any user centered file system that allows the use of files in courses--in the other mods & blocks, not just shared_files, we'll have to come up with some way to change the links in the course to match the new course id in the linked file path if it is to work with backups. It does conflict with the course centered paradigm of moodle, but we are getting complaints from users who want moodle to be more user centered, and the courses aren't yelling back微笑.



回复Michael Penney

Re: New Version of MyFiles in CVS/contrib

Darren Smith -
Thanks. Looks great big grin

I'll be catious until Petr has sorted his thing out but this would be a big step forward for us. approve

I noticed one of the readme's inside the block folder told me to hack some core moodle files. I assumed these are legacy instructions as it seems to work without tinkering (?)

Darren
回复Darren Smith

Re: New Version of MyFiles in CVS/contrib

Michael Avelar -

Yes, the readme file contains old installation instructions.  This block should install properly by simply copying the folder into the blocks folder and installing the block through the moodle admin interface.

Michael

回复Michael Avelar

Re: New Version of MyFiles in CVS/contrib

Chris Neaves -

Any chance you can be kind enough to make a zip of the cvs files and post it here?

Would love to have a test run of the DMS on one of our moodle sites.