Icons in 2.0 Navbar?

Icons in 2.0 Navbar?

Patrick Malley -
回帖数：11
I'm continuing my work on 2.0 themes and I see that icons for courses and activities have been added to the navigation breadcrumb. Can someone please explain why these have been put there? I find them to be an unnecessary distraction and will probably hide them using CSS if they stick around.
附件 Screen_shot_2010-04-12_at_11.51.55_AM.png
平均分： -
回复Patrick Malley

Re: Icons in 2.0 Navbar?

Sam Hemelryk -
Hi Patrick,

They are simply there because the navbar now gets its information from the navigation structure in Moodle rather than just what the page gives it.

Currently you can get rid of them in two ways:
  1. Hide them using CSS (CSS)
  2. Override the base renderer (PHP)
If we change it over so that by default they are not rendered AND someone wants them they can still get them by overriding a the base renderer.

I'll leave it up to the themers to decide this one, I have created MDL-22072 to gather opinions/votes, it all are in favour of the change consider it done 微笑
平均分：Useful (2)
回复Patrick Malley

Re: Icons in 2.0 Navbar?

Navin Dutta -
+1 from me too on this! We dont need this by default. We can call for it if need be.

Cheers!!

--
Nave
平均分： -
回复Patrick Malley

Re: Icons in 2.0 Navbar?

Chad Outten -
+1 for Patrick. I noticed this on my moodle 2.0 dev site and thought it was a bit peculiar.
平均分： -
回复Patrick Malley

Re: Icons in 2.0 Navbar?

Daniele Cordella -
Core developers的头像 Plugin developers的头像
I may like or hate icons in navbar but why do I have to force others to have my same feeling?
my +1 to use a config settings
$THEME->iconinnavbar = ...

or maybe...

$user->showiconinnavbar
平均分： -
回复Daniele Cordella

Re: Icons in 2.0 Navbar?

Patrick Malley -
At some point, Moodle needs to start making restrictive decisions for the sake of its own design. Nobody has provided a logical argument why these icons should be included in the navbar. What purpose does it serve? If none, then it should be eliminated. A setting will only create noise.
平均分： -
回复Patrick Malley

Re: Icons in 2.0 Navbar?

Sam Hemelryk -
Update: MDL-22072 has now been resolved, icons are no longer shown on the navigation bar by default 微笑

For anyone looking to add them back in you can override the core renderers navbar method and remove the switch when displaying each item to hide the icon if there is one.
平均分： -