Git commits in Moodle 3.5.0 by Mark Nelson

commit ad7f143897f8220fc13401221658b4bd2595cfc5
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 16 May 2018 11:41:19 +0800
Tag:    v3.5.0

MDL-62456 mod_lti: add missing add_external_location_link call

commit df1714f25a161a9914324e4768a71d647c97407c
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 14 May 2018 18:29:52 +0800
Tag:    v3.5.0

MDL-62228 core: remove unnecessary context check in privacy providers

commit 8e24041287a76f381811cfd2cbb3c7f1dff82825
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 14 May 2018 12:46:55 +0800
Tag:    v3.5.0-rc1

MDL-62428 core: fix incorrect early return in privacy providers

commit 61496b764a46f16bdca8b04676bf7d1c37f7fa16
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 11 May 2018 17:33:42 +0800
Tag:    v3.5.0-rc1

MDL-61858 gradingform_guide: added missing metadata implementation

commit ffc148ae39cf07d28678005e22ca32b64e8d267e
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 11 May 2018 16:42:34 +0800
Tag:    v3.5.0-rc1

MDL-61858 tool_phpunit: added missing privacy null provider

commit 776b4fef19817644b3c45eeb96b2def0740e6efe
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 11 May 2018 16:34:31 +0800
Tag:    v3.5.0-rc1

MDL-61858 core_portfolio: added missing metadata implementation

commit 3e642074eeb73e62da7f4d9007fa75d6b4a14206
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 10 May 2018 11:56:57 +0800
Tag:    v3.5.0-rc1

MDL-62368 enrol_lti: implement privacy provider

commit b6b7c2636f20ac0cc5809b6263f1cb852ad2b57e
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 09 May 2018 15:48:17 +0800
Tag:    v3.5.0-rc1

MDL-62364 core: allow null for 'courseid' in notification_sent event

commit 0f41e8a2a131e55e15a035bd6cdfda47901d7df0
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 04 May 2018 13:27:48 +0800
Tag:    v3.5.0-rc1

MDL-62308 core_backup: implement privacy provider

commit 97fcf562baa7955c8e2d2d361d6ed009f9fceede
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 26 Apr 2018 20:16:22 +0800
Tag:    v3.5.0-rc1

MDL-62224 core_rss: implement correct provider

commit 6d82a4235381ff55749258e85817ced5413380d5
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 24 Apr 2018 10:54:21 +0800
Tag:    v3.5.0-beta

MDL-62140 core_privacy: only reset tests when necessary

commit aa725516d3c10d84b761ba5ce3fdabd7533f7138
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 23 Apr 2018 13:50:36 +0800
Tag:    v3.5.0-beta

MDL-62140 core_privacy: add helper functions to add system/user context

commit 04cd1b3f31c26f4c9d51b17b2d125e861bc531cd
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 20 Apr 2018 14:54:12 +0800
Tag:    v3.5.0-rc1

MDL-61919 core_message: implement privacy provider

commit 10efd23b7c2fb6e64932fc23deae886b4ed46255
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 20 Apr 2018 12:02:13 +0800
Tag:    v3.5.0-beta

MDL-61764 message_popup: implement privacy provider

commit a4f994f332d46b78574cbf7e7ec87c0eb303d8b3
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 19 Apr 2018 15:17:43 +0800
Tag:    v3.5.0-beta

MDL-62025 mod_choice: add missing join on modules table

commit 63d170647cfbeebf39b9b53f6f134e58e3da5b12
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 19 Apr 2018 14:28:00 +0800
Tag:    v3.5.0-beta

MDL-62049 core_privacy: use correct lang string for date

commit f611c727f3e29813e4b654902495f8aaae54217f
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 19 Apr 2018 13:00:15 +0800
Tag:    v3.5.0-beta

MDL-62048 core_privacy: extend test to ensure table exists

commit e95599a57b9444efed26e17bd5810aaa5101eba2
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 18 Apr 2018 15:10:12 +0800
Tag:    v3.5.0-beta

MDL-62025 mod_choice: only export in the CONTEXT_MODULE context

commit 3467e8ce3d18ee31a083c68a78c3c014f534cc08
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 17 Apr 2018 15:27:24 +0800
Tag:    v3.5.0-rc1

MDL-61920 mod_lti: implement privacy provider

commit 13fadc876748a56de0ca0e534aa885f34a39cf4e
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 16 Apr 2018 14:08:24 +0800
Tag:    v3.5.0-rc1

MDL-61920 ltiservice_toolsettings: implement privacy provider

commit 897a6e824f7a4f31740c83978e0beac6c11c21c1
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 16 Apr 2018 14:06:59 +0800
Tag:    v3.5.0-rc1

MDL-61920 ltiservice_toolproxy: implement privacy provider

commit 583f84d7cb8e694de50ccd5da5678083fa73042f
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 16 Apr 2018 14:05:51 +0800
Tag:    v3.5.0-rc1

MDL-61920 ltiservice_profile: implement privacy provider

commit 03d6e06400756f96eaab089cec9a1ee2317d5383
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 16 Apr 2018 14:04:44 +0800
Tag:    v3.5.0-rc1

MDL-61920 ltiservice_memberships: implement privacy provider

commit 2b3c4538f1661673e221ac706b0f901a13c04567
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 16 Apr 2018 13:43:23 +0800
Tag:    v3.5.0-rc1

MDL-61920 ltiservice_gradebookservices: implement privacy provider

commit e41a56192a0618a3684da4e2fcacd86e0b09d87b
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 13 Apr 2018 13:34:49 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: removed never shown HTML and string

commit 44946baf044e1b3b269c285bdd0db6db52e8f8ae
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 12 Apr 2018 17:03:31 +0800
Tag:    v3.5.0-beta

MDL-60848 core: added instructions on how to update adapter.js

commit 77e4535fd9faba7bf29b3b06dcdddf2800fadedf
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 12 Apr 2018 13:28:06 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: implemented privacy provider

commit 23de6f3a2d351da44d08e1c8369a764711928126
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 10 Apr 2018 16:26:01 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: add warning when notifications not migrated

commit 78348dfc4e57236bcaacda47ef645c6163c335b1
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 10 Apr 2018 15:00:57 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: added helper function to detect legacy messages

commit c8520ca45fe6338061bf4f66a8359628b31238c7
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 10 Apr 2018 12:16:55 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: changed HTML of attached recordings

commit b5a3388bb1918827857fa58e8c69032c9db818f5
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 09 Apr 2018 17:27:56 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: language string changes

commit 0174e72ba89ea3eb88b122bc7a0eeb173eaa6b52
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 09 Apr 2018 16:12:29 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: removed 'oldermoodle' variable

commit 1ecf5c15cab0a15c6e53a426ee7535ffa6643163
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 06 Apr 2018 16:50:09 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: set valid default for 'allowedtypes'

commit 9e0501a611391f5b4c1cb2d81962bae56005be58
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 06 Apr 2018 15:12:09 +0800
Tag:    v3.5.0-beta

MDL-60416 ltiservice_gradebookservices: supply error code reason

commit ede461a9a464d0ccd41f44b52f9c687e7539524e
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 05 Apr 2018 19:20:44 +0800
Tag:    v3.5.0-beta

MDL-60416 ltiservice_gradebookservices: use moodle_url for links

commit 6f0731adc5d5bfc56361d35a97abb3dfa00ee44d
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 05 Apr 2018 11:00:17 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: adjusted upgrade.txt

commit e78523bff8514548dd147fcbb979a5036186d109
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 29 Mar 2018 15:04:28 +0800
Tag:    v3.5.0-beta

MDL-61255 message_popup: change API so it uses new table

commit 1f64f1742970a81706c1fc134fffefbb82ce1849
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 29 Mar 2018 15:04:00 +0800
Tag:    v3.5.0-beta

MDL-61255 message_popup: add table to store notifications

commit 84f6a716b2e7e689e95658f4c49f34fd2bb835c9
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 28 Mar 2018 22:56:07 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: migrate data from the 'message_popup' table

commit 7489e4d5b9c0b44e03068586f3aa9545fdc4f5c9
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 28 Mar 2018 19:53:21 +0800
Tag:    v3.5.0-beta

MDL-36941 message_popup: do not remove message_popup table

commit 43a60f7fd8889d710f9acc1e511c2937b37c037f
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Mar 2018 17:49:38 +0800
Tag:    v3.5.0-beta

MDL-60416 ltiservice_memberships: construct JSON as PHP array

commit 2e352cd1fa76db55a6c30d52461fc16e74a3d0ae
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Mar 2018 16:46:37 +0800
Tag:    v3.5.0-beta

MDL-60416 core: added 'gradebookservices' to plugin list

commit 7a08156eef4453e571b4e929f3da2a64711e5a07
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Mar 2018 15:57:30 +0800
Tag:    v3.5.0-beta

MDL-60416 mod_lti: add unit test for gradebook cleanup task

commit 5aac33c785e69bdc51bfc8b3dfa9a24ab775fd2e
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 22 Mar 2018 19:47:12 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: dont query DB unnecessarily checking read status

commit 6b21108b44e60d253acf6dd6bc3b45d295d2ffff
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Mar 2018 20:04:02 +0800
Tag:    v3.5.0-beta

MDL-60848 editor_atto: upgrade to add recordrtc

commit dde2a79a70d9d2a7917a2026df8251ea5774bb78
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Mar 2018 19:57:03 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: bumped version

commit 2ce4291183f5f722dc72a7c09cc9b3cc71e60053
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Mar 2018 17:50:05 +0800
Tag:    v3.5.0-beta

MDL-60848 core: added recordrtc to core plugin list

commit 8be5742cb1d1ae6b85bfc3ebc3f1eef3eaaea4a0
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Mar 2018 16:59:19 +0800
Tag:    v3.5.0-beta

MDL-60848 core: updated adapter.js and moved to core

commit a8d022d8140896db25faaee8d5c8b8f1288c3f44
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Mar 2018 16:35:02 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: removed use of bowser.js

commit 492a795d677a20e216eb11bf282e6003a3b0ec63
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 13 Mar 2018 17:44:10 +0800
Tag:    v3.5.0-beta

MDL-60848 atto_recordrtc: removed unnecessary files

commit 99248f617774565eb60942cce7da3163b8c03b3c
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 12 Mar 2018 13:10:39 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: fixed minor CiBoT complaints

commit e159b53b5b33d1313c3ce69dff4c5160629d2668
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 27 Feb 2018 13:23:53 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: improved performance of helper::get_messages()

commit 2ccbb8ed6256f2bdd58302451b995ae0e11bba6b
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 27 Feb 2018 09:39:51 +0800
Tag:    v3.5.0-beta

MDL-36941 core: added index to 'message_user_actions' table

commit 548936a6c95270873f4ad9ea9bf836817535026e
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Feb 2018 19:10:16 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: mark notification/messages takes stdClass

commit 74ad60bfbeb4a22425d8e86ef41592ecb2453833
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Feb 2018 18:44:02 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: deprecated 'api::mark_all_read_for_user'

commit 0d657cc9b7d200d3afb2695acbc2f2f18f7b637c
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 26 Feb 2018 15:46:39 +0800
Tag:    v3.5.0-beta

MDL-36941 core: removed 'message_working' table

commit 5cc6b3eeb5fc82b4fd9140a48a60cb1fad2a09e6
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 21 Feb 2018 13:04:05 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: added unit test for task

commit 123631ad4718141627d77027dbef0448bae22ac8
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 20 Feb 2018 16:27:57 +0800
Tag:    v3.5.0-beta

MDL-36941 message_popup: removed 'message_popup' table

commit 7022b8d9e4244fb1f2fdce99f5d3f59ce13f7dd2
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 20 Feb 2018 14:12:20 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: add notification when data not migrated

commit 41bc5aa587a4bb10bd4e9c5d0a2581bc385cd5ab
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 15 Feb 2018 19:47:08 +0800
Tag:    v3.5.0-beta

MDL-61255 core_message: created task to handle migration of data

commit cb21b5b7fb18408163c73074bc18a177f66ab37e
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 09 Feb 2018 17:31:38 +0800
Tag:    v3.5.0-beta

MDL-61196 message_popup: clean params before returning via WS

commit fb77b89fd896eddafb7510cb2a5d1030346e986a
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 09 Feb 2018 14:46:11 +0800
Tag:    v3.5.0-beta

MDL-61375 mod_chat: specify the 'eventtype' to avoid duplicate rows

commit e96015214146c602069cfce203a1aa9da6f6f2ae
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 09 Feb 2018 11:58:02 +0800
Tag:    v3.5.0-beta

MDL-45837 core: minor tidy up to events

commit b2cd17e6a9e6efabfea4c2b9d84ce3fa2a4948fb
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 06 Feb 2018 12:11:48 +0800
Tag:    v3.5.0-beta

MDL-36941 core: added 'convhash' field to quickly get conversations

commit 3f3e453632801e02ebe86fb53555db008da11bef
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 05 Feb 2018 14:55:10 +0800
Tag:    v3.5.0-beta

MDL-36941 message_popup: use new WS for marking notifications as read

commit 2b595d96f4356ce09eb329ba8f945857cb50171e
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 05 Feb 2018 14:54:16 +0800
Tag:    v3.5.0-beta

MDL-36941 core: added new mark notification as read webservice

commit 376a79c242399aa5fce2c17cf547579b83c8ef47
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 02 Feb 2018 18:07:01 +0800
Tag:    v3.5.0-beta

MDL-36941 core: added events for notifications

commit b02295039ec1bd278d2d0c97cfb27d4f475dffd4
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 29 Jan 2018 19:04:41 +0800
Tag:    v3.5.0-beta

MDL-42764 core: added missing string definition

commit 029ec1edfe89c4088e3bf8cf48a51b49825694a3
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 29 Jan 2018 11:30:05 +0800
Tag:    v3.5.0-beta

MDL-61260 auth_ldap: require /user/profile/lib.php file

commit 0d51ae7ef33a4bf7c4f53f5212bb14aaedfecf32
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 25 Jan 2018 08:54:10 +0800
Tag:    v3.5.0-beta

MDL-36941 core: final deprecation of functions

commit d0d1e97ab6aeed3b4730ddb90b94e37c7e29a1c2
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 24 Jan 2018 17:33:24 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: added details to upgrade.txt

commit 822fe4fc155af73b407c5d23b905be1470995d3b
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 17 Jan 2018 13:32:27 +0800
Tag:    v3.5.0-beta

MDL-60814 auth_ldap: prevent setting names breaking site upgrades

commit e4d9eff64019caa43601b43582e09ae7d67bdb8f
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 16 Jan 2018 18:13:20 +0800
Tag:    v3.5.0-beta

MDL-61224 core_role: prevent short name from exceeding 100 chars

commit 4cd439887abc00ab801064a982095bd3700a492a
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 04 Jan 2018 17:17:55 +0800
Tag:    v3.5.0-beta

MDL-36941 core: alter events to use new table structure

commit ee14412e2182036567ee3bf0b2272ef6ac3993c1
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 04 Jan 2018 17:17:44 +0800
Tag:    v3.5.0-beta

MDL-36941 core_message: removed unit test that will always fail

commit 883ce421272553e95c95ff56ea634ac6b906c239
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 04 Jan 2018 15:01:37 +0800
Tag:    v3.5.0-beta

MDL-36941 core: convert existing api to use new table structure

commit e8a1a5868a620279688c7cd3dce5ff9680bd1f6a
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 03 Jan 2018 17:16:05 +0800
Tag:    v3.5.0-beta

MDL-40613 auth_ldap: removed usage of profile_load_custom_fields()

commit a63f98245cdbc3b10fb395cb7ebb1ea0b35a7e67
Author: Mark Nelson <markn@moodle.com>
Date:   Thu, 21 Dec 2017 13:28:07 +0800
Tag:    v3.5.0-beta

MDL-36941 core: added new messaging and notification tables

commit 4afad1faebc35816ad527f95d1df3f27df391bec
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 19 Dec 2017 13:12:38 +0800
Tag:    v3.5.0-beta

MDL-40613 auth: moved lang string to common auth file

commit 464ddd07d564868c71968b1c04f34105319a5515
Author: Mark Nelson <markn@moodle.com>
Date:   Wed, 13 Dec 2017 15:25:36 +0800
Tag:    v3.5.0-beta

MDL-43466 mod_assign: improve submission help text

commit dbe18cd3564e58f947da32a1132ce4abb5af287e
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 05 Dec 2017 15:01:19 +0800
Tag:    v3.5.0-beta

MDL-60969 auth_ldap: replace hardcoded strings in config settings

commit 55595bcfcb5fe43d7e76c653244188b0bbf75b88
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 05 Dec 2017 12:51:14 +0800
Tag:    v3.5.0-beta

MDL-40613 auth: added note in upgrade.txt

commit 220ca688c1e7e1740c9d433b4b4dd4ff5104a7e6
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 04 Dec 2017 15:19:30 +0800
Tag:    v3.5.0-beta

MDL-40613 auth_ldap: include necessary file for saving profile fields

commit 4e133e775c160c2723a99920721d86b90603b459
Author: Mark Nelson <markn@moodle.com>
Date:   Fri, 01 Dec 2017 11:34:16 +0800
Tag:    v3.5.0-beta

MDL-40613 auth: avoid undefined property 'suspended_attribute'

commit 2a56a82c9ba80579cf7fdb13e7a16f4eabd3fe7d
Author: Mark Nelson <markn@moodle.com>
Date:   Tue, 28 Nov 2017 11:37:00 +0800
Tag:    v3.5.0-beta

MDL-60914 mod_lti: ensure grade_update() is defined during upgrade

commit 5211efb99b4b2c2fa62257741fd95c689e563ad6
Author: Mark Nelson <markn@moodle.com>
Date:   Mon, 27 Nov 2017 15:26:43 +0800
Tag:    v3.5.0-beta

MDL-37933 core_complete: fixed criteria/criterion naming confusion