Git commits in Moodle 2.5.x by Jerome Mouneyrac

commit 7da2b5e2314af540d8c623c8d5be8255ff8c8396
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 16 Dec 2013 14:33:02 +0800
Tag:    v2.5.4

MDL-43399 Badge: the Choose... option can still be selected once a role is choosen.

commit 97410938cecdc70dc8fb71c852a02a48b9f58c85
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 16 Dec 2013 12:07:33 +0800
Tag:    v2.5.4

MDL-41075 Remove "Choose..." option from participants page.

commit b48bc910442be929416a336a7620c59c3a85b629
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Thu, 12 Dec 2013 16:04:52 +0800
Tag:    v2.5.4

MDL-42085 Enrol: Always apply enrolment duration.

commit bb12a401ecdd473c1c18353e7706128ff02f1a9c
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 20 Nov 2013 17:21:01 +0800
Tag:    v2.5.4

MDL-42184 remove the body top padding for bootstrapbase popup + fix get_device_type call

commit 3f74db657860383bae8febdac6044268361d1257
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 08 Nov 2013 11:58:56 +0800
Tag:    v2.5.4

MDL-42184 bootstrapbase: popup should have no header

commit c7cc3271c0d52cadb22d96a65de27993bc854a72
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Thu, 24 Oct 2013 11:43:04 +0800
Tag:    v2.5.3

MDL-42332 Automate MDLQA-5260 and MDLQA-5261 - A badge can be awarded based on activity and course completion + add i_trigger_cron behat step

commit a10af7329e8d7c8fcfe4ccd9568576306d08a5bd
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 22 Oct 2013 15:22:09 +0800
Tag:    v2.5.3

MDL-42331 Automate MDLQA-5258 - A teacher can add and allocate a course badge

commit a8fe589f4d1e62fc219fbc68a05c05a25069d899
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 22 Oct 2013 10:44:47 +0800
Tag:    v2.5.3

MDL-24380 Chat: autoscroll help popup incorrect and doesn't display fully (it only concerns the alternative chat methods)

commit 79a12d2d3fddcf9ab185c53f1db66727f31af048
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 21 Oct 2013 13:45:12 +0800
Tag:    v2.5.3

MDL-42330 Automate MDLQA-5257 - An admin can award a site badge

commit e0b8bc0a08457463fc2f533f94d5f58d8bd04449
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 08 Oct 2013 16:53:06 +0800
Tag:    v2.5.3

MDL-41252 Simple changes to main course page to improve accessibility - original patch of Nate Baxley

commit 0b121f15186a32bcfd4b24363a7b65410422259f
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Thu, 08 Aug 2013 17:15:03 +0800
Tag:    v2.5.2

MDL-30895 switch from dl tag to table in the accessible chat

commit 99f5bad5544e51a1bbd4f467c5a13f891aeb7576
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 14 May 2013 15:40:16 +0800
Tag:    v2.5.1

MDL-31209 web service error message: Indication about the service not containg the web service function is confusing

commit ea29059efa997b7234cdb2fd811f49f285f280ea
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 07 May 2013 14:55:55 +0800
Tag:    v2.5.0-rc1

MDL-37552 external_format_text: missing require_once filelib.php (shared credits to Adam Fredericks for report and patch proposal)

commit 669dee58048b18d9034a7b2367b97a50b498b0e0
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 07 May 2013 13:55:47 +0800
Tag:    v2.5.0-rc1

MDL-37822 Moodle send site information to a hub even though it's unchecked

commit 2af34ab005c74e0c47732341f612b89dc4935dd2
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 03 May 2013 14:09:34 +0800
Tag:    v2.5.0-rc1

MDL-31193 display the correct and translated token valid until date

commit 3fb83b41a5c48af9ccacb8aeb5c0c0f5d41256b1
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 26 Apr 2013 16:45:00 +0800
Tag:    v2.5.0-rc1

MDL-38888 Publish forms display setType warning

commit 9f3cc17d8ff2efea9f5a40029127c8452246405b
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 26 Apr 2013 15:56:28 +0800
Tag:    v2.5.0-rc1

MDL-30775 get_course_contents: remove warnings when the section is empty

commit 487bc1b6273a7202735c09a42bc1b5aa631de17f
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 26 Apr 2013 15:13:03 +0800
Tag:    v2.5.0-rc1

MDL-38440 WebService get_contents doesn't return the full text of labels

commit 843fac45572dea8aa479bd3415b61b8fa0ac0ba9
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 17 Apr 2013 14:31:23 +0800
Tag:    v2.5.0-rc1

MDL-38889 Community finder search display setType() form warnings

commit 63c7be350b7acd5cf0c320ff31f1157c59f110d3
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 17 Apr 2013 12:13:04 +0800
Tag:    v2.5.0-rc1

MDL-34434 Change the texts saying that we'll be removing web service deprecated functions from 2.5

commit fea8be420338f0df49606ade33dc062d40bfa461
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 10 Apr 2013 11:50:56 +0800
Tag:    v2.5.0-rc1

MDL-37988 Completion reports: Table header row not in thead section

commit 41f5285f163132118243a2f82ad58af0e4d96fda
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 05 Apr 2013 13:14:49 +0800
Tag:    v2.5.0-rc1

MDL-38030 new core_user_get_users_by_field function deprecates core_user_get_users_by_id

commit 37550a52e7c7c62814d21576cbd9b3a8704df15a
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 18 Mar 2013 16:08:52 +0800
Tag:    v2.5.0-beta

MDL-37079 missed one modedit.php change since started to work on the issue

commit 80fe0c1983cb702e37f014e96734262dd20d1390
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 15 Mar 2013 17:45:56 +0800
Tag:    v2.5.0-beta

MDL-37079 switch the modedit.php functions into course/modedit.php

commit ff855b9b1963a88ecd5f4715b1805d684e5196c5
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 20 Feb 2013 11:39:47 +0800
Tag:    v2.5.0-beta

MDL-38001 rename the download button into install button

commit 85e6bf8e710670914b892abac0f0b79610e19aec
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 15 Feb 2013 11:03:13 +0800
Tag:    v2.5.0-beta

MDL-29938 throw exception when a criteria is repeated, used self instead classname when possible, return only not deleted users

commit 909f27acf43f3e787ae04d1220bdc447ad3b1422
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 12 Feb 2013 11:15:15 +0800
Tag:    v2.5.0-rc1

MDL-37410 External PHPunit test: used ->getDataGenerator()->enrol_user instead to manually enrol the user. + improve the unassignUserCapability to remove a capability assigned by getDataGenerator->enrol_users

commit 0c34e8034d0991ac067b4b3b0f7672c507410847
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 11 Feb 2013 13:57:50 +0800
Tag:    v2.5.0-beta

MDL-29938 ignore invalid keys

commit bb1105ae31e317e818e6a3609a07bc8e574749d6
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 06 Feb 2013 17:18:09 +0800
Tag:    v2.5.0-beta

MDL-29938 Fix typo bypassing some code + remove misplaced code in deprecated function + some code cleaning

commit b4d24344c2899e638eb5297d4aee21d5200dfcc6
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 05 Feb 2013 16:36:37 +0800
Tag:    v2.5.0-beta

MDL-37012 some typos, add a new lang string, change tag 'a' for 'link', some code cleaning, clean the external string against cross-scripting, proper usage of doclink, correcting the require_once quickform/input

commit ec80bc6bf867bc069526fe403ac7c675ae533adb
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Thu, 24 Jan 2013 10:23:12 +0800
Tag:    v2.5.0-beta

MDL-29938 don't validate return user info against PARAM_USERNAME as PARAM_USERNAME only apply to manual authentication (and web service)

commit b0365ea5d1ac08aa22e65cba935b192ea3411eeb
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 23 Jan 2013 18:02:31 +0800
Tag:    v2.5.0-beta

MDL-29938 get_users - search users external function

commit 821676f5b7a94a49139535f9b68a7b7afda46f1a
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 23 Jan 2013 13:54:22 +0800
Tag:    v2.5.0-beta

MDL-37476 course_create unit test fails if course completion is enabled

commit e62cf630359acdc143ea100191cbafbe4dc1cdb9
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 23 Jan 2013 11:57:52 +0800
Tag:    v2.5.0-beta

MDL-37012 fix wrong css + add final . to comment lines + do not use attributid parameter (duplicate of hiddeninputid)

commit 7cb0ea2c37d52fbff34608283f4c9454d7131f50
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 22 Jan 2013 14:03:48 +0800
Tag:    v2.5.0-beta

MDL-37079 remove TODO, add . in comments

commit 7bf4f6e9994d364e0f3a371514094bf187e26fc0
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 22 Jan 2013 10:52:47 +0800
Tag:    v2.5.0-beta

MDL-37079 Added many assertEquals + generic test function (easy to test new module)  + now process next advanced grading screens

commit fb695f6e3d66938fba1940631db121572efcb232
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 09 Jan 2013 13:47:01 +0800
Tag:    v2.5.0-beta

MDL-37354 clean return value for each externallib PHPUnit tests

commit c2bc5a70087a21a4c05cd2a13afdf884e61464c6
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 08 Jan 2013 16:39:55 +0800
Tag:    v2.5.0-beta

MDL-37194 activity chooser displays entire list of default activities/resources

commit c5f7628d397bef08e324e6c0517c37d890a31013
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 08 Jan 2013 16:23:24 +0800
Tag:    v2.5.0-beta

MDL-37381 core_external::get_component_strings returns wrong format value

commit 9a4c2f50c9e7990f14bfcdc99553c57a5db973bd
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 07 Jan 2013 11:11:14 +0800
Tag:    v2.5.0-beta

MDL-37355 object are automatically cast into object by the return value

commit 6a30d03e5f78648afda8dcdfbff496a420e83117
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 04 Jan 2013 12:55:53 +0800
Tag:    v2.5.0-beta

MDL-37355 Fix the REST server that didn't send back the cleaned values

commit dd5d933f306a16847685649950a5121a759b56dd
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Wed, 02 Jan 2013 13:58:42 +0800
Tag:    v2.5.0-beta

MDL-37079 create/update_module()

commit 8118dbd02febd66fd14901f912327a7d8764bef4
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Thu, 13 Dec 2012 11:15:50 +0800
Tag:    v2.5.0-beta

MDL-37143 External_warnings: developer should be able to modify the item/itemid/errorcode description

commit 46b229f9a8d72a7ac4eb6ef1866621ec5fd8153b
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 07 Dec 2012 17:09:26 +0800
Tag:    v2.5.0-beta

MDL-37012-master redesign the community finder search form

commit e9e567f33ce45a46c5245e5772cde8dc5e444c5b
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Tue, 04 Dec 2012 11:47:19 +0800
Tag:    v2.5.0-beta

MDL-29805 add REQUIRE_CORRECT_ACCESS define + return error code when AJAX_SCRIPT fails

commit 87ede25c9be4fa02a6a7d656a9d7fa6b15c05c07
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Mon, 03 Dec 2012 10:47:38 +0800
Tag:    v2.5.0-beta

MDL-35593 core_webservice_get_site_info returns version number set to PARAM_TEXT and PARAM_FLOAT

commit 11d819364e48ab74ca0df799554a59bfc447ad1f
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 30 Nov 2012 14:22:16 +0800
Tag:    v2.5.0-beta

MDL-30961 get_course_contents: returned activity name should not be check against PARAM_TEXT, it could be anything

commit 8158ce79f9a1be3a8a3fcba7f236e0f3d70a8602
Author: Jerome Mouneyrac <jerome@mouneyrac.com>
Date:   Fri, 30 Nov 2012 10:11:55 +0800
Tag:    v2.5.0-beta

MDL-36773 timezone inconsistency => some number support decimal other don\'t - Original patch author: Nathan Mares

commit c70b9853da9393c51d661aefcb638199f608ce6e
Author: Jerome Mouneyrac <jerome@moodle.com>
Date:   Tue, 30 Oct 2012 11:36:29 +0800
Tag:    v2.5.0-beta

MDL-35543 modify get_users to get_users_by_field (more complex search function named get_users will be implemented later - focussing yet on retrieving user info for a specified field)