Git commits in Moodle 1.9.x by Jamie Pratt
commit 7d2e309c9bb15040abc378ec4cdf0115550f6d6d
Author: Jamie Pratt <me@jamiep.org>
Date: Thu, 18 Feb 2010 20:56:12 +0800
Tag: v1.9.8
MDL-21650 "cookieless sessions fail when opening a pop up window using the javascript 'openpopup' function for example from the course view page " adding the session name and id in the js function openpopup.
commit 4a4a05cfa82fcdf8d90a92773b99c09698b6ea64
Author: Jamie Pratt <me@jamiep.org>
Date: Thu, 18 Feb 2010 19:50:18 +0800
Tag: v1.9.8
MDL-21637 "bug in some versions of php version 5 prevents cookieless sessions working"
commit cdf50f82de0d53a44e1273d5c1d52669ebe031d4
Author: Jamie Pratt <me@jamiep.org>
Date: Wed, 17 Feb 2010 22:25:35 +0800
Tag: v1.9.8
MDL-21641 cookieless sessions - Need to try to set a cookie before falling back to cookieless mode. Moved test to see if cookies are working till after Moodle has attempted to set a cookie. If there is no cookie then we use session id in url.
commit 62236dd1b11cee68867632a7b7b5a0b32e1fa4eb
Author: Jamie Pratt <me@jamiep.org>
Date: Wed, 17 Feb 2010 19:31:33 +0800
Tag: v1.9.8
MDL-21638 cookieless session id not passed when loading images - needed for example for graphs which access session data
commit 72336b7f93acb2a749c791856d30a4bcd7b0ec06
Author: Jamie Pratt <me@jamiep.org>
Date: Wed, 17 Feb 2010 19:25:38 +0800
Tag: v1.9.8
MDL-21637 bug in some versions of php version 5 prevents cookieless sessions working. Using static variable to store data from CFG on first call to fix problem.
commit 4d5025a77689a9ddf6030b50836e7c906a7c78a5
Author: jamiesensei <jamiesensei>
Date: Thu, 29 Jan 2009 22:43:50 +0900
Tag: v1.9.5
MDL-18085 "custom user profile fields : in a list box field if one of the admin chosen values has an apostrophe in it it breaks the query to update / save the value"
commit 1b190526462e617e5037e10992a557f65881fbc3
Author: jamiesensei <jamiesensei>
Date: Mon, 13 Oct 2008 19:50:14 +0800
Tag: v1.9.3
MDL-16842 "Adding group of elements in function lib/formslib.php/repeat_elements() not working correctly" Fixed using fullclone instead of clone now.
commit 9a4ba0a430cf653a5ebf97e0e482ed03f956847d
Author: jamiesensei <jamiesensei>
Date: Wed, 08 Oct 2008 18:19:51 +0800
Tag: v1.9.3
MDL-14676 "In question bank, problem with moodle/question:edit* when do not have moodle/question:move*" Fixed logic for processing submission of question form and also added some validation to check that the user has permissions to move a question.
commit f1a022424de84507b17ee975fca84db07293db5e
Author: jamiesensei <jamiesensei>
Date: Thu, 28 Aug 2008 14:46:43 +0800
Tag: v1.9.3
MDL-16242 "'Required' does nothing for select fields in customisable user profiles" added an extra option 'Choose...' which is the default if no other default is specified. If the user leaves the select field set to 'Choose...' then the required rule fails and the form does not submit.
commit 64b0c54d0f2db9eb39e04f84638e07e45de3b0a2
Author: jamiesensei <jamiesensei>
Date: Fri, 15 Aug 2008 18:28:16 +0800
Tag: v1.9.3
MDL-16041 "Grade of new tests are zero!" no longer displaying graphs of grades for ungraded quizzes.
commit 65143620aa03ab83aaf757bc42ee5874ba00e4ee
Author: jamiesensei <jamiesensei>
Date: Sun, 20 Jul 2008 21:01:45 +0800
Tag: v1.9.3
MDL-15198 "non-standard sql in reportlib.php" using CASE statement to wrap logic in fields list
commit dcb16152f31e69cb43d336e22dd1b02dda381f74
Author: jamiesensei <jamiesensei>
Date: Fri, 04 Jul 2008 17:48:01 +0800
Tag: v1.9.2
MDL-15530 "The Group menu in Quiz Module no longer works as before: all students are displayed regardless of what group is chosen" 'all attempts' mode for report is now disabled when a group is selected.
commit 696d84554d0fa29eb6d1e6ebb38793dfaa4de22c
Author: jamiesensei <jamiesensei>
Date: Tue, 01 Jul 2008 19:39:09 +0800
Tag: v1.9.2
MDL-15490 "Create a new Quiz: warning message in Result tab" problem was when there were no students in a course - fixed.
commit 78eabcc29d599c5280d32b4c1240ae8d18d96174
Author: jamiesensei <jamiesensei>
Date: Mon, 30 Jun 2008 19:52:47 +0800
Tag: v1.9.2
MDL-15198 "non-standard sql in reportlib.php" fixed this with new sql that does not require a limit clause.
commit ac625ae9227146dc18fc6533f1825b68f32c8876
Author: jamiesensei <jamiesensei>
Date: Tue, 24 Jun 2008 20:31:28 +0800
Tag: v1.9.2
MDL-15309 "Switch role to student, take quiz, can't delete attempt" switching default of overview report to show all attempts whether or not the attempt is for a currently enrolled student.
commit f32aa45ef46e935b5f5a316acc6abadb43347236
Author: jamiesensei <jamiesensei>
Date: Tue, 24 Jun 2008 20:18:16 +0800
Tag: v1.9.2
MDL-15378 "Quizz: sql error if not student in the group" now have extra logic to not display the table if there are no students at all or in current group - still displaying form and graph were appropriate.
commit 29e3105632bf213a6971a68f1cc6f51dab872fc7
Author: jamiesensei <jamiesensei>
Date: Sun, 22 Jun 2008 21:01:39 +0800
Tag: v1.9.2
Fixing typo introduced in 1.282.2.14 version of this file.
commit 1c215c8bced34f0add7ce82a2b9a5cb27bf3da6b
Author: jamiesensei <jamiesensei>
Date: Thu, 19 Jun 2008 23:19:17 +0800
Tag: v1.9.2
MDL-15165 "Essay quiz Manual grading "these are no attempts to show" when there are actually attempts" - not resolved. But while reviewing the query I found a LIMIT clause in sql that I've replace with params to the get_records_sql function. Also made the logic in attempt_sql method more robust.
commit e05eb943d0857b36adfa5d6d5209558b27f8df67
Author: jamiesensei <jamiesensei>
Date: Thu, 19 Jun 2008 20:31:28 +0800
Tag: v1.9.2
MDL-15264 "Bar graph image missed when group with no attempts selected" added a query to check for sure that there are some grades there to display in the graph. Also now displaying grades for all groups a user has permission to view - but only if that is up to 4 groups and only if there are less than 500 grades total.
commit 1be3ce4510f40f4451d36ca2d8b70611f2d15301
Author: jamiesensei <jamiesensei>
Date: Fri, 13 Jun 2008 20:46:54 +0800
Tag: v1.9.2
MDL-15224 "Overview results in quiz module export to excel and txt fail" Fixed.
commit f5d47e36f18137ee83eef6714a1617149ce0b7a2
Author: jamiesensei <jamiesensei>
Date: Tue, 10 Jun 2008 15:45:22 +0800
Tag: v1.9.2
MDL-14821 "Quiz: report overview page is not XHTML compliant" wrapped hidden form params in div with style 'display:none'.
commit 012de02b6458f46924d0c663b4cdcc8a342097df
Author: jamiesensei <jamiesensei>
Date: Sat, 07 Jun 2008 20:58:34 +0800
Tag: v1.9.2
MDL-14821 "Quiz: report overview page is not XHTML compliant" gave the fieldsets in the form different names to avoid html id attribute conflict.
commit a92741f2d27ef8f6f605820a801203df0b422f65
Author: jamiesensei <jamiesensei>
Date: Fri, 06 Jun 2008 20:24:17 +0800
Tag: v1.9.2
MDL-15092 "Quiz overview report won't display if there are more than 29 questions" Small fixes in logic to do with sorting.
commit 6713e60db7c2cf1368b7a64f090d36137aee278e
Author: jamiesensei <jamiesensei>
Date: Fri, 06 Jun 2008 19:08:58 +0800
Tag: v1.9.2
MDL-15150 "Quiz Report broken in course without students" added warning message if there are no students in course yet.
commit 5b598e9e5db15ab53efee2425904890026194367
Author: jamiesensei <jamiesensei>
Date: Thu, 05 Jun 2008 19:12:58 +0800
Tag: v1.9.2
MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" adding idnumber to the list of columns that is 'suppressed' ie that is only printed once when the same data is repeated in consecutive rows.
commit 5bc700de54fc7d2d154a5b052de96a6624d6f5ec
Author: jamiesensei <jamiesensei>
Date: Thu, 05 Jun 2008 14:12:26 +0800
Tag: v1.9.2
MDL-15092 "Quiz overview report won't display if there are more than 29 questions" fixed this by going back to the old way of fetching data for display in the table. However still use table JOINs when user wants to sort by question grade. The user can sort by a maximum of two columns at once so the JOINs will not exceed the limit.
commit b536544e34b12ad941c46db0b1b1d12f4a943953
Author: jamiesensei <jamiesensei>
Date: Fri, 30 May 2008 20:22:20 +0800
Tag: v1.9.2
MDL-15047 "Quiz overview report download is broken - patch" fixed.
commit 49814438b9fbe744301c92616c7026852a88c12e
Author: jamiesensei <jamiesensei>
Date: Thu, 29 May 2008 22:31:30 +0800
Tag: v1.9.2
MDL-15011 "grading report : allow user to select to grade next 10 ungraded attempts" added a new link and options to the grading report page to display only the next 10 ungraded attempts to grade. Also some fixes for faulty sql for ungraded option which was not respecting the users groups selection.
commit e86d81b3ca90d0b4189fb2a8a395cd2469bcd3e6
Author: jamiesensei <jamiesensei>
Date: Mon, 26 May 2008 22:24:51 +0800
Tag: v1.9.2
MDL-15002 "grading report : notice from quiz_num_attempt_summary about how many total attempts there are on the quiz and how many in this group would make UI clearer" added call to function and fixed centering of notice on overview and grading report by adding a clear:left to stop the centering being affected by the groups menu.
commit cec3911dd44d57547201205f94e519e7dcf0141e
Author: jamiesensei <jamiesensei>
Date: Mon, 26 May 2008 21:23:14 +0800
Tag: v1.9.2
MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
commit 9607206c715311a7edb43bd4400c323b1fd458e0
Author: jamiesensei <jamiesensei>
Date: Mon, 26 May 2008 20:06:19 +0800
Tag: v1.9.2
MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
commit 4c3332efffb37aa9319463723b6eb41ee2e60bf8
Author: jamiesensei <jamiesensei>
Date: Mon, 26 May 2008 19:47:00 +0800
Tag: v1.9.2
MDL-15000 "Moodle url method remove_params doesn't actually remove anything" Fixed.
commit 89bc941b70d37eea2cee4a2c6046ad6508b5001b
Author: jamiesensei <jamiesensei>
Date: Mon, 26 May 2008 17:01:30 +0800
Tag: v1.9.2
MDL-14988 "tables have been hardcoded with a prefix of "mdl" - causing an error." Ooops!
commit 7e8b311075f1366b8105830dac54bb64ab4c8cf6
Author: jamiesensei <jamiesensei>
Date: Sun, 25 May 2008 19:46:12 +0800
Tag: v1.9.2
MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name" Ooops. Accidentally introduced a bug during refactoring and reworking of UI code. I added gradeall links to the table whether or not there were attempts to grade, have fixed this now.
commit 3a83ce8b5dc7d23e5b27ed4dc4afd126eedbfaac
Author: jamiesensei <jamiesensei>
Date: Sun, 25 May 2008 19:35:29 +0800
Tag: v1.9.2
MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
commit 30146912789ab9165ebd066d4f1d3ed200908ef4
Author: jamiesensei <jamiesensei>
Date: Fri, 23 May 2008 21:00:47 +0800
Tag: v1.9.2
MDL-12547 "allow manual quiz grading to sort by groups" added code to select which group to grade.
commit 57fb427c9be0467915ec4cc7f6c9d1acdc9ceb52
Author: jamiesensei <jamiesensei>
Date: Thu, 22 May 2008 17:18:03 +0800
Tag: v1.9.2
MDL-14943 "moodle_url : need way to add extra params when outputting params as hidden fields for forms" added new optional param to method hidden_params_out
commit 34ccb459a67275777132abc4b28ae872f1d5908a
Author: jamiesensei <jamiesensei>
Date: Fri, 16 May 2008 22:44:05 +0800
Tag: v1.9.2
MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Reverting accidentally committed changes to this file which where committed as part of the fix for MDL-14844
commit fdc1036f0eaf0bcdcfef61dec20b39df38577e8d
Author: jamiesensei <jamiesensei>
Date: Fri, 16 May 2008 22:39:02 +0800
Tag: v1.9.2
MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Now using php ceil function to round up $bands as in some cases it could be a non integer.
commit 01676c49a3f1ae22c7a0e157c44ce1f1660e04bd
Author: jamiesensei <jamiesensei>
Date: Thu, 15 May 2008 21:55:49 +0800
Tag: v1.9.2
MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory.
commit 05289910b7a63c93764009bad39ee12e2122fbb0
Author: jamiesensei <jamiesensei>
Date: Thu, 15 May 2008 20:52:56 +0800
Tag: v1.9.2
MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade.
commit 574682636428d4b2668ade9bc61e576b8bbff790
Author: jamiesensei <jamiesensei>
Date: Thu, 15 May 2008 20:25:04 +0800
Tag: v1.9.2
MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code.
commit 316d595389e0f4cf1e64103b1aac385e0f19a887
Author: jamiesensei <jamiesensei>
Date: Thu, 15 May 2008 18:40:58 +0800
Tag: v1.9.2
MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" added perfect grade to last 'band' on graph.
commit ac2ce35b6c11dd6a1112c853189206306942cffa
Author: jamiesensei <jamiesensei>
Date: Wed, 14 May 2008 19:15:14 +0800
Tag: v1.9.1
MDL-14201 "Summary graph" - small improvement to robustness for sql.
commit 4e270902846d77fdb96ef0de85d8ee6b3885ffb5
Author: jamiesensei <jamiesensei>
Date: Wed, 14 May 2008 17:12:57 +0800
Tag: v1.9.1
MDL-14822 "Quiz Report: the quiz report do not find the first attempt" needed to include quiz id in WHERE conditions.
commit 872c8cc93fb6cbf3174c1cdbbcd62befcc47e4af
Author: jamiesensei <jamiesensei>
Date: Tue, 13 May 2008 23:03:29 +0800
Tag: v1.9.1
MDL-14201 Summary graph in Overview Report - needed a little more spacing between bars of graph in some cases.
commit 18d71106734fae2eaae38cd43957f9cd0c0bea09
Author: jamiesensei <jamiesensei>
Date: Fri, 09 May 2008 21:50:24 +0800
Tag: v1.9.1
Oops accidentally reverted this patch. Here it is again. "MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports"
commit 3114a292df3190218627d627c3a3054099ba500c
Author: jamiesensei <jamiesensei>
Date: Fri, 09 May 2008 21:15:12 +0800
Tag: v1.9.1
Merging some small differences between HEAD and the 1.9 stable branch.
commit 88a78fa926073fca4bf77bf8d4f9d1138a7e731e
Author: jamiesensei <jamiesensei>
Date: Fri, 09 May 2008 21:00:06 +0800
Tag: v1.9.1
MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports"
commit 6c90434d030dbd5ff9782c6bf366acc903fa9225
Author: jamiesensei <jamiesensei>
Date: Fri, 09 May 2008 14:06:29 +0800
Tag: v1.9.1
MDL-14637 "allow activity modules to add sub menus of settings pages to admin menu" and MDL-14565 "allow quiz reports to add configuration settings to the admin tree" added a mechanism to admin/settings/plugins.php to allow modules to include a file settingstree.php instead of settings.php which will allow for more flexibility of what a module can add to the admin settings menu.
commit bef711f560d39663808b5796d1b6d3f7febd26f9
Author: jamiesensei <jamiesensei>
Date: Thu, 08 May 2008 18:10:29 +0800
Tag: v1.9.1
For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is. Some changes to lang strings for overview report settings form to indicate that options affect downloaded data as well as data shown on the screen.
commit 50c68d01cccdc93f159da77417a2e1200729a6c6
Author: jamiesensei <jamiesensei>
Date: Thu, 08 May 2008 17:51:26 +0800
Tag: v1.9.1
For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is.
commit 18129bbfeed0bf82d78c013c793b8ff708d6bb9d
Author: jamiesensei <jamiesensei>
Date: Thu, 08 May 2008 17:31:05 +0800
Tag: v1.9.1
MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" adding a message about the highlighting above the table.
commit 1a827abb0c4535a1e581911e84f017f0ae0678b0
Author: jamiesensei <jamiesensei>
Date: Thu, 08 May 2008 16:56:23 +0800
Tag: v1.9.1
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" Oops. Seemed to have missed out part of the patch when merging into 1.9 from HEAD.
commit f39ebcea89f49e2259dc56f84ea311f5164bc713
Author: jamiesensei <jamiesensei>
Date: Thu, 08 May 2008 00:11:17 +0800
Tag: v1.9.1
MDL-14734 "improve interface for deleting attempts"
commit b44c702d455c03ae6b3a905a72e390beaaa91ebc
Author: jamiesensei <jamiesensei>
Date: Wed, 07 May 2008 22:40:57 +0800
Tag: v1.9.1
MDL-14201 "Summary graph" included a summary graph at the bottom of overview report page. Shows the distribution of grades achieved by students. If a group is selected the grades from the group are compared with the grades for all participants.
commit e0fb4a87432d61a6e8ac02e5855a9e8d6a370380
Author: jamiesensei <jamiesensei>
Date: Wed, 07 May 2008 22:38:18 +0800
Tag: v1.9.1
file overviewgraph.php was added on branch MOODLE_19_STABLE on 2008-05-07 14:40:57 +0000
commit 839d72b06cfbb2470d0b7165dca8a46bd6fcbe9d
Author: jamiesensei <jamiesensei>
Date: Wed, 07 May 2008 22:02:31 +0800
Tag: v1.9.1
For the overview report : MDL-14199 "Option to only show / export final grade" fixing a notice warning from the form definition Merged from HEAD
commit 6131f70069d745b564b2f85e27ebbbe0cb4a7ee2
Author: jamiesensei <jamiesensei>
Date: Wed, 07 May 2008 02:06:33 +0800
Tag: v1.9.1
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score"
commit beb6d00f468c0c2b3c8d6669ddfab85ca667846c
Author: jamiesensei <jamiesensei>
Date: Mon, 05 May 2008 21:18:14 +0800
Tag: v1.9.1
For overview report - MDL-14185 "Switch to using formslib and improve the interface" and MDL-14186 "Switch to using moodle_url and eliminate the use of $SESSION global"
commit 9df9473d98040d493b2248668f8f5ba1e1470ba4
Author: jamiesensei <jamiesensei>
Date: Mon, 05 May 2008 21:12:11 +0800
Tag: v1.9.1
file overviewsettings_form.php was added on branch MOODLE_19_STABLE on 2008-05-05 13:18:14 +0000
commit 720c94fa06e15f9e504a75e48d9398ba4e77d04f
Author: jamiesensei <jamiesensei>
Date: Sat, 03 May 2008 21:43:44 +0800
Tag: v1.9.1
MDL-14677 "should rescale the grades displayed for each question in the detailed marks view of the overview report so that all grades add up to the sum total grade" used quiz_rescale_grades function to rescale the grade properly before displaying it. Also this patch includes some general clean up and refactoring of overview report.
commit aa45776dd72fd5bd68003876cc995fa5a93f54b1
Author: jamiesensei <jamiesensei>
Date: Sat, 03 May 2008 00:14:11 +0800
Tag: v1.9.1
MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text." Also fixing the problem in link_to_popup_window function. Test for null instead of empty.
commit c912dab6daca51920435c1e97ad63fa17313b6e8
Author: jamiesensei <jamiesensei>
Date: Fri, 02 May 2008 23:25:19 +0800
Tag: v1.9.1
MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." Made a new query outside the loop for adding rows.
commit ada7af846f16d0fdf02e38f121caef4a4d6cb680
Author: jamiesensei <jamiesensei>
Date: Fri, 02 May 2008 22:23:02 +0800
Tag: v1.9.1
MDL-14664 "sorting by question mark when viewing detailled mark in overview quiz report not working" Found that the problem ocurred when attempt.id != attempt.uniqueid as the sql was using the wrong field to join the question records.
commit 833b1e0045db6a51063b05c891336f2618ae5690
Author: jamiesensei <jamiesensei>
Date: Fri, 02 May 2008 21:29:25 +0800
Tag: v1.9.1
MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text." Solved this by formatting the grade using number_format to display the grade with a number of decimal places. So for 0 we display something like 0.00 and this displays OK in link_to_popup_window.
commit 1ab2605768112abd2dd0ca0779558b014549baca
Author: jamiesensei <jamiesensei>
Date: Thu, 01 May 2008 15:40:54 +0800
Tag: v1.9.1
MDL-13678 "Change default number of rows per page on quiz reports" Made a new constant to say how many attempts / questions to list per page by default.
commit 521601d0ceb43c2532d7dccd4c1440490be054fc
Author: jamiesensei <jamiesensei>
Date: Thu, 01 May 2008 15:08:29 +0800
Tag: v1.9.1
file reportlib.php was added on branch MOODLE_19_STABLE on 2008-05-01 07:40:55 +0000
commit 0dd41b1891660a1b4d888628e999a1798942f1a1
Author: jamiesensei <jamiesensei>
Date: Wed, 30 Apr 2008 16:21:01 +0800
Tag: v1.9.1
MDL-7772 "Quiz results overview: not all combinations of Show attempts with ... & Groups settings work properly" This patch is based on Ann Adamcik's latest code, thanks Ann. Made a couple of small changes. This is equivalent to the two patches in HEAD for the same bug.
commit 1fe2c24de394472fa9b3752c7c263eb55cfb9e23
Author: jamiesensei <jamiesensei>
Date: Tue, 05 Feb 2008 21:08:38 +0900
Tag: v1.9.0
MDL-13298 "Question bank displays always page 1 after adding new question" this was caused because the question creation page was redirecting back to the question back edit page and telling it to change to the category of the question that was just saved. This was causing the edit page to go back to page 0 of the new category. Now we only go back to page 0 if the category has actually changed.
commit c6a40756095c4013783798d5fbf07a30a9c6d416
Author: jamiesensei <jamiesensei>
Date: Tue, 05 Feb 2008 20:24:19 +0900
Tag: v1.9.0
MDL-13005 When trying to restore a course when you have more then one quiz and you choose only one quiz, the restore fails when trying to create categories and questions. Fixed this by ignoring module context level q categories in backup when the course module has not already been restored.
commit 4811aacb5a3bf25f7b56f8e36287961584b60d3f
Author: jamiesensei <jamiesensei>
Date: Tue, 05 Feb 2008 19:16:40 +0900
Tag: v1.9.0
MDL-13034 fixes "insertion of question / category ids at the CONTEXT_MODULE level does not respect whether the instance of the module has been selected for backup" and cleans up code a little. The last commit for this issue did not include any changes.
commit ed3a8746328a3ce0b4aae32466f8b13aaef07989
Author: jamiesensei <jamiesensei>
Date: Fri, 25 Jan 2008 16:06:34 +0900
Tag: v1.9.0
MDL-13156 "insert_category_and_question_ids() function name can cause name conflicts"
commit acfc18d8e89450f40818844560b74a396f83767e
Author: jamiesensei <jamiesensei>
Date: Sat, 19 Jan 2008 00:09:55 +0900
Tag: v1.9.0
MDL-13034 fixes "insertion of question / category ids at the CONTEXT_MODULE level does not respect whether the instance of the module has been selected for backup" and cleans up code a little. merged from HEAD
commit 4a6a7074ce8d813032581bbc1f64e8b0ba32f2df
Author: jamiesensei <jamiesensei>
Date: Sun, 13 Jan 2008 17:54:56 +0900
Tag: v1.9.0
MDL-12695 Symantec Norton internet security pop up blocker seems to be stopping user starting a quiz attempt - fixed this by using print_single_button which uses an onclick event to trigger a confirm dialogue, should work better even with popup blockers.
commit f92b08d9e19338ed2a72c971848fb5f490ffc631
Author: jamiesensei <jamiesensei>
Date: Sun, 13 Jan 2008 17:35:38 +0900
Tag: v1.9.0
whitespace clean up, removed all indentation with tabs and trailing white space
commit d42e5b0034920670fcac6aff254151540b1abcc1
Author: jamiesensei <jamiesensei>
Date: Sun, 13 Jan 2008 17:09:09 +0900
Tag: v1.9.0
MDL-12906 add an optional parameter $jsconfirmmessage parameter to print_single_button
commit be350cb12753ff11615f3b3917e2dbc2790f4f93
Author: jamiesensei <jamiesensei>
Date: Tue, 11 Dec 2007 12:54:21 +0900
Tag: v1.9.0
MDL-12410 - a way to select which questions to export, includes debug messages
commit 619b3ca8db43bea7b8c4eae094399c7c499ccb89
Author: jamiesensei <jamiesensei>
Date: Mon, 26 Nov 2007 22:34:47 +0900
Tag: v1.9.0
fix for error message
commit 6f9ce92696ab5802bf6e9e25566cdc5f7685aaf0
Author: jamiesensei <jamiesensei>
Date: Wed, 10 Oct 2007 23:23:24 +0800
Tag: v1.9.0
fix for MDL-11692. There were notices about subquestions not being defined. This seems to indicate that there is a problem elsewhere that somehow matching questions without subquestions are in the site db. But suppressed the notice by testing to see if subquestions is set before looping through the questions.
commit be801b8b3afd80b3eb66d86577b98c8dd039fdac
Author: jamiesensei <jamiesensei>
Date: Wed, 03 Oct 2007 12:42:57 +0800
Tag: v1.9.0
MDL-11139 "Need to pass courseid or cmid to this script when moving questions between categories " added COURSE to globals in function that redirects browser to contextmoveq page.
commit 489984a7a27ba5601ee1790c93afbd03f7bd8c9e
Author: jamiesensei <jamiesensei>
Date: Wed, 03 Oct 2007 11:16:27 +0800
Tag: v1.9.0
fix for fatal error in tabs.php because of missing global var contexts.
commit 11a6096775e9a786848652f0e48904d56fdbeaf4
Author: jamiesensei <jamiesensei>
Date: Thu, 27 Sep 2007 16:17:09 +0800
Tag: v1.9.0
fixed closing of popup on saving question which was broken and also added closing of popup on cancel.
commit cb14dd63169b409b595b7145c21de431d9736f15
Author: jamiesensei <jamiesensei>
Date: Thu, 27 Sep 2007 15:41:58 +0800
Tag: v1.9.0
modifiedby and timemodified is now set when a question is created as well as createdby and timecreated instead of being left as zero
commit 87dfa4d26f23de58988b7db714af79339cfe710a
Author: jamiesensei <jamiesensei>
Date: Mon, 24 Sep 2007 21:23:58 +0800
Tag: v1.9.0
MDL-11423 removed a stray print_object call
commit 8f0f605ddfd0e892896985ab4c3d17f32d73e682
Author: jamiesensei <jamiesensei>
Date: Tue, 18 Sep 2007 19:23:29 +0800
Tag: v1.9.0
moved question_make_default_categories function to questionlib.php since it is needed by other modules outside the question bank editing interface.
commit 41b6d0011c7a143df3062be8454f2bb18b200238
Author: jamiesensei <jamiesensei>
Date: Tue, 18 Sep 2007 17:35:44 +0800
Tag: v1.9.0
MDL-11318 formslib now respects a template for an element if it is set. But since formslib uses the templates to insert help buttons for setAdvanced functionality etc. if you use templates you will lose this functionality.
commit 15822170d42ec01bceb31944cd84e81bfb262d91
Author: jamiesensei <jamiesensei>
Date: Tue, 11 Sep 2007 17:01:21 +0800
Tag: v1.9.0
removing require that is not needed
commit 479cca8a1e31215bb3f851882c0dc76013af31d7
Author: jamiesensei <jamiesensei>
Date: Tue, 11 Sep 2007 16:23:00 +0800
Tag: v1.9.0
fix to make breadcrumbs module independent
commit 15b83581ce5b665a58b1f72e1edbd241531666a9
Author: jamiesensei <jamiesensei>
Date: Mon, 10 Sep 2007 21:28:18 +0800
Tag: v1.9.0
test for has_capability before displaying choosecoursefile control as if user does not have permission then control is useless.
commit d0508099c6e86a3b270dfc41e78871c43cbba25c
Author: jamiesensei <jamiesensei>
Date: Fri, 07 Sep 2007 16:01:08 +0800
Tag: v1.9.0
oops. Stray 'as' used for table name alias in SQL.
commit 5d5a477f1a15ed6aa474785be82289a4eecdbc6c
Author: jamiesensei <jamiesensei>
Date: Tue, 04 Sep 2007 21:28:50 +0800
Tag: v1.9.0
removing redundant string fetches
commit 6943c3b9caef43aaf56f4ad51d4290313d10222a
Author: jamiesensei <jamiesensei>
Date: Tue, 04 Sep 2007 20:42:03 +0800
Tag: v1.9.0
removed stray echo statement
commit 9fc3100f2721ba57bc9c7afaddea120d460153c3
Author: jamiesensei <jamiesensei>
Date: Tue, 04 Sep 2007 19:55:10 +0800
Tag: v1.9.0
fix for MDL-11106 Images not showing up in shared categories
commit 3a4a9233ce4f8d34a76158d9be78458f3eb3d08f
Author: jamiesensei <jamiesensei>
Date: Tue, 04 Sep 2007 13:44:14 +0800
Tag: v1.9.0
fix for some problems with page params
commit 1672b5462fd2a3d83a946198e70a2b479be1faff
Author: jamiesensei <jamiesensei>
Date: Mon, 03 Sep 2007 21:09:04 +0800
Tag: v1.9.0
removing qcreate directory that I accidentally committed to HEAD when trying to commit changes to the NEWMODULE template.
commit 594019f7937c81cea039912a438040b603d08677
Author: jamiesensei <jamiesensei>
Date: Mon, 03 Sep 2007 21:03:20 +0800
Tag: v1.9.0
bit more detail for what needs renaming
commit 0d6e8291a0a5e5df61eca2cf7916d8a26a963518
Author: jamiesensei <jamiesensei>
Date: Mon, 03 Sep 2007 19:51:25 +0800
Tag: v1.9.0
MDL-11108 some PHP notices on upgrade of sites to 1.9 where there are no question categories set up
commit 35241c761a698bbb5eedbc6ff2d8796aefb19bd8
Author: jamiesensei <jamiesensei>
Date: Mon, 03 Sep 2007 13:30:38 +0800
Tag: v1.9.0
MDL-10952 update help files for new question code
commit 0647e82b57e5bc6f4046208b916520b78fe7d832
Author: jamiesensei <jamiesensei>
Date: Wed, 29 Aug 2007 11:04:01 +0800
Tag: v1.9.0
check for viewall / viewmine permission for each question in a category selected for export.
commit 522b89d1aa06f70657e4c29edde0b09075d7dc7f
Author: jamiesensei <jamiesensei>
Date: Tue, 28 Aug 2007 11:36:17 +0800
Tag: v1.9.0
allow selection of category in any context when adding a question in question_form
commit f3771632e8ec81b28f4ad4c5bc6a32d853d6a4ae
Author: jamiesensei <jamiesensei>
Date: Wed, 22 Aug 2007 16:22:06 +0800
Tag: v1.9.0
MDL-10849 "During question bank upgrade, add course shortname to category name, if it is moved to the site level"
commit afb36bca448fc79c4a08714dd333451a16579417
Author: jamiesensei <jamiesensei>
Date: Wed, 22 Aug 2007 12:28:26 +0800
Tag: v1.9.0
MDL-10938. 'only strings from lang files can be used as feedback in environment check. Some way is needed to include data from custom check function - a $a param to pass to get_string'. Custom check for questions uses new functionality to print more complex strings as feedback.
commit 57dce727cd14055869dda3e8353ed9c0b9f8d2fc
Author: jamiesensei <jamiesensei>
Date: Wed, 22 Aug 2007 12:19:04 +0800
Tag: v1.9.0
fixed a spello in a string
commit 6d1083c52f540461bd306d47b58b0bb834f11399
Author: jamiesensei <jamiesensei>
Date: Tue, 21 Aug 2007 14:55:48 +0800
Tag: v1.9.0
fix for some xhtml syntax errors.
commit 56beb4e2629bf8296a35da5d17738e5688872542
Author: jamiesensei <jamiesensei>
Date: Mon, 20 Aug 2007 19:12:11 +0800
Tag: v1.9.0
removed some use of AS for table aliases in SQL.
commit a7f6dc55fa83399e06dbf4502e91be277810787c
Author: jamiesensei <jamiesensei>
Date: Mon, 20 Aug 2007 18:58:11 +0800
Tag: v1.9.0
Adding lang strings for new question capabilities and removing some old ones.
commit 688cc5d01c87b24cadd81cc86886b03a8b807ad3
Author: jamiesensei <jamiesensei>
Date: Mon, 20 Aug 2007 11:36:07 +0800
Tag: v1.9.0
Fix for MDL-10776 "Moodle Faulty navigation in questions categories when editing questions or exporting/importing categories"
commit 8a3b3e66bd82eaf957114836c8c8038665fb7346
Author: jamiesensei <jamiesensei>
Date: Mon, 20 Aug 2007 10:55:27 +0800
Tag: v1.9.0
MDL-10812 changed 'Modified' string to 'Last Saved' since as pointed out often someone might press the save button after viewing a question without making any modifications.
commit 88c8015ea0910a3180639eb2a6db30526239a5e4
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 18:50:52 +0800
Tag: v1.9.0
fixing some problems with multichoice file link find and replace code for multichoice qtype.
commit 4119b7ba53eb6b1408e332dcb201300c9747c645
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 18:47:49 +0800
Tag: v1.9.0
help file for new site files backup feature.
commit 863be1a95cb1327164ab8a47ce4b06f32404c566
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 18:03:18 +0800
Tag: v1.9.0
Added a help button to the backup form.
commit 1a73a3d84ed6e079438e230d85145403d5a796e9
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 18:00:00 +0800
Tag: v1.9.0
Fixes for some notices because of unitialized vars and elements that may not be present in older backup xml.
commit 7c1c94872e9e453dbb18c489539b5cfa12b88d29
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 17:53:00 +0800
Tag: v1.9.0
Fix for notice on first page of restore.
commit 79bb7202001a96f8f31a60a249dd18cb65a9d2c9
Author: jamiesensei <jamiesensei>
Date: Fri, 17 Aug 2007 09:06:02 +0800
Tag: v1.9.0
Fixed MDL-10855 'Calculated question error: undefined stdClass::$nextpageparam' and some other calculated question bugs.
commit 610ef0930fab5fbabb8c281b87c3b7c068b0a502
Author: jamiesensei <jamiesensei>
Date: Thu, 16 Aug 2007 18:44:07 +0800
Tag: v1.9.0
oops. Removed stray die; that was in the code for debug purposes.
commit ba18b21d2ece55e5776237875045389c2a69cc15
Author: jamiesensei <jamiesensei>
Date: Thu, 16 Aug 2007 13:25:00 +0800
Tag: v1.9.0
Fix for MDL-10852 Cannot edit existing questions
commit ffba1f0bec537fc3815b79091f69bfa60f0cfd85
Author: jamiesensei <jamiesensei>
Date: Thu, 16 Aug 2007 13:20:35 +0800
Tag: v1.9.0
added some comments
commit 9f1017a0be550b9a20e733ae3dbde904e3ac35fb
Author: jamiesensei <jamiesensei>
Date: Thu, 16 Aug 2007 13:19:33 +0800
Tag: v1.9.0
correct logic error that broke caching.
commit 0cbddd850bfc88776d54b9203673c790c8f2019a
Author: jamiesensei <jamiesensei>
Date: Wed, 15 Aug 2007 19:36:01 +0800
Tag: v1.9.0
MDL-10857 broken link in navlinks for question bank pointing to mod/modname/view.php with cmid param instead of id param
commit f6ea3132c163d75132526bfce39732ad049e654a
Author: jamiesensei <jamiesensei>
Date: Wed, 15 Aug 2007 19:08:37 +0800
Tag: v1.9.0
small commenting change
commit 20f500dc4d23361585e996e2dd7922e75ab69665
Author: jamiesensei <jamiesensei>
Date: Wed, 15 Aug 2007 19:04:35 +0800
Tag: v1.9.0
Fix for MDL-10847 No categories showing in category tab when editing a quiz / questions on PHP 4
commit 00de7c984cc6ed38a7d8d818263cc710b97fcaf2
Author: jamiesensei <jamiesensei>
Date: Tue, 14 Aug 2007 19:50:57 +0800
Tag: v1.9.0
fix for notice about undefined urls property.
commit a54fd2dd4d6e91e420f8790c57f361ba3d3a8098
Author: jamiesensei <jamiesensei>
Date: Tue, 14 Aug 2007 19:41:47 +0800
Tag: v1.9.0
fix for notice about undefined urls property.
commit e7e62d45be8090f0c6e8279dd46e557243d6ac6e
Author: jamiesensei <jamiesensei>
Date: Tue, 14 Aug 2007 12:22:05 +0800
Tag: v1.9.0
Fix for MDL-10823 Access to question edit page denied from quiz preview screen.
commit af49b38948d9f8bd49884cddc3c344a5ac98d67a
Author: jamiesensei <jamiesensei>
Date: Tue, 14 Aug 2007 10:56:43 +0800
Tag: v1.9.0
small fix for breadcrumbs link
commit 9f877cb07250c62db928a73d3d42fb5b8d227e86
Author: jamiesensei <jamiesensei>
Date: Tue, 14 Aug 2007 10:50:56 +0800
Tag: v1.9.0
fix for MDL-10835 Results and Preview Tabs broken - requred param 'cmid' missing (for quiz with no questions)
commit 681666abe7c4717b8d0593b9cb74981ae3de0158
Author: jamiesensei <jamiesensei>
Date: Mon, 13 Aug 2007 21:58:04 +0800
Tag: v1.9.0
fix for MDL-10826 ' Moodle Impossible to delete a course because of non-existent question_delete_activity() '
commit 8bdd8660bffaee3925f1d5e2b8fa0622445cd3b6
Author: jamiesensei <jamiesensei>
Date: Mon, 13 Aug 2007 00:09:57 +0800
Tag: v1.9.0
See http://moodle.org/mod/forum/discuss.php?d=77564#p345310 Questions link not showing up.
commit fd3772dc9456ff8d346013ca59e31276f466652a
Author: jamiesensei <jamiesensei>
Date: Sun, 12 Aug 2007 23:07:08 +0800
Tag: v1.9.0
MDL-10805 custom check was causing error on installation because dmllib functions are not available yet.
commit b36e36aa05081b9e1fee09b1f501ce9bc1ab6df1
Author: jamiesensei <jamiesensei>
Date: Sun, 12 Aug 2007 21:57:57 +0800
Tag: v1.9.0
removed all ASes from table aliases in question / quiz code - MDL-10344
commit ddaff15dfc0c2fc51fc27a33f55a54b2b726d59d
Author: jamiesensei <jamiesensei>
Date: Fri, 10 Aug 2007 15:58:48 +0800
Tag: v1.9.0
removing TODO type comment that was already done.
commit 070af8ed323d50bf2105fb0782202609f1e33f28
Author: jamiesensei <jamiesensei>
Date: Fri, 10 Aug 2007 15:56:02 +0800
Tag: v1.9.0
fixing reversion of lang string that happened during MOODLE_19_QUESTIONS merge
commit 515ed4c3ee1a03c9820f07f153ddc851a00902c4
Author: jamiesensei <jamiesensei>
Date: Fri, 10 Aug 2007 06:44:14 +0800
Tag: v1.9.0
merging MOODLE_19_QUESTIONS with HEAD
commit 271e6decdac9d9445c047a7d90cc98b7912cf1b6
Author: jamiesensei <jamiesensei>
Date: Fri, 10 Aug 2007 05:51:09 +0800
Tag: v1.9.0
merging MOODLE_19_QUESTIONS with HEAD
commit 3bee1ead40eae09709dfec2c6546938ed07613f5
Author: jamiesensei <jamiesensei>
Date: Fri, 10 Aug 2007 05:50:59 +0800
Tag: v1.9.0
merging MOODLE_19_QUESTIONS with HEAD
commit dfcdf0726bd3109a6a7af89304619ebc8637754b
Author: jamiesensei <jamiesensei>
Date: Thu, 09 Aug 2007 23:05:15 +0800
Tag: v1.9.0
fixed syntax error in last commit that fixes MDL-10768
commit 62f34fdb208c737c26af745f2c22496c4c1b0a47
Author: jamiesensei <jamiesensei>
Date: Wed, 08 Aug 2007 11:29:29 +0800
Tag: v1.9.0
fix for some notices in insert_category_ids function.
commit bb90bf3fb26da1096bfff558dbc57f166d237d48
Author: jamiesensei <jamiesensei>
Date: Mon, 16 Jul 2007 14:04:20 +0800
Tag: v1.9.0
when element is frozen should not escape html entities in htmleditor.
commit c0056e22270163bc7d627f72685c9f262b13b140
Author: jamiesensei <jamiesensei>
Date: Fri, 13 Jul 2007 16:14:37 +0800
Tag: v1.9.0
fix for MDL-10440 IE7 and IE6 on win xp error when changing "disable" state of "Start date"
commit df2c2310e52429584f5bf43b3ee46de19b10b13e
Author: jamiesensei <jamiesensei>
Date: Thu, 12 Jul 2007 14:01:17 +0800
Tag: v1.9.0
Reverted previous fix for MDL-10382 Allow removing of elements with disabledIf conditions - "This fix has broken disabledIf in many forms. The problem is that if the dependentOn element is an element in a group then elementExists will return false."
commit 43914931f7cafa7cd52740091b753f1e0aa52482
Author: jamiesensei <jamiesensei>
Date: Fri, 06 Jul 2007 12:03:51 +0800
Tag: v1.9.0
validation can return an empty array() or true to indicate no errors. array() is preferred since then parent class validation functions can be chained. Changing moodle_form validation method to return array() so that chaining works in question types. Shouldn't affect other forms code.
commit 7856a8c3840f72f5b47072314e2f1a0f11704c25
Author: jamiesensei <jamiesensei>
Date: Sat, 30 Jun 2007 12:22:51 +0800
Tag: v1.9.0
removing file that mistakenly was committed to HEAD
commit c28245d7e5e7a7d5b84bda659a1f9bb449537b60
Author: jamiesensei <jamiesensei>
Date: Sat, 30 Jun 2007 11:50:52 +0800
Tag: v1.9.0
test for questionlib on MOODLE_19_QUESTIONS branch
commit 20c55233c36d912e6a1930fb4a0846de312d9940
Author: jamiesensei <jamiesensei>
Date: Fri, 29 Jun 2007 22:19:22 +0800
Tag: v1.9.0
small change to make icons easier to override in child classes.
commit 16368d38a4397d0835c1af5e51fdc1cb55f53588
Author: jamiesensei <jamiesensei>
Date: Fri, 22 Jun 2007 19:02:45 +0800
Tag: v1.9.0
making environment colours css selector refer to table class instead of body id. So that colours show up on other pages besides admin page.
commit 53a0367d10fc4327a1a6f4dc4463bcb8d1b1fed6
Author: jamiesensei <jamiesensei>
Date: Wed, 20 Jun 2007 14:32:26 +0800
Tag: v1.9.0
added styles to install.php for colours for environment table
commit 770fef0a3c2ecb1afa8e2be7f6b480686398282f
Author: jamiesensei <jamiesensei>
Date: Tue, 19 Jun 2007 23:52:19 +0800
Tag: v1.9.0
MDL-10168 improvements to display of results from environment checks
commit 4579011918465dcbcd2c25de17e3a552881f0d09
Author: jamiesensei <jamiesensei>
Date: Tue, 19 Jun 2007 23:21:27 +0800
Tag: v1.9.0
elaborated phpdoc comment slightly for doc_link
commit 84e3d2ccf58d83f6ebed1f179e765c4626217d6b
Author: jamiesensei <jamiesensei>
Date: Tue, 19 Jun 2007 22:44:02 +0800
Tag: v1.9.0
refactored page_doc_link into two functions. doc_link returns a link to docs. page_doc_link returns the link for this page.
commit dc1f768351a5d4f4c541b4f6fbe1c12e02c7e2d5
Author: jamiesensei <jamiesensei>
Date: Tue, 29 May 2007 14:27:38 +0800
Tag: v1.9.0
reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
commit 24a905f98b86e147e5d366181d1dd028005d0830
Author: jamiesensei <jamiesensei>
Date: Tue, 29 May 2007 14:14:09 +0800
Tag: v1.9.0
fixed bug in parsing urls
commit d65cb30f630d69f13c7a3bedf2f43d12ef130c17
Author: jamiesensei <jamiesensei>
Date: Tue, 29 May 2007 14:14:09 +0800
Tag: v1.9.0
reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
commit 099f7fb6ca591e05a1f5d038698a13b9a6998be4
Author: jamiesensei <jamiesensei>
Date: Mon, 28 May 2007 22:25:40 +0800
Tag: v1.9.0
added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE.
commit b1a61961aad535d6c53516fbc2761856df9a7b7a
Author: jamiesensei <jamiesensei>
Date: Mon, 28 May 2007 22:21:09 +0800
Tag: v1.9.0
MDL-9745 "Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen." Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problem MDL-9745 with form elements in groups. Second part of commit in HEAD, missed a bit in HEAD.
commit 5eb1924f010d741d0ba70a547fb73598d55487dc
Author: jamiesensei <jamiesensei>
Date: Mon, 28 May 2007 20:17:40 +0800
Tag: v1.9.0
MDL-9745 Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen. Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problems with form elements in groups.
commit 3673f6bc3b2243b268f96c072c940a71618821eb
Author: jamiesensei <jamiesensei>
Date: Mon, 28 May 2007 08:50:11 +0800
Tag: v1.9.0
added more phpdoc comments for hardFreezeAllVisibleExcept
commit 56015454ddd29caa2a18434a96166d24df389988
Author: jamiesensei <jamiesensei>
Date: Mon, 28 May 2007 08:46:11 +0800
Tag: v1.9.0
new method hardFreezeAllVisibleExcept
commit 9368476553bc4b0ad5333343be92006ac92c6c3f
Author: jamiesensei <jamiesensei>
Date: Sun, 27 May 2007 19:19:04 +0800
Tag: v1.9.0
MDL-9734 fix for clean_param PARAM_LOCALURL bug
commit 64360ee7b551897ae000b8e31a45ec21abbc53d8
Author: jamiesensei <jamiesensei>
Date: Sun, 27 May 2007 13:01:51 +0800
Tag: v1.9.0
made hardFreeze work properly for a whole form. New paramater in moodleform constructor 'editable' defaults to true. If true then display form as normal. If false then hardFreeze whole form. Now displays form without an submit buttons. If form is hard frozen no data is ever passed to get_data.
commit 7d8ea286680c2e341c4c82709da425b428460f52
Author: jamiesensei <jamiesensei>
Date: Sun, 27 May 2007 12:53:02 +0800
Tag: v1.9.0
MDL-9891 new 'clonepermissionsfrom' key in access.php
commit 61d9b9fc5d63bd179443a5189f66ce98322f47e3
Author: jamiesensei <jamiesensei>
Date: Fri, 25 May 2007 13:49:51 +0800
Tag: v1.9.0
oops. reverting changes which shouldn't have been committed to HEAD.
commit bdc66c2a5dd0e15ace278cf3cc2d9c4f7e607a6d
Author: jamiesensei <jamiesensei>
Date: Fri, 25 May 2007 12:59:17 +0800
Tag: v1.9.0
fix for category.php lists. Slight change in listlib api caused breakage.
commit a69dacfd48218743dd39f8fcca36f00e5d04ffb7
Author: jamiesensei <jamiesensei>
Date: Wed, 23 May 2007 08:59:36 +0800
Tag: v1.9.0
reverting back to version 1.2. Accidentally committed version 1.3 in HEAD.
commit cd26d8e047fddda09f32b6e06f0aa5c5186d5c96
Author: jamiesensei <jamiesensei>
Date: Tue, 22 May 2007 18:09:22 +0800
Tag: v1.9.0
MDL-9857 "more options in print_context function"
commit 9ae3af87aef7243b53b638eeb67be34898f65838
Author: jamiesensei <jamiesensei>
Date: Tue, 22 May 2007 00:11:17 +0800
Tag: v1.9.0
MDL-9856 allow passing moodle_url to moodle_form constructor as action instead of passing url as a string
commit d92b9d91400f4a026dbb22b2c8a4f4af4eba2c3e
Author: jamiesensei <jamiesensei>
Date: Mon, 21 May 2007 17:26:17 +0800
Tag: v1.9.0
new sql to fetch question counts for categories all in one sql query. Question count now included in drop down box.
commit 83bc64dba48e99ca28e8330cf00dd5d37ac65803
Author: jamiesensei <jamiesensei>
Date: Mon, 21 May 2007 01:05:27 +0800
Tag: v1.9.0
adding quoting to output of hidden params in moodle_url
commit 3a3c454ede62ad5b1ce515b39a8861df30c45e4a
Author: jamiesensei <jamiesensei>
Date: Mon, 21 May 2007 00:17:48 +0800
Tag: v1.9.0
UI for editing questions changed to support sharing questions in multiple contexts. Also changed import / export and category editing form to use formslib.
commit fae60ee3d348fdad35ad04072d3866bbfde414e4
Author: jamiesensei <jamiesensei>
Date: Sun, 20 May 2007 22:05:49 +0800
Tag: v1.9.0
small additions to comments on moodle_url
commit b0bc5219d88fcce30053709f9eb9c5d2d39457c3
Author: jamiesensei <jamiesensei>
Date: Sun, 20 May 2007 21:59:58 +0800
Tag: v1.9.0
some changes to listlib to make it possible to chain the paging of several lists together that are displayed on the same page, so that paging can work across several lists
commit 305f5b4b1d5328d8623043ef46348c66898ebebd
Author: jamiesensei <jamiesensei>
Date: Sun, 20 May 2007 19:56:57 +0800
Tag: v1.9.0
removed unecessary sesskey hidden param. sesskey is automatically included and processed in formslib forms. Removed redundant validation method.
commit f161729e21570233298768d633f5d005f6e70457
Author: jamiesensei <jamiesensei>
Date: Sun, 20 May 2007 19:48:02 +0800
Tag: v1.9.0
new element for formslib selectgroups is a select drop down with options grouped into optgroups
commit 7bd434264243fb2675c5daf7fa25fa1a8350d62b
Author: jamiesensei <jamiesensei>
Date: Sun, 20 May 2007 19:20:49 +0800
Tag: v1.9.0
small fix for uninitialised var
commit 850e85b7b29b6d550a04059c11f2edd26ed595ed
Author: jamiesensei <jamiesensei>
Date: Sat, 12 May 2007 06:22:14 +0800
Tag: v1.9.0
some changes to make it easier to override editing icons in child classes and to make several lists work well with each other on the same page.
commit 85c375c3f8301d8291a1a2ead3a9063a9af0f389
Author: jamiesensei <jamiesensei>
Date: Tue, 08 May 2007 00:57:23 +0800
Tag: v1.9.0
added function callbacks for module specific controls to question bank.
commit 0de94538ee54fe2fa09aab769a0fc31c60ebbadc
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 23:38:02 +0800
Tag: v1.9.0
fixed links on edit icons so that they return to question bank page.
commit 7cd4fda6e7819e5cad1bd726b0bba429bc78c9d3
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 23:16:07 +0800
Tag: v1.9.0
changing param type for returnurl to PARAM_LOCALURL
commit 64eeaf47536a106fca335e70d9a0f0bb636701f8
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 15:13:14 +0800
Tag: v1.9.0
removed all session fromurl and returnurl stuff from question bank editing code. Returnurls are now passed as get/post params.
commit f86c2c84b1f0b94108600b2be0c83a6f83474c7d
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 15:08:41 +0800
Tag: v1.9.0
fixed error in import.php category object fetching logic
commit 561fe61df30268869a4bf5782d99b7d9ebd0775c
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 14:35:33 +0800
Tag: v1.9.0
return to the proper page after editing a question in the question bank.
commit d340fde6c47ba873922e3c5f229cbb7e95d6aa1d
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 13:57:49 +0800
Tag: v1.9.0
oops. Accidentally committed a change in default no of category items displayed which I'd changed for debug purposes. Reverting change.
commit 986effb653b7f4d1958de36d55b984974a348898
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 13:53:20 +0800
Tag: v1.9.0
pass the category list page param from page to page in question bank editing pages.
commit 400edee1ec672cf7eeca468d436337e0e17f5f0a
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 13:30:06 +0800
Tag: v1.9.0
always make sure that page param is in the pageurl
commit 81be5cdec30f6ce19db3186ce012d144210c5b0f
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 13:25:44 +0800
Tag: v1.9.0
added argument to constructor to specify the name of the page parameter used to pass the page no of the list. Default to 'page'
commit a4758a8632b7a5480f34bfaf1d738949128a5053
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 13:12:09 +0800
Tag: v1.9.0
require_login is in 'question_edit_setup' we don't need to call it again here.
commit 7bc26c8f6df85c14f008265e8b85bba49135dba6
Author: jamiesensei <jamiesensei>
Date: Mon, 07 May 2007 12:55:55 +0800
Tag: v1.9.0
changes to pass category id from page to page in question bank editing.
commit 36e298bc5820c9d2a6b8f8fae4bcb61f23cf5f2b
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 18:46:33 +0800
Tag: v1.9.0
removed more session stuff from question list and category form in question bank display code
commit 9ab3847595f8eb3de55407b75cfcbb7aca3b35cb
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 16:33:28 +0800
Tag: v1.9.0
tightening up reg expressions used for submitted data a bit
commit 1d88985787dbede9a7aacbb9847752880129d892
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 14:09:37 +0800
Tag: v1.9.0
removing TODO comment as the question.php script no longer treats quiz as special.
commit c65b63deb61ff2fc110702c5d15e327c88449948
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 13:51:59 +0800
Tag: v1.9.0
removed global var declaration for var that wasn't used in function
commit 9ab75b2bcc2539abd873ab1e292691afc33bb935
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 13:47:59 +0800
Tag: v1.9.0
passing cmid to question.php and removed use of session modform var. Question.php now independent of quiz module. Small improvement to displayed breadcrumbs.
commit e744ebba7bea7550202da95332554aa4591943b6
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 13:45:33 +0800
Tag: v1.9.0
added a param to moodle_url constructor to provide params as an array just as a convenience to quickly construct a url with an array of params.
commit e22618dd73a529e36208a92abb1d10400716f3a8
Author: jamiesensei <jamiesensei>
Date: Fri, 04 May 2007 13:30:03 +0800
Tag: v1.9.0
deleted redundant method which was just calling the parent method.
commit b07b4bd2462371e905cea8f38782a1c9859e8e0d
Author: jamiesensei <jamiesensei>
Date: Thu, 03 May 2007 18:38:35 +0800
Tag: v1.9.0
removed use of session for reordertool and show page breaks. Reordertool and show page breaks params are now passed from page request to page request only for page requests for quiz/edit.php
commit b72ff476856a4496d9dee0a78fc08b5b64ffed36
Author: jamiesensei <jamiesensei>
Date: Thu, 03 May 2007 18:10:01 +0800
Tag: v1.9.0
moved question sort order and paging params to be passed from page to page as get params instead of being saved in session var.
commit fcdb06c470a2b7023b0db1b46244d631e783be6c
Author: jamiesensei <jamiesensei>
Date: Thu, 03 May 2007 18:03:59 +0800
Tag: v1.9.0
change to print_paging_bar function to optionally support the use of a moodle_url object as a parameter instead of a string.
commit 86909ce047e631102824ea1d659ea9eff0f653e8
Author: jamiesensei <jamiesensei>
Date: Thu, 03 May 2007 13:17:07 +0800
Tag: v1.9.0
small fix to get question code to return to correct place after creating a new question.
commit 360e503e6e2da6a7e8f3e6ad05916aa8db7ee64f
Author: jamiesensei <jamiesensei>
Date: Thu, 03 May 2007 12:34:53 +0800
Tag: v1.9.0
MDL-9644 new class 'moodle_url' in weblib.php to handle constructing a url. It would internally stores params as an array and have methods to manipulate the array. The class can also output the params as hidden fields in a form or as a url with get params appended.
commit 71e0eda8f7991dac52b3430f88018962d13e2049
Author: jamiesensei <jamiesensei>
Date: Mon, 30 Apr 2007 14:48:57 +0800
Tag: v1.9.0
standardizing params for edit question page. All pages now use courseid instead of course or id.
commit efe839dc122ba85e51323dd1e5556a17685ca17f
Author: jamiesensei <jamiesensei>
Date: Fri, 27 Apr 2007 19:27:57 +0800
Tag: v1.9.0
Removed 'edit category' redundant button
commit 1f21cc88f75a4a4623f5997f3fd3cee4ee40bc93
Author: jamiesensei <jamiesensei>
Date: Fri, 27 Apr 2007 13:55:57 +0800
Tag: v1.9.0
removed global vars declaration for var not used in method.
commit f3ba642c5cb20de0c96ff2780cc80c0bef8d9935
Author: jamiesensei <jamiesensei>
Date: Fri, 27 Apr 2007 13:48:12 +0800
Tag: v1.9.0
forget to pass page parameter during redirects.
commit 0d32a25dd5c611f5cf281940fb22ce721f7f71af
Author: jamiesensei <jamiesensei>
Date: Fri, 27 Apr 2007 13:36:03 +0800
Tag: v1.9.0
oops. small mistake with copyright notice.
commit a982d582c4f5918cf5b1c1c10961a0dba74873c5
Author: jamiesensei <jamiesensei>
Date: Wed, 25 Apr 2007 22:06:37 +0800
Tag: v1.9.0
Added redirects after all actions. Added methods to category class to generate a url from an array of parameters stored in the object. Cleaned up some old redundant code for actions now processed in list class.
commit dac786f300cd35b7d40fafe29399d36435c068c8
Author: jamiesensei <jamiesensei>
Date: Thu, 19 Apr 2007 16:57:54 +0800
Tag: v1.9.0
MDL-9437 lib/listlib.php for displaying and editing a nested list of items. And changes to question\category.php to use the new lists.
commit 8a3719f5176bdec14088d141a3340fd6f4790a20
Author: jamiesensei <jamiesensei>
Date: Thu, 12 Apr 2007 22:59:32 +0800
Tag: v1.9.0
making notifytiny style a little bigger
commit 632b88d5a27542acc4019e9d884426dbfb4e01bb
Author: jamiesensei <jamiesensei>
Date: Fri, 06 Apr 2007 14:01:11 +0800
Tag: v1.9.0
see MDL-8886.
commit db8e700b0a7d60ad253845b407da43973fdd0e9d
Author: jamiesensei <jamiesensei>
Date: Wed, 04 Apr 2007 18:16:22 +0800
Tag: v1.9.0
fixes MDL-9195 mform->hardFreeze() doesn't remove id attribute of label for checkbox
commit 24e25bc124025a4dac6c461191a30305e45521e7
Author: jamiesensei <jamiesensei>
Date: Tue, 13 Mar 2007 23:50:22 +0900
Tag: v1.9.0
small change to fix MDL-8788 which was a problem with non unique header element names
commit 120e5cbf4ca36ee2f30f37d0df6d409305064555
Author: jamiesensei <jamiesensei>
Date: Thu, 01 Mar 2007 16:45:22 +0900
Tag: v1.9.0
fiexs MDL-8659 : Impossible to create Cloze type question in Moodle 1.8 beta
commit f5efac7b85d4894f2596044e1ded6389f1d50c42
Author: jamiesensei <jamiesensei>
Date: Mon, 26 Feb 2007 15:38:47 +0900
Tag: v1.9.0
fixes (MDL-8449) Quiz start and close times should allow the teacher to select a time as well as a date.